Jacob Vosmaer
b1f22aa35a
Gotta have newlines
2016-02-01 12:27:35 +01:00
Jacob Vosmaer
2679ec4066
Merge branch 'master' of https://gitlab.com/gitlab-org/gitlab-ce into git-raw-workhorse
2016-02-01 11:33:36 +01:00
Jacob Vosmaer
02afa6793c
Use only one header to send git blobs
2016-02-01 11:33:22 +01:00
Douwe Maan
677b4db9e6
Mark inline difference between old and new paths when a file is renamed
2016-01-29 19:37:17 +01:00
Robert Speicher
ca05054ea2
Partially revert "Add IP check against DNSBLs at account sign-up"
...
This partially reverts 6a5cd3ca - we keep the migration and add a new
migration that reverts it in order to keep migration history intact.
2016-01-28 16:28:19 -05:00
Robert Speicher
0e79b5f396
Merge branch 'highlight-blame' into 'master'
...
Fix highlighting in blame view.
See merge request !2630
2016-01-28 20:30:21 +00:00
Dmitriy Zaporozhets
ee8884c68e
Merge branch 'fix-preventing-migration-from-crashing-in-specific-cases' into 'master'
...
Fix preventing migration from crashing in very specific cases
Closes #12606 . Closes #12501 .
/cc @yorickpeterse @dbalexandre
See merge request !2600
2016-01-28 15:20:14 +00:00
Douwe Maan
b636f83e59
Move blame group logic to dedicated class
2016-01-28 14:49:21 +01:00
Rémy Coutable
55ab92c00b
Use ActiveRecord::Base.connection.active? and rescue any exception in connect_to_db?
...
This ensures that rake tasks that don't need a DB connection can be run
without one.
2016-01-28 12:23:37 +01:00
Rémy Coutable
869b4d7c6a
Only create the defaults ApplicationSetting when DB is fully migrated
...
Return a fake application settings OpenStruct when this is not the case.
Also, use ActiveRecord::Base.connection_pool.active_connection? instead
of ActiveRecord::Base.connection.active? to avoid driver exception.
2016-01-28 11:26:28 +01:00
Rémy Coutable
e6f3fe5d3b
Ensure rake tasks that don't need a DB connection can be run without one
...
When using ActiveRecord::Base.connection.active? without a DB
connection, we get a "PG::ConnectionBad: could not connect to server"
error because ActiveRecord::Base.connection doesn't exist. By using
ActiveRecord::Base.connected? we ensure we don't get this error if
the connection is missing, which is the all point of the
Gitlab::CurrentSettings#connect_to_db? method!
2016-01-26 15:11:15 +01:00
Douglas Barbosa Alexandre
b58a2e30b2
Wrap errors on GitHub importer to raise Projects::ImportService::Error
2016-01-26 10:56:22 -02:00
Douglas Barbosa Alexandre
c040323419
Move Gitlab::BitbucketImport::KeyDeleter to it's own importer
2016-01-26 10:56:22 -02:00
Yorick Peterse
b74308c0a7
Correct arity for instrumented methods w/o args
...
This ensures that an instrumented method that doesn't take arguments
reports an arity of 0, instead of -1.
If Ruby had a proper method for finding out the required arguments of a
method (e.g. Method#required_arguments) this would not have been an
issue. Sadly the only two methods we have are Method#parameters and
Method#arity, and both are equally painful to use.
Fixes gitlab-org/gitlab-ce#12450
2016-01-25 21:28:59 +01:00
Rémy Coutable
cd22da3ebd
Fix preventing migration from crashing in very specific cases
...
See https://gitlab.com/gitlab-org/gitlab-ce/issues/12606 for details
2016-01-25 20:00:59 +01:00
Valery Sizov
be7bc9d9b0
Backport some changes from EE
2016-01-22 11:24:44 +02:00
Robert Speicher
2fed8bf390
Merge branch 'fix-diff-comments' into 'master'
...
More highlighted diff fixes
See merge request !2545
2016-01-22 07:37:47 +00:00
Robert Speicher
9a5f83a30a
Merge branch 'unescaped-diffs' into 'master'
...
Make sure non-highlighted diffs are still escaped
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/12521
See merge request !2544
2016-01-22 01:35:39 +00:00
Douwe Maan
3db24ec9e8
Properly highlight right side of parallel diff
2016-01-22 02:12:43 +01:00
Douwe Maan
16d17b78ca
Restore diff comments
2016-01-22 02:10:58 +01:00
Douwe Maan
82d0fa8e45
Fix
2016-01-22 01:53:01 +01:00
Douwe Maan
150b4f66e6
Make sure non-highlighted diffs are still escaped
2016-01-22 01:47:17 +01:00
Robert Speicher
3f5e6c6cf6
Merge branch 'ci/recursive-artifacts-entries' into 'master'
...
Add method to calculate total size of artifacts in subpath
See merge request !2500
2016-01-21 23:23:02 +00:00
Douglas Barbosa Alexandre
4861b1bbfb
Fix import of GitHub's wiki when the repository has not been created
2016-01-21 13:11:38 -02:00
Robert Speicher
3e7092a83a
Merge branch 'fix-github-pull-requests-import' into 'master'
...
Fix cross projects detection when importing GitHub pull requests
Fixes #12456
See merge request !2523
2016-01-20 22:11:20 +00:00
Douglas Barbosa Alexandre
f4bdbecfd5
Fix cross projects detection when importing GitHub pull requests
2016-01-20 19:36:35 -02:00
Kamil Trzcinski
9b0f57781e
Add method that calculates total size for artifacts subfolder
2016-01-20 21:55:13 +01:00
Rubén Dávila
985297d82a
Merge branch 'master' into issue_3945
2016-01-20 15:07:00 -05:00
Douwe Maan
6000f8545f
Validate bounds just to be sure
2016-01-20 19:33:34 +01:00
Douwe Maan
0e992a3b4e
Properly highlight lines around '\ No newline at end of file'
2016-01-20 19:20:13 +01:00
Douwe Maan
577f2fb47a
Save and use actual diff base commit for MR diff highlighting
2016-01-20 18:44:27 +01:00
Tomasz Maczukin
8536e083f7
Add IP blocking against DNSBL at sign-up
2016-01-20 15:28:19 +01:00
Douwe Maan
a010db5db2
Properly handle HTML entities with inline diffs
2016-01-20 15:26:44 +01:00
Douwe Maan
c23ca0b0b5
Merge branch 'master' into issue_3945
2016-01-20 14:53:41 +01:00
Douwe Maan
701513dcc7
Move parallel diff logic to separate class
2016-01-20 14:53:20 +01:00
Robert Speicher
1f9c360d7b
Merge branch 'add_email_headers' into 'master'
...
Added X-GitLab-... headers to emails from CI and Email On Push services
Fixes #2098
This adds the 'X-GitLab-Project', 'X-GitLab-Project-Id' and
'X-GitLab-Project-Path' headers to emails from CI and Email On Push in a way
that it is done currently for merge requests and issues emails.
Additionally, CI emails will have 'X-GitLab-Build-Status' header with either
'fail' or 'success'.
Emails from Email On Push will include 'X-Gitlab-Author' header containing the
username of user who did the push.
See merge request !2159
2016-01-19 21:23:54 +00:00
Anton Baklanov
84124380e8
Added X-GitLab-... headers to emails from CI and Email On Push services
...
Fixes #2098
2016-01-19 20:18:39 +02:00
Douwe Maan
98e1a5b634
Allow LDAP users to change their email if it was not set by the LDAP server
2016-01-19 16:25:38 +01:00
Douwe Maan
5c7259c7c3
Don't crash when file can't be highlighted
2016-01-19 15:13:37 +01:00
Douwe Maan
512bebe21d
Refactor Gitlab::Highlight and fix tests
2016-01-19 14:52:41 +01:00
Douwe Maan
0a8039eb77
Remove useless assignments
2016-01-19 13:56:36 +01:00
Douglas Barbosa Alexandre
bddef293d6
Ensure that doesn't have pending migrations when running the specs
2016-01-19 00:12:30 -02:00
Douwe Maan
12546f895f
Add tests
2016-01-15 16:29:26 +01:00
Douwe Maan
5de8971ddf
Whoops, forgot to add files
2016-01-15 16:02:48 +01:00
Steffen Köhler
2444c04055
Fix signup for some OAuth providers
...
some OAuth providers (kerberos for example) only provide a username and an email, but no name. Therefore
a signup fails because the name is empty. Best guess for the name is
probably the username, therefore use it as name.
2016-01-15 14:55:52 +01:00
Douwe Maan
13f10efcf1
Move inline diff marker logic to its own class
2016-01-15 14:39:43 +01:00
Douwe Maan
7d31f37219
Move inline diff logic to its own class
2016-01-15 14:25:29 +01:00
Douwe Maan
71b4341a37
Method was moved
2016-01-15 14:11:36 +01:00
Rubén Dávila
c8db25c37c
Merge branch 'master' into issue_3945
2016-01-14 17:28:44 -05:00
Rubén Dávila
6b9c730e91
More refactoring from last code review. #3945
...
* Use commit objects instead of IDs when generating diffs
* Use proper references when generating MR's source and target
* Update broken specs
2016-01-14 16:47:55 -05:00