Dmitriy Zaporozhets
d0d82c0cfe
Merge branch 'ce-to-ee' into 'master'
...
CE to EE
See merge request !340
2015-03-04 06:01:12 +00:00
Dmitriy Zaporozhets
d997890270
Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhq into ce-to-ee
2015-03-03 21:30:52 -08:00
Dmitriy Zaporozhets
063e9f9a0f
Merge branch 'ldap_admin_group' into 'master'
...
Be sure that admin_group exists before trying to check for user membership.
Related to #257
See merge request !334
2015-03-04 04:35:12 +00:00
Marin Jankovski
06590b9195
Be sure that admin_group exists before trying to check for user membership.
2015-03-03 18:41:57 -08:00
Marin Jankovski
3d6d0e1e77
Merge branch 'fix-namespace-merge-request-url' into 'master'
...
Fix namespace in merge request url building
Changes in 42387b733b now require namespace specification and broke abc69c8905 .
There are additional helper functions in c530ca00b0 , but this seemed easier not to rely on them.
See merge request !363
2015-03-04 01:08:52 +00:00
Stan Hu
2088cee935
Fix URL builder to use GitlabRoutingHelper
2015-03-03 15:57:28 -08:00
Dmitriy Zaporozhets
811505c7ce
Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhq into ce-to-ee
...
Conflicts:
app/controllers/projects/team_members_controller.rb
app/views/groups/members.html.haml
2015-03-03 13:33:40 -08:00
Dmitriy Zaporozhets
8c47a72a4e
Merge branch 'project-existence-leak' into 'master'
...
Don't leak information about private project existence via Git-over-SSH/HTTP.
Fixes #2040 and https://gitlab.com/gitlab-org/gitlab-ce/issues/343 .
Both `Grack::Auth` (used by Git-over-HTTP) and `Api::Internal /allowed` (used by gitlab-shell/Git-over-SSH) now return a generic "Not Found" error when the project exists but the user doesn't have access to it.
See merge request !1578
2015-03-03 20:05:12 +00:00
Marin Jankovski
a7fad44bd3
Merge branch 'go-import' into 'master'
...
Render go-import meta tag for private repos.
The previously solution (626f5bab35 ) required a change to nginx config and broke visits from Googlebot and other clients including "go" in their user agent.
See merge request !1587
2015-03-03 19:53:20 +00:00
Douwe Maan
54b0c78745
Ignore case of LDAP user DN when checking group membership.
2015-03-03 17:35:19 +01:00
Jeroen van Baarsen
abc69c8905
Merge branch 'fix-merge-request-url-builder' into 'master'
...
Fix merge request URL passed to Webhooks
If you look at the data structure passed to Webhooks, you will see:
`"url"=>nil`
I don't think any of the Webhooks or services are using this yet, so right now nothing so far depends upon this value being correct.
See merge request !352
2015-03-03 13:18:23 +00:00
Douwe Maan
d513ca584a
Revert "Merge branch 'go-get-workaround-nginx' of https://github.com/mattes/gitlabhq into mattes-go-get-workaround-nginx"
...
This reverts commit 51349ca3c8 , reversing
changes made to b180476bd6 .
2015-03-03 11:21:48 +01:00
Dmitriy Zaporozhets
ee3714d5dc
Merge branch 'ce-to-ee' into 'master'
...
CE to EE
See merge request !333
2015-03-03 07:13:56 +00:00
Dmitriy Zaporozhets
2f4656b5c7
Merge branch 'strict-rubocop-rules' into 'master'
...
Enable ParenthesesAsGroupedExpression rule
See merge request !1617
2015-03-03 05:58:14 +00:00
Dmitriy Zaporozhets
8348e1a9b5
Enable ParenthesesAsGroupedExpression rule
2015-03-02 18:45:28 -08:00
Dmitriy Zaporozhets
be165b18d0
Add brakeman and jasmine
2015-03-02 18:22:37 -08:00
Dmitriy Zaporozhets
16e899ca8b
Add brakeman rake task and improve code security
2015-03-02 18:11:50 -08:00
Dmitriy Zaporozhets
cc877c53ab
Add rake task for brakeman
2015-03-02 17:41:05 -08:00
Dmitriy Zaporozhets
8dcffdcdc1
Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhq into ce-to-ee
...
Conflicts:
app/helpers/oauth_helper.rb
app/helpers/projects_helper.rb
app/models/service.rb
app/views/devise/shared/_signin_box.html.haml
config/gitlab.yml.example
db/schema.rb
doc/integration/github.md
features/project/service.feature
lib/gitlab/github_import/client.rb
2015-03-02 16:10:12 -08:00
Dmitriy Zaporozhets
63148e7763
Merge branch 'ldap-ssh-key-prefix' into 'master'
...
Ignore LDAP SSH key prefix and invalid keys.
See #214 and #230 .
cc @job
See merge request !327
2015-03-02 23:35:58 +00:00
Douwe Maan
dd37a10df4
Don't leak information about private project existence via Git-over-SSH/HTTP.
2015-03-02 17:52:48 +01:00
Nicolas Bouilleaud
8d0690c5c7
Support names starting with a digit or _ for projects and users
...
This is what’s actually allowed when creating a user or a project in gitlab.
2015-03-02 11:01:17 +01:00
Jeroen van Baarsen
93bacb03e5
Merge pull request #8890 from sue445/feature/project_api_avatar_url
...
Expose avatar_url in projects API
2015-03-01 10:54:42 +01:00
sue445
51abeaa1bc
Expose avatar_url in projects API
...
* Impl Project#avatar_url
* Refactor ApplicationHelper: Use Project#avatar_url
* Update changelog
2015-03-01 10:13:01 +09:00
Dmitriy Zaporozhets
0d22b75b03
Merge branch 'master' into mmonaco/gitlab-ce-api-user-noconfirm
...
Conflicts:
lib/api/users.rb
2015-02-27 13:01:57 -08:00
Dmitriy Zaporozhets
a52529f9b6
Merge branch 'bitbucket-import'
...
Conflicts:
app/views/import/gitorious/status.html.haml
db/schema.rb
2015-02-25 09:21:45 -08:00
Douwe Maan
4a8a2f8021
Ignore LDAP SSH key prefix and invalid keys.
2015-02-25 17:08:29 +01:00
Douwe Maan
3fde1dce1f
Satisfy Rubocop.
2015-02-24 15:07:25 +01:00
Douwe Maan
6979b3afd5
Delete deploy key from Bitbucket after importing.
2015-02-24 15:07:24 +01:00
Douwe Maan
f2b37de54b
Fix specs.
2015-02-24 15:07:24 +01:00
Douwe Maan
448817c4de
Load public key in initializer.
2015-02-24 15:07:24 +01:00
Douwe Maan
ad6d623234
Add Bitbucket importer.
2015-02-24 15:07:24 +01:00
Valery Sizov
71a844cdae
Web Editor: save to new branch
2015-02-24 11:43:20 +02:00
Dmitriy Zaporozhets
976e18bb33
Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhq into 7-9-pre
...
Conflicts:
app/views/groups/show.html.haml
app/views/projects/team_members/index.html.haml
config/routes.rb
2015-02-23 23:56:59 -08:00
Stan Hu
e363f2e675
Fix merge request URL passed to Webhooks.
...
Previously the symbol "url" in the object_attributes hash would always be nil.
2015-02-24 06:51:24 +00:00
Dmitriy Zaporozhets
c87c1cb3b9
Merge branch 'api-empty-commit' into 'master'
...
Improve error messages when file editing fails
Give more specific errors in API responses and web UI flash messages when a file update fails. See #1479 .
Instead of returning false from `Gitlab::Satellite::Files::EditFileAction#commit!` when a `Grit::Git::CommandFailed` error is raised, now `#commit!` raises a different error depending on whether the failure happened during checkout, commit, or push.
@dzaporozhets Please let me know if you want to change the HTTP status codes or the error messages in `Files::UpdateService`
cc @sytse
See merge request !1569
2015-02-24 02:17:23 +00:00
Dmitriy Zaporozhets
d723bf78b8
Fix git-over-http
2015-02-23 10:05:18 -08:00
Vinnie Okada
5f232b5687
Improve error messages when file editing fails
...
Give more specific errors in API responses and web UI flash messages
when a file update fails.
2015-02-22 16:01:49 -07:00
Vinnie Okada
2a9eed6620
Merge branch 'master' into rails-4.1.9
...
Conflicts:
app/views/projects/commits/_commit.html.haml
app/views/projects/issues/_issue.html.haml
app/views/projects/issues/_issue_context.html.haml
app/views/projects/merge_requests/_merge_request.html.haml
app/views/projects/merge_requests/show/_context.html.haml
2015-02-21 12:55:28 -07:00
Dmitriy Zaporozhets
a224a655d8
Merge branch 'mr-commit-comment-diff-lines' into 'master'
...
Fix commit comments on first line of diff not rendering in Merge Request Discussion view.
Example can be seen near the bottom on this MR: !1533 .
Before:

After: the [note](https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/1533/diffs#note_36449 ) is actually rendered.
See merge request !1552
2015-02-21 02:06:39 +00:00
Dmitriy Zaporozhets
b2fb6e0e0c
Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhq
...
Conflicts:
app/services/merge_requests/build_service.rb
app/views/layouts/_head.html.haml
2015-02-20 16:02:25 -08:00
Marin Jankovski
51349ca3c8
Merge branch 'go-get-workaround-nginx' of https://github.com/mattes/gitlabhq into mattes-go-get-workaround-nginx
...
Conflicts:
lib/support/nginx/gitlab
lib/support/nginx/gitlab-ssl
2015-02-20 15:47:34 -08:00
Marin Jankovski
8ae3112b3f
Merge branch 'upload-xss-access-control' into 'master'
...
Fix note attachments XSS and access control
Replaces the reverted #1528 , as proposed in https://gitlab.com/gitlab-org/omnibus-gitlab/issues/434 , as discussed with @dzaporozhets and as summarized in #2032 .
@marin Could you take a look at the nginx config and apply it to Omnibus once this gets merged?
See merge request !1553
2015-02-20 22:47:54 +00:00
Douwe Maan
26d57a648c
Restore nginx config a little more.
2015-02-20 23:32:39 +01:00
Douwe Maan
08874d2b51
Make changes to nginx config less likely to break something.
2015-02-20 23:27:17 +01:00
Dmitriy Zaporozhets
acc312fc25
Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce
2015-02-20 13:54:21 -08:00
Dmitriy Zaporozhets
92434b29cc
Extend project web hooks with more data
...
* add git_http_url and git_ssh_url to project web hook
* add visibility_level to project web hook
* add documentation about project visibility_level in API
2015-02-20 10:27:37 -08:00
Marcin Kulik
157b4b4b1f
Add gitorious.org importer
2015-02-20 17:42:58 +00:00
Douwe Maan
938a1381fc
Satisfy Rubocop.
2015-02-20 16:04:03 +01:00
Douwe Maan
4310431ee7
Use modified ActionDispatch::Static to let uploads go through to routes.
2015-02-20 12:44:07 +01:00