Update activity SVG path
## What does this MR do?
Fixes SVG path so the activity icon is the correct color
## Screenshots (if relevant)
<img src="/uploads/ea948338ea816890851a8011b8b3255f/Screen_Shot_2016-06-09_at_8.43.05_AM.png" width="600px">
See merge request !4563
Made the awardable buttons prettier when active
## What does this MR do?
Made the active and hover state of the award emoji buttons prettier.
## Why was this MR needed?
'cause @JobV wanted them to look nicer 😉
## What are the relevant issue numbers?
Closes#18379
## Screenshots (if relevant)
See merge request !4554
Correctly shows label errors in dropdown
## What does this MR do?
Correctly shows any errors in the dropdown when creating a new label
## What are the relevant issue numbers?
Closes#18344
## Screenshots (if relevant)
See merge request !4553
Revert change to search all users
## What does this MR do?
Reverts a change that allowed the user to search for all users in the author/assignee dropdown
## Are there points in the code the reviewer needs to double check?
Double check it isn't still searching all users
See merge request !4564
Fixed project dropdown being overlapped by sidebar
## What does this MR do?
Changes the header expanded `padding` to `margin` to prevent the project dropdown from overlapping.
## What are the relevant issue numbers?
Closes#18410
## Screenshots (if relevant)
See merge request !4583
Fixed issue where label filtering didnt work
## What does this MR do?
The filterable option was missing which meant labels in the dropdown couldn't be filtered. This fixes that.
## What are the relevant issue numbers?
Closes#18375
See merge request !4556
Fix UTF-8 handling in incremental trace update API
## What does this MR do?
This MR fixes invalid UTF-8 handling in incremental trace update API (used by GitLab Runner).
## Why was this MR needed?
Current version is using `.length` method to determine current trace size where Runner is using the trace size in bytes. Also this byte size is used in headers and file operations to agree the trace part to send. This is a problem when build trace contains any multi-byte UTF-8 characters. This MR is fixing this situation so all parts are using the same size in bytes.
### Runner -> API communication before fix:
```
Checking for builds... received runner=_token_
gitlab-ci-multi-runner 1.3.0~beta.26.gcfd63b9 (cfd63b9) build=25 runner=_token_
Using Docker executor with image debian:jessie ... build=25 runner=_token_
Pulling docker image debian:jessie ... build=25 runner=_token_
25 Submitting build to coordinator... ok runner=_token_
25 Appending trace to coordinator... ok RemoteRange=0-158 RemoteState=running ResponseMessage=202 Accepted ResponseStatusCode=202 SentRange=0-158 runner=_token_
25 Appending trace to coordinator... ok RemoteRange=0-491 RemoteState=running ResponseMessage=202 Accepted ResponseStatusCode=202 SentRange=158-505 runner=_token_
WARNING: 25 Appending trace to coordinator... range missmatch RemoteRange=0-491 RemoteState= ResponseMessage=416 Requested Range Not Satisfiable ResponseStatusCode=416 SentRange=505-584 runner=_token_
WARNING: 25 Resending trace patch due to range missmatch runner=_token_
25 Appending trace to coordinator... ok RemoteRange=0-556 RemoteState=running ResponseMessage=202 Accepted ResponseStatusCode=202 SentRange=491-584 runner=_token_
WARNING: 25 Appending trace to coordinator... range missmatch RemoteRange=0-556 RemoteState= ResponseMessage=416 Requested Range Not Satisfiable ResponseStatusCode=416 SentRange=584-663 runner=_token_
WARNING: 25 Resending trace patch due to range missmatch runner=_token_
25 Appending trace to coordinator... ok RemoteRange=0-621 RemoteState=running ResponseMessage=202 Accepted ResponseStatusCode=202 SentRange=556-663 runner=_token_
Build succeeded build=25 runner=_token_
WARNING: 25 Appending trace to coordinator... range missmatch RemoteRange=0-621 RemoteState= ResponseMessage=416 Requested Range Not Satisfiable ResponseStatusCode=416 SentRange=663-797 runner=_token_
WARNING: 25 Resending trace patch due to range missmatch runner=_token_
25 Appending trace to coordinator... ok RemoteRange=0-741 RemoteState=running ResponseMessage=202 Accepted ResponseStatusCode=202 SentRange=621-797 runner=_token_
25 Submitting build to coordinator... ok runner=_token_
```
### Runner -> API communication after fix:
```
Checking for builds... received runner=_token_
gitlab-ci-multi-runner 1.3.0~beta.26.gcfd63b9 (cfd63b9) build=26 runner=_token_
Using Docker executor with image debian:jessie ... build=26 runner=_token_
Pulling docker image debian:jessie ... build=26 runner=_token_
26 Submitting build to coordinator... ok runner=_token_
26 Appending trace to coordinator... ok RemoteRange=0-158 RemoteState=running ResponseMessage=202 Accepted ResponseStatusCode=202 SentRange=0-158 runner=_token_
26 Appending trace to coordinator... ok RemoteRange=0-505 RemoteState=running ResponseMessage=202 Accepted ResponseStatusCode=202 SentRange=158-505 runner=_token_
26 Appending trace to coordinator... ok RemoteRange=0-584 RemoteState=running ResponseMessage=202 Accepted ResponseStatusCode=202 SentRange=505-584 runner=_token_
26 Appending trace to coordinator... ok RemoteRange=0-663 RemoteState=running ResponseMessage=202 Accepted ResponseStatusCode=202 SentRange=584-663 runner=_token_
Build succeeded build=26 runner=_token_
26 Submitting build to coordinator... ok runner=_token_
```
See merge request !4541
Add milestone expire date to the right sidebar
## What does this MR do?
Shows milestone expire date tooltip in the sidebar. It also shows the tooltip when sidebar is collapsed.
## Are there points in the code the reviewer needs to double check?
`common_utils.js.coffee` and `milestones_helper.rb` should be reviewed deeply.
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/17355
## Screencast
See merge request !4448
Improve ui consistency. Part 2
* Use responsive top-area on project branches and tags pages
* Use default button size in the content list controls
* Improve button margin for btn-grouped css class
For https://gitlab.com/gitlab-org/gitlab-ce/issues/18324
See merge request !4536
Improved the UX of issue & milestone date picker
## What does this MR do?
Improves the UX of the date picker on issue form & milestone form.
## What are the relevant issue numbers?
Closes#18198
## Screenshots (if relevant)
### Issues
### Project milestones
### Group milestones
See merge request !4485
Only load Chart.js when necessary.
Only load Chart.js where it's used, namely the Graphs section. Follow up on !4394.
cc: @jschatz1
See merge request !4516
Fix local timeago on user dashboard
## What does this MR do?
Fixes incorrect date times on tooltips on the dashboard page
## Are there points in the code the reviewer needs to double check?
Yes, The tooltip has to be recreated again because we needed a custom CSS classname in order to fix the date being splitted into two lines.
## Why was this MR needed?
Because the datetimes were incorrect we have to have the same format for .timeago() instances.
## What are the relevant issue numbers?
#17607
## Screenshots (if relevant)
**Before**
<img src="/uploads/f40cd58e8086d9675262e98a1fe57885/Screen_Shot_2016-05-24_at_7.23.25_PM.png" width="705">
**After**
<img src="/uploads/bd48046ef11659cc742f827b3404fbcd/Screen_Shot_2016-05-24_at_7.22.29_PM.png" width="704">
See merge request !4285
Improve input padding, fix#18237.
## What does this MR do?
Improves horizontal padding for input fields.
## What are the relevant issue numbers?
#18237
## Screenshots (if relevant)
Before:
After:
cc: @jschatz1
See merge request !4489
Use warning color merge conflicts icon in MR status widget.
Fixes#18174
### Before
### After
See merge request !4487
Edit form background color on highlighted note
## What does this MR do?
Added white background to edit form when in a highlighted note
## What are the relevant issue numbers?
Closes#18101
## Screenshots (if relevant)
See merge request !4435
Toggling a task in a description with mentions doesn't creates a Todo
When user toggle a task list item in a description with a mention it
does not create an unnecessary Todo for that mention.
Closes#14116
See merge request !4568
Blur button tags when pressed to remove the focus state.
## Before
## After
See merge request !4418
Updated labels UI
- Fixed alignment issues
- Added dropdown to mobile to make the options look nicer & to save space
Closes#14227
See merge request !4273
#17562 Fixes issues list filter only visible when user is logged in
## What does this MR do?
1. Moves the issue/MR list search form out of the `if current_user` conditional, allowing guests to view the field.
2. Adds some margin to the search form, this is because in mobile view for guest users, the field was not supported by the RSS button and the New Issue button and would drop to meet the list.
## Are there points in the code the reviewer needs to double check?
Are there any views where the `margin-bottom: 12px` will affect the styling?
## Why was this MR needed?
Guest user UX. Nothing feels better than increasing intangible value!
## What are the relevant issue numbers?
Fixes#17562.
## Screenshots (if relevant)
/cc @jschatz1
**UPDATE:**
See merge request !4171
Fix 2FA-based login for LDAP users
The OTP input form is shared by both LDAP and standard logins, but when
coming from an LDAP-based form, the form parameters aren't nested in a
Hash based on the `resource_name` value.
Now we check for a nested `remember_me` parameter and use that if it
exists, or fall back to the non-nested parameters if it doesn't.
Somewhat confusingly, the OTP input form _does_ nest parameters under
the `resource_name`, regardless of what type of login we're coming from,
so that allows everything else to work as normal.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/18185
See merge request !4493
Jacob Schatz
Rémy Coutable
Paco GuzmanandYorick Peterse
Rui AndersonandRémy Coutable
Kamil Trzcinski
Tomasz Maczukin
Phil Hughes
Fatih Acet
Annabel Dunstone
Robert Speicher
Alfredo Sumaran
Douglas Barbosa Alexandre