Commit Graph
22224 Commits
Author SHA1 Message Date
Dmitriy Zaporozhets 40104746d6 Merge remote-tracking branch 'origin/feature/update-rubocop' 2015-12-16 13:44:50 +01:00
Andrey 37a4e4945d Merge branch 'fix-profile-nav' into 'master'
Make profile navigation full wide

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

## Before


![Administrator___GitLab](/uploads/a43e8992264ed78afa732e7a911ef154/Administrator___GitLab.png)

## After

![Administrator___GitLab1](/uploads/9e67e8af071d4879045311abe15a7bba/Administrator___GitLab1.png)

See merge request !2076
2015-12-16 10:57:02 +00:00
Jason Lee 03a40a7ee1 Avoid allocations in Ability class.
It won't change anything after they are first invoke, so add method cache to avoid allocations and avoid GC.

Benchmarks:

```
Calculating -------------------------------------
project_guest_rules without method cache
                        79.352k i/100ms
project_guest_rules with method cache
                        93.634k i/100ms
-------------------------------------------------
project_guest_rules without method cache
                          2.865M (±32.5%) i/s -     11.982M
project_guest_rules with method cache
                          4.419M (± 7.4%) i/s -     22.004M

Comparison:
project_guest_rules with method cache:  4418908.0 i/s
project_guest_rules without method cache:  2864514.0 i/s - 1.54x slower

Calculating -------------------------------------
project_report_rules without method cache
                        53.126k i/100ms
project_report_rules with method cache
                        97.473k i/100ms
-------------------------------------------------
project_report_rules without method cache
                          1.093M (±36.5%) i/s -      4.675M
project_report_rules with method cache
                          4.420M (± 7.2%) i/s -     22.029M
Comparison:
project_report_rules with method cache:  4420054.3 i/s
project_report_rules without method cache:  1092509.6 i/s - 4.05x slower
```

https://gist.github.com/huacnlee/b04788ae6df42fe769e4
2015-12-16 11:51:37 +08:00
Drew Blessing f98f353436 [ci skip] Add SVN to Git migration documentation 2015-12-15 16:29:07 -06:00
Jeff Stubler 2e8ec7e720 Fix diverging commit count calculation
Rugged seemed to stop accepting branch names as valid refs, throwing `Rugged::ReferenceError` exceptions. Now the branch target rather than branch name is used, and the default branch's hash is also calculated, and these work properly.

This used to work and might be something worth re-investigating in the future.
2015-12-15 16:23:52 -06:00
Robert Speicher f49ac5c8d3 Fix clipboard buttons on MR instructions and Commit#show 2015-12-15 16:11:01 -05:00
Robert Speicher a5a9cd304c Update CHANGELOG
[ci skip]
2015-12-15 15:55:28 -05:00
Robert Speicher 5ffed49fef Merge branch 'lazy-reference-extractor' into 'master'
Move Markdown/reference logic from `Gitlab::Markdown` to `Banzai`

- Moves from `Gitlab::Markdown` to `Banzai`
- Moves filters and pipelines into their own namespace: `Banzai::Filter` and `Banzai::Pipeline`
- No more `autoload`!
- Split up `Gitlab::ReferenceExtractor` into `Banzai::ReferenceExtractor` and `Gitlab::ReferenceExtractor`
- Replace `something(load_lazy_references: true)` by `Gitlab::ReferenceExtractor.lazily { something }`

Goes from:

```ruby
def referenced_merge_requests
  references = [self, *notes].flat_map do |note|
    note.all_references(load_lazy_references: false).merge_requests
  end.uniq!

  Gitlab::Markdown::ReferenceFilter::LazyReference.load(references).uniq.sort_by(&:iid)
end
```

to

```ruby
def referenced_merge_requests
  Gitlab::ReferenceExtractor.lazily do
    [self, *notes].flat_map do |note|
      note.all_references.merge_requests
    end
  end.sort_by(&:iid)
end
```

See merge request !2027
2015-12-15 20:52:04 +00:00
Drew Blessing 577448ab6a Allow admin to create new user identities 2015-12-15 13:54:35 -06:00
Gabriel Mazetto 9072098215 Fixed CiServices validation 2015-12-15 17:37:23 -02:00
Robert Speicher 28a8d0b5db Merge branch 'add_user_repo_integrity_rake_task' into 'master'
Add user repository integrity check rake task

Corrupt repositories and stuck lock files can cause weird issues in
GitLab. Often we know which user is having these problems and then we
have to go hunt down which repository is causing it. Several times
recently that involved me running queries in the rails console to get
an array of projects and then writing a quick Ruby script to loop
through and run `git fsck`. This last time I also had to check for the
existence of `config.lock` and ref lock files. 

This rake task will eliminate all of those steps and allow an admin to
simply specify a username.

I also added the lock file checks to the existing `gitlab:repo:check`
task which goes through all projects. 

See merge request !2080
2015-12-15 18:36:28 +00:00
Andrey 96a1558897 Merge branch 'wider-layout' into 'master'
Increase fixed layout width to 1280px

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

cc @creamzy 

See merge request !2075
2015-12-15 18:19:55 +00:00
Dmitriy Zaporozhets ee258322f5 Merge branch 'fix-panel-height' into 'master'
Fix inline panel heading height

The `line-height` was added so that headings in the panels on the settings page had the same height as headings elsewhere, but the style applied everywhere :)

Before:

(Look at the "Unstarted Issues" heading)

![Screen_Shot_2015-12-15_at_17.39.46](/uploads/9dbea4c8b28e3c43bb5d4b5226d7a1ec/Screen_Shot_2015-12-15_at_17.39.46.png)

![Screen_Shot_2015-12-15_at_17.40.19](/uploads/97898418e9a66954c02e8a68b21c08b9/Screen_Shot_2015-12-15_at_17.40.19.png)

After:

![Screen_Shot_2015-12-15_at_17.40.45](/uploads/5748aba032889053dd778b39e96fa301/Screen_Shot_2015-12-15_at_17.40.45.png)

![Screen_Shot_2015-12-15_at_17.40.40](/uploads/20240cdc7a6d5665cd32556d1a0e6c1d/Screen_Shot_2015-12-15_at_17.40.40.png)

cc @skyruler 

cc @rspeicher 8.3 please!

See merge request !2106
2015-12-15 17:53:34 +00:00
Robert Speicher f2db1410f5 Update workhorse version in doc/install/installation.md 2015-12-15 12:21:53 -05:00
Douwe Maan 9dfe43c83b Move milestone edit button to the very right 2015-12-15 17:36:08 +01:00
Douwe Maan c1db8d1590 Use regularly colored button for "Subscribe"/"Unsubscribe" 2015-12-15 17:33:03 +01:00
Douwe Maan e4e1777aa5 Fix "Notifications" label color 2015-12-15 17:32:46 +01:00
Douwe Maan 297398ea32 Move cross-project reference down 2015-12-15 17:32:37 +01:00
Douwe Maan f31dfae28a Fix inline panel heading height 2015-12-15 17:31:07 +01:00
Douwe Maan 5413960b1a Fix headers of milestone and snippet show pages 2015-12-15 17:29:37 +01:00
Trey Davis 75ad9fff4e Show git version on admin page 2015-12-15 08:02:19 -08:00
Douwe Maan 6560d053ed Use lazy reference extractor to get issue's MRs 2015-12-15 16:57:11 +01:00
Job van der Voort ddd806c66f Revert "Make sure notify email always has author info."
This reverts commit 303f79f804.
2015-12-15 16:45:52 +01:00
Jacob Vosmaer 2c130aa087 Gitlab-workhorse related 8.3 update changes 2015-12-15 16:38:11 +01:00
Jacob Vosmaer d27befe64d Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into workhorse-passthrough 2015-12-15 16:24:14 +01:00
Jacob Vosmaer 447e598ec4 Update init script options for gitlab-workhorse 2015-12-15 16:24:04 +01:00
Douwe Maan 48b3ad6d37 Banzai::XFilter -> Banzai::Filter::XFilter 2015-12-15 16:10:32 +01:00
Douwe Maan 7781bda9bd Move Markdown/reference logic from Gitlab::Markdown to Banzai 2015-12-15 15:51:16 +01:00
Grzegorz Bizon 4493d3fd55 Merge branch 'tests/note-polling' into 'master'
Add feature specs for note polling

Ref. #4032, !2084

cc @rspeicher 

See merge request !2086
2015-12-15 14:02:28 +00:00
Jacob Vosmaer 3581927f59 Require gitlab-workhorse 0.5.0 2015-12-15 14:30:00 +01:00
Grzegorz BizonandGrzegorz Bizon 8fe821cfa5 Trigger notes refresh in specs instead of waiting for ajax 2015-12-15 14:19:35 +01:00
Grzegorz BizonandGrzegorz Bizon 6fb120d1b0 Assign notes object to a variable 2015-12-15 14:19:35 +01:00
Grzegorz BizonandGrzegorz Bizon 3e789eab8b Add minor fixes in note polling specs 2015-12-15 14:19:35 +01:00
Grzegorz BizonandGrzegorz Bizon 9470d05c70 Add spinach test for note polling
This also increases capybara timeout to 15 seconds (note polling
interval). Capybara will look for new note for this period of time.
2015-12-15 14:19:35 +01:00
Grzegorz BizonandGrzegorz Bizon 7c14541d2b Add feature specs for note polling
Ref. #4032, !2084
2015-12-15 14:19:35 +01:00
Douwe Maan 9451db3819 Merge branch 'rs-issue-4032' into 'master'
Fix note polling

Closes #4032

See merge request !2084
2015-12-15 13:18:13 +00:00
tduehr 8e3f1fa629 add CAS authentication support 2015-12-14 21:43:41 -06:00
Gabriel Mazetto f479ed3066 Disabled Rails/Date cop 2015-12-15 00:54:26 -02:00
Gabriel Mazetto b5291f9599 Fixed Rubocop offenses 2015-12-15 00:53:52 -02:00
Robert Speicher 2b4a3bc524 Merge branch 'preserve-trailing-new-lines-at-eof' into 'master'
Preserve trailing new lines at the end of file on the online editor

Fixes #3784

Because Haml automatically indents the HTML source code, the contents
of whitespace-sensitive tags like pre and textarea can get screwed up.

See merge request !2099
2015-12-14 23:29:50 +00:00
Achilleas Pipinellis f28c2de41f Merge branch 'contributing_md' into 'master'
Clean up CONTRIBUTING.md

* Use 80 chars width where possible
* Remove easyfix label reference
* Add new issue submission template
* Add long links to the bottom of the page

See merge request !2100
2015-12-14 23:24:07 +00:00
Achilleas Pipinellis 1c7128f34c Fix links [ci skip] 2015-12-15 00:44:02 +02:00
Gabriel Mazetto d1f1c5c60b Updated .rubocop.yml to match 0.35.x changes 2015-12-14 20:27:43 -02:00
Achilleas Pipinellis 2e54428171 Clean up CONTRIBUTING.md [ci skip]
* Use 80 chars width where possible
* Remove easyfix label reference
* Add new issue submission template
* Add long links to the bottom of the page
2015-12-15 00:17:25 +02:00
Drew Blessing be41d84fb0 Allow account unlock via email 2015-12-14 15:35:02 -06:00
Drew Blessing f8bf6c4b2c [ci skip] Add user repository integrity check rake task 2015-12-14 15:27:14 -06:00
Douglas Barbosa Alexandre 5afe03315d Preserve trailing new lines at the end of file on the online editor
Because Haml automatically indents the HTML source code, the contents
of whitespace-sensitive tags like pre and textarea can get screwed up.
2015-12-14 18:22:28 -02:00
Achilleas Pipinellis e7d7cd67bb Clarify what CE and EE means for newcomers 2015-12-14 22:07:53 +02:00
Achilleas Pipinellis b95f7b1864 Merge branch 'feature-proposal' into 'master'
update guides for feature proposals on the issue tracker

see also #4038 

cc @sytses 

See merge request !2094
2015-12-14 20:00:57 +00:00
Robert Schilling f7af7c993b Merge branch 'fix-typo-mailing-list' into 'master'
Fix Typo [mailinglist to mailing list]

Closes: #4078 

See merge request !2098
2015-12-14 19:49:51 +00:00