write_ was renamed to create_
modify_ was renamed to update_
So now in update action we have next code
def create
can?(current_user, :create_issue, @issue)
end
def update
can?(current_user, :update_issue, @issue)
end
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Performance improvements
* store @participants in variable
* store result of subscribed? call into variable
In total it reduce amount of SQL queries for issue or merge_request with 10 comments/participants almost twice.
See merge request !883
stop jumping all content on collapsing and expanding the sidebar
When you collapse or expand the sidebar, all content shifts with 5px.
This merge request solves that.
cc @darby
See merge request !1877
* store @participants in variable
* store result of subscribed? call into variable
In total it reduce amount of SQL queries for merge_request with 10
comments/participants twice.
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* store @participants in variable
* store result of subscribed? call into variable
In total it reduce amount of SQL queries for issue with 10 comments/participants twice.
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Only look up Commit authors/committers by email
- Removes looking up authors/committers by name
- Renames `User.find_for_commit` to `User.find_by_any_email`
Closes#1850
See merge request !878
Updated the categories of Application Settings Form
Changed the categories and order of the application settings accessible by admin/application_settings
Link to issue: https://dev.gitlab.org/gitlab/gitlabhq/issues/2412
Issue will be closed upon approval of this merge request.
Fixes#2412
See merge request !877
Fix error when deleting a user who has projects
### What does this MR do?
This MR fixes an error that prevented users from being deleted in the Admin page if the user had personal projects.
### Why was this MR needed?
Deleting a user who had projects would result in an error such as this:
```
Started DELETE "/admin/users/tdb1" for MYIP at 2015-06-22 20:53:02 +0100
Processing by Admin::UsersController#destroy as HTML
Parameters: {"authenticity_token"=>"[FILTERED]", "id"=>"tdb1"}
Completed 500 Internal Server Error in 30ms (ActiveRecord: 6.7ms)
NameError (undefined local variable or method `current_user' for #<DeleteUserService:0x0000000cd01d38>):
app/services/delete_user_service.rb:10:in `block in execute'
app/services/delete_user_service.rb:7:in `execute'
app/controllers/admin/users_controller.rb:89:in `destroy'
```
### What are the relevant issue numbers?
* Closes#1856
* Closes https://github.com/gitlabhq/gitlabhq/issues/9394
See merge request !868
Animation of Sidebar (video in here)
Edited the CSS of header and sidebar; added a new div of gitlab-logo-container to the html to make things easier.
The transition-duration is set to 0.3s and when the nav bar expands, it opens up over the text, essentially revealing hidden text.
[animation-sidebar-2.mov](https://gitlab.com/gitlab-org/gitlab-ce/uploads/b15996a256d6bed03a19c68549d116e4/animation-sidebar-2.mov)
/cc @JobV @nicolas2
See merge request !849
Dmitriy Zaporozhets
Douwe Maan
Job van der Voort
Robert Speicher
Darby
Adam Meily
Dmitriy Zaporozhets
Valery Sizov
Stan Hu
Rowan Wookey
