Jan-Willem van der Meer
e151bbbb28
Extract LDAP config to seperate class
2014-10-07 12:22:16 +02:00
Jan-Willem van der Meer
e23a26aea0
Add provider context to Ldap::Access
2014-10-03 17:27:35 +02:00
Jan-Willem van der Meer
0e276f9cbf
Move allowed call to LDAP::User
2014-10-03 17:27:14 +02:00
Jan-Willem van der Meer
ce22ffbc7f
Reuse the ldap adapter
2014-10-03 17:21:38 +02:00
Jan-Willem van der Meer
e08c14c0f0
Use provider based ldap config
2014-10-03 17:18:25 +02:00
Jan-Willem van der Meer
63132b7513
Enable provider based LDAP adapter
2014-10-03 17:16:12 +02:00
Jan-Willem van der Meer
a6422e271e
Add TODO for further refactoring
2014-10-03 14:01:06 +02:00
Jan-Willem van der Meer
ad1c2f79d9
Refactor Gitlab::LDAP::User to instance methods
2014-10-01 14:11:50 +02:00
Jacob Vosmaer
e93523ed31
Merge commit '79190fe06b' into merge-79190fe06b-7.3.0-pre
...
Conflicts:
Gemfile
README.md
VERSION
db/schema.rb
doc/install/installation.md
lib/gitlab/git_access.rb
lib/gitlab/ldap/user.rb
spec/lib/gitlab/ldap/access_spec.rb
2014-09-15 11:24:51 +02:00
Jan-Willem van der Meer
f3346a472e
Patch oauth refactoring into EE
2014-09-11 11:53:52 +02:00
Jan-Willem van der Meer
b18d1c2786
Remove duplicated create method
2014-09-08 15:25:42 +02:00
Jan-Willem van der Meer
11bb67c3c6
Test authenticate method for Gitlab::LDAP::User
2014-09-08 14:53:59 +02:00
Jan-Willem van der Meer
5b86dab03b
Move auth hash to a seperate class
2014-09-04 12:55:10 +02:00
Jan-Willem van der Meer
1bd15fa717
Use instance methods of LDAP::User as well
...
Still in need of some proper cleanup
2014-09-03 17:33:03 +02:00
Jan-Willem van der Meer
62fc80642d
Refactor Oauth::User class to use instance methods
2014-09-03 15:59:50 +02:00
Jan-Willem van der Meer
a68b1963a3
Less private methods, more test ordering
2014-09-03 11:28:32 +02:00
Jan-Willem van der Meer
61d0bf0bad
Match method order for implementation and class
...
This will prevent a mess, and keeps everything clean.
In addition i made the non interface methods private
2014-09-03 10:38:07 +02:00
Jan-Willem van der Meer
1a59ce4ee7
Add extra tests around OAUTH / LDAP find_or_create
2014-09-03 10:29:03 +02:00
Jan-Willem van der Meer
9d3eb09158
Move LDAP tests to proper location
...
Same patch as gitlab-ce
https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/1053
2014-09-03 10:10:55 +02:00
Jan-Willem van der Meer
c0323b40ee
Refactor: beter naming for active directory disabled users
2014-09-01 16:35:18 +02:00
Jan-Willem van der Meer
ca17e4b7ad
Remove duplicate method
2014-09-01 14:30:31 +02:00
Dmitriy Zaporozhets
14f5199cdc
Merge branch 'feature-ldap-tests' into 'master'
...
Feature ldap tests
Move specs to proper places. Relates to #154
This is already mergeable, will continue in a new branch for additions & refactorings.
See merge request !1053
2014-08-30 07:16:45 +00:00
Jan-Willem van der Meer
0d5ae2802e
Move and rename ldap / oauth specs
2014-08-29 17:30:42 +02:00
Jacob Vosmaer
614ca3ec65
Remove LDAP::Access#find_user
...
This method existed to allow LDAP users to take over existing GitLab
accounts if the part before the '@' of their LDAP email attribute
matched the username of an existing GitLab user. I propose to disable
this behavior in order to prevent unintended GitLab account takeovers.
After this change it is still possible to take over an existing GitLab
account with your LDAP credentials, as long as the GitLab account email
address matches the LDAP user email address.
2014-08-29 15:38:05 +02:00
Jacob Vosmaer
90ce0be420
Merge branch 'master' of dev.gitlab.org:gitlab/gitlab-ee into feature-120-multiple-ldap-groups
...
Conflicts:
app/models/group.rb
app/views/groups/members.html.haml
db/schema.rb
2014-08-29 14:43:20 +02:00
Jan-Willem van der Meer
5238efd80c
Only return found LDAP groups for processing
2014-08-29 11:09:06 +02:00
Jan-Willem van der Meer
3ba7a3a5ca
Remove traces from ldab_cn and ldap_access
...
Also add notes about refactoring the old single-ldap API and LdapGroupResetService
2014-08-15 12:33:05 +02:00
Jan-Willem van der Meer
5ff230a11d
Add more use cases for update_ldap_group_links to unit tests
2014-08-15 12:07:30 +02:00
Jan-Willem van der Meer
2541571014
Add unit test for update_ldap_group_links
...
This is the first stage, need to add some other to test revoking and
upgrading of the permissions
2014-08-15 11:31:52 +02:00
Jan-Willem van der Meer
bb93dfb2c8
Remove old code
2014-08-14 12:54:26 +02:00
Jan-Willem van der Meer
bf65eb1d4c
Handle multiple LDAP groups
2014-08-14 09:33:40 +02:00
Jan-Willem van der Meer
6f71267e8f
Make ldap_user more explicit in param
2014-08-13 16:51:21 +02:00
Jan-Willem van der Meer
673b9a373b
Add method to get the current cns the user has access to
2014-08-13 16:48:36 +02:00
Jacob Vosmaer
22ad81e2b3
Fix copy-paste errors in LDAP::Access
2014-08-08 13:04:55 +02:00
Jacob Vosmaer
5629546794
Merge remote-tracking branch 'origin/master' into ldap/cache_check
...
Conflicts:
app/controllers/application_controller.rb
app/controllers/omniauth_callbacks_controller.rb
2014-08-06 18:09:07 +02:00
Jacob Vosmaer
669682686e
Move LDAP timeout code to Gitlab::LDAP::Access
2014-08-06 18:03:01 +02:00
Dmitriy Zaporozhets
a74b66cdee
Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhq into upstream-ce
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
Conflicts:
app/models/group.rb
app/models/project.rb
features/steps/shared/project.rb
2014-07-10 23:43:42 +03:00
Jacob Vosmaer
41a3c84e40
Add logging code for LDAP keys
2014-07-09 12:18:20 +02:00
Jacob Vosmaer
526959ab63
Use a scope to add/remove LDAP keys
...
For some reason I needed to add a reload statement in the specs.
2014-07-09 12:13:09 +02:00
Jacob Vosmaer
fe6202097a
Create an Gitlab::LDAP::Person#ssh_keys attribute
...
This allows us to keep Person#entry private, and it makes
Access#update_ssh_keys a little shorter.
2014-07-09 11:06:53 +02:00
Marvin Frick
423960a435
adds spec for LDAPKeys (+4 squashed commits)
...
Squashed commits:
[812406c] fixes bug from last refactoring
[53e9508] hides "delete" button if a key is a LDAPKey
[bafc66b] refactores update_ssh_keys in own method
[7895858] makes name of ssh public key configurable
2014-07-08 12:41:12 +02:00
Oleg Girko and Marvin Frick
edaaac2f55
Make SSH keys synchronisation with LDAP not delete keys added by users.
...
This is done by using a separate LDAPKey model (inherited from Key)
for storing SSH keys which came from LDAP.
These keys can be viewed from user profile, but they can not be deleted.
Signed-off-by: Oleg Girko <oleg.girko@jollamobile.com > (+2 squashed commits)
Squashed commits:
[52b3816] Made SSH key synchronisation with LDAP configurable.
Now it can be turned on or off using configuration option
sync_ssh_keys in ldap section.
The default is off to preserve compatibility with old behaviour.
Signed-off-by: Oleg Girko <oleg.girko@jollamobile.com >
[02f988d] Synchronise LDAP users SSH keys from LDAP automatically.
SSH public keys are synchronised from sshPublicKey LDAP attribute
upon login attempt and during regular LDAP security checks.
New keys are added, old keys not present in LDAP are deleted.
Signed-off-by: Oleg Girko <oleg.girko@jollamobile.com > (+1 squashed commit)
Squashed commits:
[f087fbc] Make Gitlab::LDAP::Person.entry method public.
This is needed to allow access control methods to access
arbitrary LDAP attributes.
Signed-off-by: Oleg Girko <oleg.girko@jollamobile.com >
2014-07-08 12:31:11 +02:00
Marvin Frick
4be5c5a7a2
adds feature to sync GitLab admins with LDAP group
2014-06-23 18:17:14 +02:00
Boris HUISGEN
bac7d17c7b
Fix LDAP TLS authentication
2014-06-19 10:41:23 +02:00
Dmitriy Zaporozhets
b165b097f5
Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhq into ce-7-to-ee
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
Conflicts:
LICENSE
VERSION
app/controllers/omniauth_callbacks_controller.rb
app/helpers/application_helper.rb
app/helpers/merge_requests_helper.rb
app/models/group.rb
app/models/project.rb
app/models/project_team.rb
app/views/admin/groups/edit.html.haml
app/views/groups/_projects.html.haml
app/views/groups/edit.html.haml
db/schema.rb
doc/install/installation.md
doc/integration/README.md
lib/gitlab/git_access.rb
lib/gitlab/markdown.rb
spec/helpers/merge_requests_helper.rb
spec/models/merge_request_spec.rb
2014-06-17 10:53:44 +03:00
Marin Jankovski
314e4736e4
Strip apostrophe from email generated usernames.
2014-06-11 17:06:28 +02:00
GitLab
19a8b6ce71
Remove copyright licenses missed in 0fdab6a747.
2014-06-02 09:11:24 +02:00
Marin Jankovski
7ab468317b
Merge branch 'ldap_email_downcase' into 'master'
...
Fix LDAP email upper case bug
2014-05-22 06:59:13 +00:00
Jacob Vosmaer
e52e5da88c
Downcase the LDAP email address before comparing
2014-05-21 14:21:25 +02:00
Marin Jankovski
95ef8f9756
Merge remote-tracking branch 'ce/master'
...
Conflicts:
VERSION
doc/install/installation.md
doc/integration/README.md
doc/integration/external-issue-tracker.md
lib/gitlab/markdown.rb
spec/lib/gitlab/ldap/ldap_access_spec.rb
2014-05-21 13:10:37 +02:00