Grzegorz Bizon
359d94607c
Merge branch 'fix/award-emoji-conflict-in-notes' into 'master'
...
Fix problems with award-emoji-only comment
This fixes a conflict between note with only a single emoji in content
and award-emojis mechanisms.
Closes #3734
cc @vsizov
See merge request !1936
2015-12-07 12:26:56 +00:00
Dmitriy Zaporozhets
238ca3e472
Merge remote-tracking branch 'origin/ui/issuable-form'
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-12-04 15:12:03 +01:00
Dmitriy Zaporozhets
eb9601d906
Merge branch 'ui/form-consistency' into 'master'
...
UI: Improve form consistency
Depends on !1953
See the commits for more details, the messages mostly speak for themselves.
# Highlights
## Tag form
Before:

After:

See merge request !1955
2015-12-04 09:27:27 +00:00
Douwe Maan
e5c865eebf
Fix specs
2015-12-03 20:01:35 +01:00
Douwe Maan
494ebad39b
Fix spec
2015-12-03 18:56:43 +01:00
Douwe Maan
0cbb7717df
Fix spec
2015-12-03 18:32:29 +01:00
Douwe Maan
90899b3208
Fix specs
2015-12-03 14:54:14 +01:00
Grzegorz Bizon
4676ba1f7c
Add test for award-emoji being added as regular comment
2015-12-03 13:39:00 +01:00
Douwe Maan
0520cd7164
Merge branch 'master' into ui/form-consistency
2015-12-03 13:21:19 +01:00
Douwe Maan
12dd4c7c8a
Use "Delete" in milestone and label delete buttons instead of "Remove"
2015-12-02 14:53:56 +01:00
Douwe Maan
ffabf1df50
Add cancel button to forms that didn't have one already
2015-12-02 14:41:54 +01:00
Valery Sizov
23c5473cc0
added spinach tests
2015-11-19 13:20:09 +02:00
Robert Speicher
c8e53d4467
Revert "Merge pull request #9820 from huacnlee/avoid-render-form-in-notes-list"
...
This reverts commit 63144cd062 , reversing
changes made to 8ab5df9d87 .
2015-11-16 13:08:08 -05:00
Jason Lee
1974087114
Avoid render edit_form in each notes.
...
Use RJS to render edit note feature.
Before:
```
Rendered projects/notes/_note.html.haml (27.9ms)
Rendered projects/_zen.html.haml (0.3ms)
Rendered projects/notes/_hints.html.haml (0.7ms)
Rendered projects/_md_preview.html.haml (3.9ms)
Rendered projects/notes/_edit_form.html.haml (6.9ms)
Rendered projects/notes/_note.html.haml (17.7ms)
Rendered projects/_zen.html.haml (0.3ms)
Rendered projects/notes/_hints.html.haml (0.6ms)
Rendered projects/_md_preview.html.haml (3.4ms)
Rendered projects/notes/_edit_form.html.haml (7.0ms)
```
After:
```
Rendered projects/notes/_note.html.haml (13.8ms)
Rendered projects/notes/_note.html.haml (7.1ms)
Rendered projects/notes/_note.html.haml (9.5ms)
Rendered projects/notes/_note.html.haml (8.5ms)
```
This change reduce at least 6ms * N ('N' - number of notes).
2015-11-12 13:16:35 +08:00
Guilherme Garnier
963e6366be
Fix rubocop warnings in features
2015-10-03 19:59:54 -05:00
Stan Hu
d3d03d1362
Create a "destroyed Milestone" event and keep Milestone events around in the DB
...
for posterity.
Also fix issue where destroying a Milestone would cause odd, transient messages like
"created milestone" or "imported milestone".
Add "in" preposition when creating and destroying milestones
Closes #2382
2015-09-15 05:51:11 -07:00
Stan Hu
df2bb60f90
Add support for destroying project milestones
...
Closes https://github.com/gitlabhq/gitlabhq/issues/1504
2015-07-17 06:54:32 -07:00
Dmitriy Zaporozhets
39a4bb2abd
Cleanup and some test fixes after refactoring project home page
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-07-08 16:55:04 +02:00
Dmitriy Zaporozhets
32330e8c28
Merge branch 'rs-fix-subscription-feature' into 'master'
...
Attempt to fix the "I should see that I am [un]subscribed" steps
Makes use of Capybara methods that wait. Hopefully this will fix the
random timing-related failures of this step.
See merge request !853
2015-06-29 08:57:32 +00:00
Dmitriy Zaporozhets
c9f21c9691
Use page.within in tests
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-26 16:01:02 +02:00
Robert Speicher
d92bb3cfe0
Attempt to fix the "I should see that I am [un]subscribed" steps
...
Makes use of Capybara methods that wait. Hopefully this will fix the
random timing-related failures of this step.
2015-06-25 21:37:16 -04:00
Dmitriy Zaporozhets
304386aa02
Write test for submitting issue as guest
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-25 16:38:14 +02:00
Robert Speicher
4c42fc7c4c
Call page.all instead of all in feature steps
...
There's a naming conflict between Capybara and rspec-matchers which both
define the `all` method.
See https://github.com/jnicklas/capybara/issues/1396
2015-06-12 05:12:42 -04:00
Robert Speicher
584f8601ef
Change within to page.within in feature steps
2015-06-12 05:12:42 -04:00
Robert Speicher
69bbc413fe
Update all should-style syntax to expect in features
2015-06-12 05:12:09 -04:00
Robert Speicher
f3d63eeb18
Remove feature tests for old task lists
2015-05-06 13:00:14 -04:00
Stan Hu
3d2c387840
Move current user to the top of the list in author/assignee filters
...
Closes #1321
2015-04-09 01:04:53 -07:00
Stan Hu
dfd256f29e
Support configurable attachment size via Application Settings
...
Fix bug where error messages from Dropzone would not be displayed on the issues page
Closes #1258
2015-04-02 00:04:08 -07:00
Dmitriy Zaporozhets
c1c93f4f7a
Fix tests and unassigned filter for issues. Updated CHANGELOG
2015-03-27 00:27:51 -07:00
Valery Sizov
22fcb2f418
improve UI
2015-03-17 17:11:57 +02:00
Valery Sizov
1b437ec349
tests
2015-03-16 21:38:41 +02:00
Vinnie Okada
76aad9b76e
Upgrade to Rails 4.1.9
...
Make the following changes to deal with new behavior in Rails 4.1.2:
* Use nested resources to avoid slashes in arguments to path helpers.
2015-02-14 11:09:23 -07:00
Vinnie Okada
742e6eeed2
Merge branch 'upstream-master' into markdown-preview
...
Conflicts:
spec/routing/project_routing_spec.rb
2014-12-07 20:25:58 -07:00
Dmitriy Zaporozhets
4cbe72d767
UI improvements mostly for mobile screens
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-12-02 11:31:57 +02:00
Vinnie Okada
5bb8aff5dd
Fix more Markdown preview tests
2014-10-18 18:43:45 -05:00
Vinnie Okada
40263a06c1
Refactor task list tests and coffeescript
2014-10-06 19:19:12 -05:00
Vinnie Okada
31bc42de57
Add Spinach tests for task lists
2014-10-06 02:07:03 -05:00
Ciro Santilli
fa34901237
Make Spinach test names consistent
...
- do not add Feature to feature titles
- titleize feature titles
- put steps on the same path as .feature files
- make feature titles match their path
2014-10-05 18:21:11 +02:00