Yorick Peterse
651c3e841d
Instrument Repository.clean_old_archives
2016-04-18 12:33:11 +02:00
Yorick Peterse
7b6785b3b1
Use Module#prepend for method instrumentation
...
By using Module#prepend we can define a Module containing all proxy
methods. This removes the need for setting up crazy method alias chains
and in turn prevents us from having to deal with all that madness (e.g.
methods calling each other recursively).
Fixes gitlab-org/gitlab-ce#15281
2016-04-18 11:16:31 +02:00
Timothy Andrew
40bc8e7677
Add acceptance test to check if the user password persists after form redisplays.
...
- While signing up.
2016-04-18 12:19:11 +05:30
Stan Hu
e9f20f5922
Merge branch 'fix-issue-dropzone' into 'master'
...
Fixed issue with dropzone not working on new issuable
Closes #15295
See merge request !3760
2016-04-18 03:02:12 +00:00
BaldinoF
b04140a1e4
Merge branch 'master' into number_sign_for_external_issue_ref
2016-04-17 18:17:27 +02:00
Phil Hughes
0be158a072
Added upload file test to new issue form
2016-04-17 12:15:45 +01:00
Phil Hughes and Jacob Schatz
4b15a8ed26
Fixed up based on feedback
2016-04-16 16:13:16 -04:00
Phil Hughes and Jacob Schatz
ce2e37d446
Fixed tests
2016-04-16 16:13:16 -04:00
Alfredo Sumaran and Jacob Schatz
18b4291181
Add tests for autocomplete on a Commit
2016-04-16 07:21:28 -04:00
Alfredo Sumaran and Jacob Schatz
a53e912bc0
Change context description
2016-04-16 07:21:28 -04:00
Alfredo Sumaran and Jacob Schatz
40efb4eb1f
Add tests for autocomplete on a Merge Request
2016-04-16 07:21:28 -04:00
Alfredo Sumaran and Jacob Schatz
a740f0bc99
Add tests for autocomplete on a Issue
2016-04-16 07:21:28 -04:00
Robert Speicher
2e4d9c1de6
Merge branch 'fix/project-import_url' into 'master'
...
Fix for import_url fields on projects containing third-party credentials
Fixes https://dev.gitlab.org/gitlab/gitlabhq/issues/2658
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/13955
See merge request !3066
2016-04-15 21:52:00 +00:00
Jacob Schatz
bb59a1f98e
Merge branch 'assign-to-issuable-opener' into 'master'
...
Issuable can be assigned to author
Closes #9014
The only difference with #9014 is that I thoughed the author should also be
able to assign the issue. If this is unwanted behavior Ill revert it.
/cc @DouweM
See merge request !2765
2016-04-15 15:43:26 +00:00
Robert Schilling
3c704c33e0
Delete tags via rugged
2016-04-15 16:05:04 +02:00
Zeger-Jan van de Weg
33f8b06c39
Merge branch 'master' into assign-to-issuable-opener
2016-04-15 14:38:15 +02:00
Rémy Coutable
ddec8e777f
Merge branch 'fix-redirect-profile-keys-new-to-profile-keys' into 'master'
...
Make /profile/keys/new redirects to /profile/keys for back-compat
This addresses https://github.com/gitlabhq/gitlabhq/issues/10138 .
See merge request !3717
2016-04-15 08:19:01 +00:00
Rémy Coutable
4e2f068c5f
Merge branch 'i_14431_award_emoji_count_not_in_comment_count' into 'master'
...
Do not include award emojis in issue view comment_count
## What does this MR do?
Fixes Issue #14431 , changing comment_count on issues index view to not include award emoji comments. While including them is technically correct, it feel nonintuitive in the way comments are presented.
## Are there points in the code the reviewer needs to double check?
No
## Why was this MR needed?
Improves UX of issues view
## What are the relevant issue numbers?
#14431
## Screenshots
### Before
- 
- 
### After
- 
- 
See merge request !3610
2016-04-15 07:58:29 +00:00
Rémy Coutable
a434ffd3b3
Make /profile/keys/new redirects to /profile/keys for back-compat
...
Report: https://github.com/gitlabhq/gitlabhq/issues/10138
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-04-15 09:45:58 +02:00
James Lopez
05985b49a4
Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into fix/project-import_url
2016-04-15 08:49:08 +02:00
Douwe Maan
447a905088
Merge branch 'rs-trailing-slash-in-search' into 'master'
...
Escape the query argument provided to `git grep` by `search_files`
Closes #14963 .
See merge request !3633
2016-04-15 06:46:47 +00:00
Robert Speicher
97fd9616ac
Merge branch 'emoji_category_fix' into 'master'
...
Emoji categories fix
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/14020
See merge request !3727
2016-04-14 18:22:49 +00:00
theoretick
5bf47f14b9
Do not include award emojis in issue view comment_count
...
Fixes Issue #14431
2016-04-14 11:20:55 -07:00
Valery Sizov
6ae2680ce7
Emoji categories fix
2016-04-14 20:45:55 +03:00
Robert Speicher
95a867e0af
Merge branch 'auto-fsck' into 'master'
...
Auto git fsck
Closes https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3232
See merge request !3232
2016-04-14 17:15:58 +00:00
James Lopez
e5f7a54530
Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into fix/project-import_url
2016-04-14 18:12:10 +02:00
Rémy Coutable
dd9ced0af9
Merge branch 'connorshea/gitlab-ce-revoke-authorized-application' into 'master'
...
Fix revoking of authorized OAuth applications
Users were not able to revoke access to authorized OAuth applications. Clicking the "Revoke" button would result in a 404 page, and the application would still be authorized.
Added a spec and also found that the `gon` variables were not being set for this view.
Closes #14370
See merge request !3690
2016-04-14 15:26:09 +00:00
Rémy Coutable
4a514b27e9
Merge branch 'issue_15155' into 'master'
...
Setup visibility level for project when transfering for a group
fixes #15155
See merge request !3707
2016-04-14 15:13:08 +00:00
Jacob Vosmaer
77daebe660
More create_list
2016-04-14 17:05:41 +02:00
Stan Hu
e450892f56
Include GonHelper separately and remove created_at in factory
2016-04-14 07:25:27 -07:00
Stan Hu
c7e384aab2
Add spec for deletion of authorized OAuth2 application
...
Closes #14370
Move gon function into its own helper
2016-04-14 07:24:58 -07:00
Rémy Coutable
64776ab2b4
Merge branch 'start-with-iid-on-new-branch' into 'master'
...
Start with iid on branch creation
After the discussion it in #3886 it was decided the iid should be in the beginning of the branch name.
See merge request !3708
2016-04-14 13:41:30 +00:00
Zeger-Jan van de Weg
0385cd5a58
Start with iid on branch creation
2016-04-14 14:49:45 +02:00
Rémy Coutable
c71cdb194f
Merge branch 'simplify-gitlab-url_builder-15202' into 'master'
...
Refactor and expose only Gitlab::UrlBuilder.build(record)
```
$ git grep Gitlab::UrlBuilder
app/models/commit.rb: url: Gitlab::UrlBuilder.build(self),
app/services/issues/base_service.rb: issue_url = Gitlab::UrlBuilder.build(issue)
app/services/merge_requests/base_service.rb: hook_data[:object_attributes][:url] = Gitlab::UrlBuilder.build(merge_request)
app/views/search/results/_note.html.haml:- note_url = Gitlab::UrlBuilder.build(note)
lib/gitlab/note_data_builder.rb: base_data[:object_attributes][:url] = Gitlab::UrlBuilder.build(note)
spec/lib/gitlab/note_data_builder_spec.rb: expect(data[:object_attributes][:url]).to eq(Gitlab::UrlBuilder.build(note))
spec/lib/gitlab/url_builder_spec.rb:describe Gitlab::UrlBuilder, lib: true do
```
Fixes #15202 .
See merge request !3696
2016-04-14 10:27:49 +00:00
Phil Hughes
6e93bd56f0
Placeholder on milestone form
...
Updated JS spec to include gl_form
2016-04-14 10:28:05 +01:00
Frank Groeneveld
2fd05aed46
Allow empty recipient list when pusher is added
...
Closes #13574
2016-04-14 10:24:09 +02:00
Rémy Coutable
a872a29ebd
Merge branch 'api-issue-update-and-note-create-backdating-14947' into 'master'
...
API issue update and note create back dating
Closes #14947
See merge request !3551
2016-04-14 07:51:57 +00:00
Alfredo Sumaran
a31c1dccb6
Add test to check if top right search form is not present
2016-04-13 16:43:07 -05:00
Felipe Artur
11f46b459e
Setup visibility level for project when transfering for a group
2016-04-13 15:28:10 -03:00
Michael Greene
c1467f5d97
Allow back dating notes on creation
2016-04-13 12:04:09 -05:00
Michael Greene
28a7fe25fd
Allow back dating issues on update
2016-04-13 12:04:09 -05:00
Robert Speicher
0b447a9977
Merge branch 'fix-trailing-slash-in-bamboo_url' into 'master'
...
Fix a bug with trailing slash in bamboo_url
Also, improve specs for BambooService
Similar to !3679 .
See merge request !3680
2016-04-13 16:18:46 +00:00
Robert Speicher
6020602359
Merge branch 'fix-trailing-slash-in-teamcity_url-3515' into 'master'
...
Fix trailing slash in teamcity_url
Originally opened at !2309 by @ctmay4.
As described in #3515 , if you have trailing spaces in the the Teamcity server name, the service
will not work properly. Switching from `URI.parse` to `URI.join` fixes it so that it works with
or without a trailing slash.
Fixes #3515 .
See merge request !3679
2016-04-13 16:17:39 +00:00
Rémy Coutable
c8560894f7
Merge branch 'api-subscribe-issue-mr' into 'master'
...
API: Subscribe and unsubscribe from issues and merge requests
* Closes #6024
This MR is based on !3611 , which must be merged first.
See merge request !3615
2016-04-13 15:54:31 +00:00
Jacob Vosmaer
f07316f27c
Merge branch 'master' of https://gitlab.com/gitlab-org/gitlab-ce into auto-fsck
2016-04-13 17:38:59 +02:00
Jacob Vosmaer
6f6d2d0ad5
Use more conservative limits
2016-04-13 17:33:25 +02:00
Kamil Trzciński
3463ffde9e
Merge branch 'push-ref' into 'master'
...
Fix high CPU usage when PostReceive receives refs/merge-requests/<id>
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/12661
See merge request !3651
2016-04-13 15:27:13 +00:00
Robert Schilling
a9200d93d3
Ensure that issues and merge requests are found
2016-04-13 17:15:42 +02:00
Rémy Coutable
94e130cec3
Merge branch 'api-star-project' into 'master'
...
API: Star and unstar a project
Add two new endpoints `POST /projects/:id/star` and `POST /projects/:id/unstar` to star and unstar a project.
* Closes #12739
See merge request !3578
2016-04-13 15:05:21 +00:00
Kamil Trzcinski
af25001d46
Merge branch 'master' into push-ref
2016-04-13 16:40:59 +02:00