Commit Graph
1403 Commits
Author SHA1 Message Date
Alfredo Sumaran eff98ffe05 TAB is not used 2016-03-21 14:23:29 -05:00
Alfredo Sumaran 3a8c4ebb43 Loop through form inputs 2016-03-21 14:01:20 -05:00
Alfredo Sumaran 6e9ff2e574 Delete .remove-badge from badge 2016-03-21 13:18:34 -05:00
Alfredo Sumaran 80174538a8 Use .empty() 2016-03-21 12:31:21 -05:00
Alfredo Sumaran fb0d20c553 Merge branch 'master' of https://gitlab.com/gitlab-org/gitlab-ce into issue_3400_port 2016-03-21 12:09:52 -05:00
Jacob Schatz 2bcbc7c6db Merge branch 'remove-console-log' into 'master'
Remove console.log call



See merge request !3322
2016-03-21 16:36:00 +00:00
Kamil Trzciński 3fca30d27f Merge branch 'feature/issue-move' into 'master'
Ability to move issue to another project

Tasks:

- [x] Create scaffold of service that will move issue to another project.
- [x] Close old issue, add system note about moving issue to a new project.
- [x] Create a new issue, add system note about issue being moved from old project.
- [x] Check if issue can be moved to another project before executing service
- [x] Check permissions when moving an issue (`:admin_issue` ability)
- [x] Display select box for a new project when editing an issue
- [x] Show only projects that issue can be moved into in that select box
- [x] Add project select handler, helper and some permission filters to it
- [x] Preserve as much information as possible, including author
- [x] Prepare mechanisms that unfolds local references in issue description
- [x] Rewrite issue description with references unfolding and add some specs for it
- [x] Rewrite all system notes and comments attached to issue that is being moved
- [x] Update `Label` so that is was able to create cross reference labels (separate MR)
- [x] Add notifications about moving issue to another project
- [x] Display confirmation alert/message when issue move has been requested
- [x] Make it possible to undo selecting project where issue will be moved to
- [x] Add column to issue, that will indicate if it has been moved to another project
- [x] Do not allow to move issue that has been already moved
- [x] Write top-to-bottom feature spec in RSpec instead of Spinach

UI:

![issue_move_ui](/uploads/b3c6b563362c1fded9082cc0f51e5a74/issue_move_ui.png)

![issue_move_tooltip](/uploads/2ab913b06f52df1cafde9abe89bd9cb8/issue_move_tooltip.png)

Closes #3024

See merge request !2831
2016-03-21 14:01:19 +00:00
Dmitriy Zaporozhets 08a892b095 Merge branch 'fix-image-mode-view-diff' into 'master'
Fix diff image view modes (2-up, swipe, onion skin) not working

Example test case: https://gitlab.com/mrtzcspr/test/commit/5d983226b1308d98ef3d8919b978ad49f34496b8

Closes #13856

See merge request !3316
2016-03-21 13:38:30 +00:00
Stan Hu e79f4a79a4 Remove console.log call 2016-03-20 10:58:59 -07:00
Jacob Schatz 42fc4233e5 Merge branch 'fix-default-http-clone' into 'master'
Make HTTP(s) label consistent on clone bar

Sites that use http:// for the external_url should always display HTTP on
the clone bar. Similarly, sites that use https:// should show HTTPS.

Currently, the inconsistency looks like:

![http-magic](/uploads/945fda580f7ba5aee36cc572b49baf2b/http-magic.gif)

Also restores the tooltips that vanished in 7ba4482fcf:

![image](/uploads/b5a7b3e68b4992a447fcaa51915e866c/image.png)


See merge request !3319
2016-03-20 17:52:20 +00:00
Jacob Schatz a4422a3a2e Merge branch 'edit-form-alignment' into 'master'
Fix spacing below edit note form

Also changed to allow the CSS to decide what should be hidden when editing

Thanks @JobV for having eagle eyes 😜 

See merge request !3306
2016-03-20 15:54:49 +00:00
Jacob Schatz d3e9134601 Merge branch 'rs-auto-expand-sidebar' into 'master'
Expand the issuable sidebar when coming back from the Changes tab

Unless the user explicitly requested the collapsed sidebar.

Fixes: #14353

See merge request !3256
2016-03-20 15:10:16 +00:00
Jacob Schatz 1e420ccf59 Merge branch 'dropdown-persits-filtered-data' into 'master'
Fixed issue with filtered data persisting when dropdown closed

![labels](/uploads/4b9c902add76263d8488cc34ef49f142/labels.gif)

Closes #14401

See merge request !3302
2016-03-20 14:55:58 +00:00
Stan Hu 91f9866cce Fix specs and remove unnecessary console.log 2016-03-20 05:53:43 -07:00
Grzegorz Bizon 797af06491 Merge branch 'master' into feature/issue-move
* master:
  Fix bug where wrong commit ID was being used in a merge request diff to show old image
  Remove CHANGELOG item that was added during merge resolution
  Improve the "easy WIP & un-WIP from link" feature
  Fix specs
  \#to_branch_name now uses the iid as postfix
  Add label description in tooltip to labels in issue index and sidebar
  Easily (un)mark merge request as WIP using link
  Use specialized system notes when MR is (un)marked as WIP
  another attempt to fix oauth issue
  attempting to fix omniauth problem

Conflicts:
	app/assets/javascripts/issuable_form.js.coffee
2016-03-20 11:01:08 +01:00
Grzegorz Bizon 0115ad66d2 Merge branch 'master' into feature/issue-move
* master: (121 commits)
  Dedupe labels in labels selector in Dashboard pages
  Refactor colors and lists
  Add a safeguard in MergeRequest#compute_diverged_commits_count
  Fix an issue when the target branch of a MR had been deleted
  Add avatar to issue and MR pages header
  Cleanup somce css colors
  Re-group scss variables
  Refactor `Todo#target`
  Fixes issue with filter label missing on labels & milestones
  Rename `Todo#to_reference` to `Todo#target_reference`
  Fixed failing tests
  Updated controller with before_action Fixed other issues based on feedback
  Fixes issue on dashboard issues
  Full labels data in JSON
  Fixed issue with labels dropdown getting wrong labels
  Update CHANGELOG
  Use `Note#for_project_snippet?` to skip notes on project snippet
  Use `Commit#short_id` instead of `Commit.truncate_sha`
  Reuse `for_commit?` on conditional validations
  Update schema info comment on todo related files
  ...

Conflicts:
	app/models/issue.rb
	db/schema.rb
	spec/models/issue_spec.rb
2016-03-19 18:50:15 +01:00
Stan Hu ba92b7ca19 Fix diff image view modes (2-up, swipe, onion skin) not working
Closes #13856
2016-03-19 00:22:17 -07:00
Alfredo Sumaran b4593a1b63 Fix multiple ajax calls and plugin instantiation 2016-03-18 21:50:49 -05:00
Alfredo Sumaran 9008457a8d Save instance and avoid multiple instantiation 2016-03-18 21:43:26 -05:00
Alfredo Sumaran 3898bffd62 Code improvements 2016-03-18 17:35:26 -05:00
Rémy Coutable cafa408b25 Merge remote-tracking branch 'origin/master' into remove-wip 2016-03-18 23:29:18 +01:00
Rémy Coutable 0b942541da Improve the "easy WIP & un-WIP from link" feature 2016-03-18 23:27:35 +01:00
Alfredo SumaranandJacob Schatz cdd7e1855e Fixes failing spec 2016-03-18 14:06:51 -04:00
Alfredo SumaranandJacob Schatz 73e043d196 Delete unused file 2016-03-18 14:06:51 -04:00
Alfredo SumaranandJacob Schatz 53df7263b7 Use new dropdown class for search suggestions 2016-03-18 14:06:51 -04:00
Alfredo SumaranandJacob Schatz 2d0f8f928c Disable highlighting by default 2016-03-18 14:06:51 -04:00
Alfredo SumaranandJacob Schatz b5bd497a1f Allow to hightlight matches 2016-03-18 14:06:51 -04:00
Alfredo SumaranandJacob Schatz f858ee43ea Allow to pass header items 2016-03-18 14:06:51 -04:00
Alfredo SumaranandJacob Schatz 4e486c6116 Allow to pass input filter param
This allow us to set a different input to filter results
2016-03-18 14:06:51 -04:00
Alfredo SumaranandJacob Schatz 0b893bec54 Allow data with desired format 2016-03-18 14:06:51 -04:00
Alfredo SumaranandJacob Schatz a0c1aa6d04 Allow to pass non-asynchronous data to GitLabDropdown 2016-03-18 14:06:51 -04:00
Alfredo SumaranandJacob Schatz 2541f59227 Better wording 2016-03-18 14:06:51 -04:00
Alfredo SumaranandJacob Schatz 82e3c1f257 Change hidden input id to avoid duplicated IDs
The TODOs dashboard already had a #project_id input and it was causing a spec to fail
2016-03-18 14:06:51 -04:00
Alfredo SumaranandJacob Schatz 5479795708 Tweak behaviours 2016-03-18 14:06:51 -04:00
Alfredo SumaranandJacob Schatz 6a7f4a0767 Apply styling and tweaks to autocomplete dropdown 2016-03-18 14:06:51 -04:00
Alfredo SumaranandJacob Schatz c9e202c1d7 Working version of autocomplete with categorized results 2016-03-18 14:06:51 -04:00
Phil Hughes 7dde8b2cf0 Fix spacing below edit note form
Also changed to allow the CSS to decide what should be hidden when editting
2016-03-18 17:23:54 +00:00
Phil Hughes 2f210adee2 Fixes issue with filter label missing on labels & milestones 2016-03-18 16:25:04 +00:00
Phil Hughes c5d026a0d3 Fixed issue with filtered data persisting when dropdown closed
Closes #14401
2016-03-18 15:53:16 +00:00
Phil Hughes 0858cb097a Fixed issue with labels dropdown getting wrong labels 2016-03-18 15:18:06 +00:00
Jacob Schatz 9280fd4acd Merge branch 'fix-mr-close-button' into 'master'
Fixes issue with close button not working on MR

Closes #14383

See merge request !3295
2016-03-18 14:49:00 +00:00
Jacob Schatz 8dfa0a7649 Merge branch 'improved-issue-sidebar' into 'master'
Improved issue sidebar

Updated the spacing throughout the sidebar so that it fits better on smaller screens. Also adds a more participants button to show any other participants after the first row.

Closes #13353

See merge request !3097
2016-03-18 13:50:22 +00:00
Phil Hughes c51af604e5 Another CS style fix 2016-03-18 11:42:15 +00:00
Phil Hughes e8d52499db Fixed some CS styling issues
Fixed bug where wouldn't work on MR index
2016-03-18 11:42:15 +00:00
Phil Hughes 16d02de56e Fixed issue with dashboard issues not reloading 2016-03-18 11:40:16 +00:00
Phil Hughes 882ebfc296 Changing filter dropdowns shows loading
Instead of doing a full refresh of the page - i've modified the filterResults method on the Issues object to work for this form as well
2016-03-18 11:40:16 +00:00
Phil Hughes 4885423fea Fixes issue with close button not working on MR
Closes #14383
2016-03-18 11:36:48 +00:00
Jacob Schatz 4cd87d31bd Merge branch 'optimistic-todos' into 'master'
Adds small AJAX optimistic functionality to todos.

Fixes #13656 <br/>
A good first step and boring solution. <br/>
Will make ajax call to remove each issue.  <br/>
If issue is last in group of issues will refresh page.  <br/>
If issues remain in group will remove row with JS.  <br/>
Adds loading spinner to button and disables. <br/>

![todos-optimistic](/uploads/c6aec4a688e5125d4df55a2a3a55d4d7/todos-optimistic.gif) <br/>

cc @dzaporozhets @JobV @dbalexandre 

See merge request !2946
2016-03-18 11:23:16 +00:00
Phil Hughes fa6fae18a9 Changed any variable name to save confusion 2016-03-18 09:49:44 +00:00
Phil Hughes 72830aa809 Removed comparing against text 2016-03-18 09:48:47 +00:00