Grzegorz Bizon
0c6f04427b
Enable Performance/TimesMap Rubocop cop
...
Use Array.new with a block instead of `.times.collect` / `.times.map`.
See #17478
2016-05-30 14:21:26 +02:00
Robert Speicher
75739e54be
Enable RSpec/NotToNot cop and auto-correct offenses
...
Also removes the note from the development/testing.md guide
2016-05-24 15:40:29 -04:00
Robert Speicher
3ba72f69af
Enable Style/SpaceAroundKeyword cop and fix offenses
2016-05-23 14:16:35 -04:00
Douwe Maan
fc1910ddc5
Merge branch 'adambutler/gitlab-ce-feature/support-diff-of-issue-title-rename'
...
# Conflicts:
# app/services/system_note_service.rb
2016-05-20 16:23:04 -05:00
Rémy Coutable
0698113cab
Move #create_confidentiality_note to Issues::UpdateService
...
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-05-18 17:43:40 -05:00
Adam Butler and Rémy Coutable
8a8b5497c5
Create DiffFilter and change SystemNoteService#change_title to use Gitlab::Diff::InlineDiff
2016-05-18 11:15:10 -05:00
Alex Moore-Niemi and Rémy Coutable
483c034b86
Changing the confidentiality of an issue now creates a new system note
...
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-05-18 00:27:31 -05:00
Long Nguyen
91f693c0c4
Update changelog, improve specs
2016-05-05 13:59:09 +07:00
Long Nguyen
81467d2e04
Fix rubocop
2016-04-28 16:21:41 +07:00
Long Nguyen
f7844a11be
Code refactor and fix broken spec
2016-04-28 15:52:23 +07:00
Long Nguyen
d6d1daf430
Update specs
2016-04-27 00:03:09 +07:00
Long Nguyen
247ae96055
Allow to assign labels and milestone to target project when moving issue
2016-04-26 23:20:19 +07:00
Grzegorz Bizon
01ab6d704c
Use association search in issuable create service
2016-04-22 08:01:50 +02:00
Grzegorz Bizon
006d8b268c
Add affinity checks in issue create service
2016-04-22 08:01:50 +02:00
Grzegorz Bizon
8df63d1513
Update specs to accomodate issuable assign changes
2016-04-22 08:00:57 +02:00
Grzegorz Bizon
4adfd501a5
Verify label affiliation before assigning to issue
...
This also verify if milestone belongs to correct project before creating
a new issue.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/15439
2016-04-22 07:59:08 +02:00
Grzegorz Bizon
5ac61d7b24
Improve specs for issue move service
2016-03-31 09:47:05 +02:00
Grzegorz Bizon
f2674c7b98
Refactor uploads rewriter used when moving issue
2016-03-30 10:44:18 +02:00
Grzegorz Bizon
701976e081
Add uploads rewriter and use it when moving issue
2016-03-30 10:44:18 +02:00
Grzegorz Bizon
bab50e0133
Preserve time notes has been updated at when moving issue
2016-03-23 13:22:27 +01:00
Douwe Maan
3b39ce3252
Merge branch 'notifications-for-subscribers-confidential-issue-labels' into 'master'
...
Restrict notifications for confidential issues
Closes #14468
/cc @rymai
See merge request !3334
2016-03-23 10:34:20 +00:00
Grzegorz Bizon
915bfedfa7
Do not allow to move issue if it has not been persisted
2016-03-23 09:41:39 +01:00
Douglas Barbosa Alexandre
0a8c9f7212
Restrict notifications for confidential issues
2016-03-22 15:29:57 -03:00
Grzegorz Bizon
d6474f22d2
Preserve created at time of notes when moving issue
2016-03-20 17:05:21 +01:00
Grzegorz Bizon
f0211a4ea9
Do not pass params that are not used in issue move service
2016-03-20 09:28:06 +01:00
Grzegorz Bizon
9b13ce0b7a
Improvements in issue move feaure (refactoring)
...
According to endbosses' suggestions.
2016-03-19 18:46:01 +01:00
Grzegorz Bizon
b9036ba610
Prevent issue move if issue has been already moved
2016-03-17 11:48:51 +01:00
Grzegorz Bizon
1dd279d833
Use helper to create list of projects issue can be moved to
...
This also adds confirmation message if issue move has been requested.
2016-03-17 07:39:16 +01:00
Grzegorz Bizon
15d32b6a11
Add new notifications for issue move action
...
[ci skip]
2016-03-17 07:39:16 +01:00
Grzegorz Bizon
a23f0e8c9e
Reuse existing issue services when moving issue
2016-03-17 07:39:16 +01:00
Grzegorz Bizon
a91101b19a
Make it possible to move issue if user is a reporter
...
Discussed it here:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2831#note_4190228
2016-03-17 07:39:16 +01:00
Grzegorz Bizon
310b417b0f
Preserve original author when moving issue
...
This also wrapps entire process into transation, as rewriting references
may have large memory footprint.
2016-03-17 07:39:16 +01:00
Grzegorz Bizon
3c493c24c7
Add reference unfold pipeline used when moving issue
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
efd8251751
Minor refactoring of issue move service and specs
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
c2d4060f26
Rewrite references in notes when moving issue
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
8d3f072ec4
Take care about data being rewritten when moving issue
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
fbb5a8b089
Use a new issue create service when moving an issue
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
57eb395488
Do not pass unsanitized params to issue move service
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
4cbe87d50e
Rewrite references in issue description when moving it
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
5ed8a1e107
Silently close old issue when it has been moved
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
8a02449440
Do not show issue move form unless user can move
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
8d1b7f9507
Add issue move ability and use it in move service
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
14c983fb69
Add implementation that rewrites issue notes when moving
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
c8e7d1ed8e
Add issue move implementation to controller
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
9882802a8b
Improve system notes that are added when issue is moved
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
69b89d4ec8
Add new system note used when issue has been moved
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
b53d9f8a0e
Add scaffold of service that moves issue to another project
2016-03-17 07:39:15 +01:00
Rémy Coutable
54ec7e9599
Improving the original label-subscribing implementation
...
1. Make the "subscribed" text in Issuable sidebar reflect the labels
subscription status
2. Current user mut be logged-in to toggle issue/MR/label subscription
2016-03-15 18:22:02 +01:00
Timothy Andrew and Rémy Coutable
0444fa560a
Original implementation to allow users to subscribe to labels
...
1. Allow subscribing (the current user) to a label
- Refactor the `Subscription` coffeescript class
- The main change is that it accepts a container, and conducts all
DOM queries within its scope. We need this because the labels
page has multiple instances of `Subscription` on the same page.
2. Creating an issue or MR with labels notifies users subscribed to those labels
- Label `has_many` subscribers through subscriptions.
3. Adding a label to an issue or MR notifies users subscribed to those labels
- This only applies to subscribers of the label that has just been
added, not all labels for the issue.
2016-03-15 17:25:37 +01:00
Douglas Barbosa Alexandre
3d52e139b1
Rename Tasks to Todos
2016-02-20 12:39:27 -02:00