Dmitriy Zaporozhets and Marin Jankovski
325cedebe3
Merge branch 'fix-broken-new-project-import' into 'master'
...
Fix OAuth2 issue importing a new project from GitHub and GitLab
It appears that the GitLab OAuth2 client options were converted to strings instead of symbols when merged with the default options (i.e. `{}.merge(github_options)`). As a result, the OAuth2 defaults were being used. For example, the OAuth2 client options would have a key with `authorize_url` and `:authorize_url`, but the former was never used. As a result, the OAuth2 client would always use the wrong URL to talk to GitHub.
Note that this bug should also have affected GitLab, but not Bitbucket: The OAuth client is careful to convert all keys to symbols.
Closes #1268
See merge request !425
2015-03-24 12:23:52 -07:00
Douwe Maan
8fed435208
Unblock user if they were unblocked in AD.
2015-03-13 22:34:11 +01:00
Dmitriy Zaporozhets
e7f4f0ae1d
Block user if he/she was blocked in Active Directory
2015-03-12 11:53:21 -07:00
Douwe Maan
4dddaef866
Automatically link commit ranges to compare page.
2015-03-07 00:46:13 +01:00
Stan Hu
7e204cf389
Added comment notification events to HipChat and Slack services.
...
Supports four different event types all bundled under the "note" event type:
- comments on a commit
- comments on an issue
- comments on a merge request
- comments on a code snippet
2015-03-06 06:54:00 -08:00
Marin Jankovski
3d6d0e1e77
Merge branch 'fix-namespace-merge-request-url' into 'master'
...
Fix namespace in merge request url building
Changes in 42387b733b now require namespace specification and broke abc69c8905 .
There are additional helper functions in c530ca00b0 , but this seemed easier not to rely on them.
See merge request !363
2015-03-04 01:08:52 +00:00
Stan Hu
2088cee935
Fix URL builder to use GitlabRoutingHelper
2015-03-03 15:57:28 -08:00
Dmitriy Zaporozhets
8c47a72a4e
Merge branch 'project-existence-leak' into 'master'
...
Don't leak information about private project existence via Git-over-SSH/HTTP.
Fixes #2040 and https://gitlab.com/gitlab-org/gitlab-ce/issues/343 .
Both `Grack::Auth` (used by Git-over-HTTP) and `Api::Internal /allowed` (used by gitlab-shell/Git-over-SSH) now return a generic "Not Found" error when the project exists but the user doesn't have access to it.
See merge request !1578
2015-03-03 20:05:12 +00:00
Jeroen van Baarsen
abc69c8905
Merge branch 'fix-merge-request-url-builder' into 'master'
...
Fix merge request URL passed to Webhooks
If you look at the data structure passed to Webhooks, you will see:
`"url"=>nil`
I don't think any of the Webhooks or services are using this yet, so right now nothing so far depends upon this value being correct.
See merge request !352
2015-03-03 13:18:23 +00:00
Douwe Maan
0e11be40c3
Add tests for GrackAuth.
2015-03-03 10:49:28 +01:00
Douwe Maan
ad6d623234
Add Bitbucket importer.
2015-02-24 15:07:24 +01:00
Stan Hu
e363f2e675
Fix merge request URL passed to Webhooks.
...
Previously the symbol "url" in the object_attributes hash would always be nil.
2015-02-24 06:51:24 +00:00
Vinnie Okada
2a9eed6620
Merge branch 'master' into rails-4.1.9
...
Conflicts:
app/views/projects/commits/_commit.html.haml
app/views/projects/issues/_issue.html.haml
app/views/projects/issues/_issue_context.html.haml
app/views/projects/merge_requests/_merge_request.html.haml
app/views/projects/merge_requests/show/_context.html.haml
2015-02-21 12:55:28 -07:00
Dmitriy Zaporozhets
acc312fc25
Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce
2015-02-20 13:54:21 -08:00
Dmitriy Zaporozhets
92434b29cc
Extend project web hooks with more data
...
* add git_http_url and git_ssh_url to project web hook
* add visibility_level to project web hook
* add documentation about project visibility_level in API
2015-02-20 10:27:37 -08:00
Marcin Kulik
157b4b4b1f
Add gitorious.org importer
2015-02-20 17:42:58 +00:00
Vinnie Okada
76aad9b76e
Upgrade to Rails 4.1.9
...
Make the following changes to deal with new behavior in Rails 4.1.2:
* Use nested resources to avoid slashes in arguments to path helpers.
2015-02-14 11:09:23 -07:00
Dmitriy Zaporozhets
529188e478
Merge branch 'master' of github.com:gitlabhq/gitlabhq
2015-02-12 16:47:52 -08:00
Douwe Maan
6685661b54
Clean username acquired from OAuth/LDAP.
...
Fixes #1967 .
2015-02-12 21:05:27 +01:00
Jeroen van Baarsen
0c4a70a306
Updated rspec to rspec 3.x syntax
...
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com >
2015-02-12 19:17:35 +01:00
Douwe Maan
fd21d72b1b
Extend issue closing pattern.
2015-02-08 13:56:12 +01:00
Valery Sizov
7ddba92a39
Gitlab integration: added tests
2015-02-05 12:50:34 -08:00
Dmitriy Zaporozhets
ca701a9649
Improvements to LDAP::User model
...
* method #changed? also tracks changes of identites (fixes issue with email mapping)
* find ldap identity before initialize one
2015-01-29 13:28:41 -08:00
Marin Jankovski
9b5b334a79
Remove unused feature steps.
2015-01-26 16:04:08 -08:00
Dmitriy Zaporozhets
0c4bb84910
Merge pull request #7762 from jubianchi/commit-closing-issues
...
Allow commit messages to close several issues at once
2015-01-21 11:49:13 -08:00
Valery Sizov
ab7a79bf3b
developer can push to protected branches
2015-01-20 17:34:23 -08:00
jubianchi
b21a2d821a
Allow commit messages to close several issues at once (thanks @123Haynes
...
for his work and help)
2015-01-20 10:45:48 +01:00
Dmitriy Zaporozhets
de27375d6c
Test git builder over annotated tag
2015-01-15 11:17:47 -08:00
Dmitriy Zaporozhets
bb1f8b1d8b
Merge branch 'github_importer'
...
Conflicts:
app/helpers/projects_helper.rb
2015-01-13 10:35:16 -08:00
Dmitriy Zaporozhets
3197044512
Refactor push data builder. Moved it to separate class
...
Also execute GitLab CI on creating tag via UI
2015-01-11 23:51:31 -08:00
Valery Sizov and Valery Sizov
a9f7fd2c1a
Github Importer
2015-01-10 09:51:43 -08:00
Marin Jankovski
84af3ceb9b
Add spec for developers can push to protected branches.
2014-12-26 11:41:04 +01:00
Valery Sizov
f9a730ebb4
fix specs
2014-12-04 15:53:26 +02:00
Valery Sizov
3a5ed5260b
Supporting for multiple omniauth provider for the same user
2014-12-04 13:03:55 +02:00
Dmitriy Zaporozhets
06b7907c2a
Fix deploy keys permission check in internal api
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-12-01 16:25:10 +02:00
Valery Sizov
ef944e83ec
Git hook messages: wiki access fix
2014-11-24 16:21:35 +02:00
Valery Sizov
53bf52f191
Better message for failed pushes because of git hooks
...
Conflicts:
lib/gitlab/git_access.rb
spec/lib/gitlab/git_access_spec.rb
2014-11-18 13:10:07 +02:00
Dmitriy Zaporozhets
876c6f2491
Merge branch 'master' of github.com:gitlabhq/gitlabhq
2014-11-04 10:48:38 +02:00
Ciro Santilli
71ed0ab069
Fix push not allowed to protected branch if
...
commit starts with 7 zeros.
2014-11-03 20:37:47 +01:00
Andrey Krivko and Dmitriy Zaporozhets
bafd30f92c
Session API: Use case-insensitive authentication like in UI
2014-10-30 18:29:18 +02:00
Jacob Vosmaer
472a6621e9
Fix LDAP config lookup for provider 'ldap'
2014-10-23 22:57:16 +02:00
Dmitriy Zaporozhets
f8cdd62e22
Fix account existing blocking
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-10-17 14:08:02 +03:00
Jan-Willem van der Meer
d9bfebc0e8
Add regressiontest to verify allow_single_sign_on setting
...
verification for #1677
Since testing omniauth_callback_controller.rb is very difficult, the logic
is moved to the models
2014-10-16 20:08:30 +02:00
Jan-Willem van der Meer
fad588f2be
Remove LDAP save test
...
This is handled within the LDAP class
2014-10-16 17:18:40 +02:00
Jan-Willem van der Meer
23b692c701
Add specs for authentication and config
2014-10-14 09:31:38 +02:00
Jan-Willem van der Meer
5e1c39cb78
Merge tests to support Multiple LDAP groups
2014-10-13 17:33:44 +02:00
Jan-Willem van der Meer
01b791237c
Refactor lib files for multiple LDAP groups
2014-10-13 17:24:05 +02:00
Jan-Willem van der Meer
d059f50d4c
Refactor OAuth refactorings to CE
2014-10-10 12:03:32 +02:00
Dmitriy Zaporozhets
0bf99f6557
Developers can push to wiki repo. Protected branches does not affect wiki repo any more
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-10-07 16:05:24 +03:00
Vinnie Okada
2c46c4523f
Track projects in ReferenceExtractor
...
Store both the project and identifier of extracted references. This
prevents `ReferenceExtractor` from returning objects in the wrong
project for cross-project references.
2014-10-03 12:30:20 -05:00