Robert Speicher and Rémy Coutable
0a3f5adf92
Merge branch 'patch/fix-mergerequest-diff' into 'master'
...
Fix Raw / Rendered diff producing different results on merge requests
The raw diff endpoint (`merge_requests/####.diff`) produces a diff based on `target_branch` instead of the original branching point. Same is valid for `merge_requests/####.patch`.
Fixes #14680 , #3017
See merge request !3450
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-03-31 18:51:02 +02:00
Douwe Maan and Rémy Coutable
8d5a55ef39
Merge branch 'fix-14607' into 'master'
...
Ensure private project snippets are not viewable by unauthorized people
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/14607
See merge request !1946
2016-03-29 12:31:22 +02:00
Douwe Maan and Rémy Coutable
d0a7dfd66d
Merge branch '2489-soft-delete-issues' into 'master'
...
Soft delete issuables
Fixes #2489
What still needs to happen: research on the indexes, the gem suggests a [lot of changes](https://github.com/rubysherpas/paranoia#about-indexes ) though this is probably a good idea to discuss and I'm unsure on the impact of an omnibus upgrade as I suspect creating about 10 new indexes has a large impact on the downtime.
TODO:
- [x] Also group owners can ***soft*** delete
- [x] Button should be hidden
See merge request !2982
2016-03-22 12:36:02 +01:00
Robert Speicher and Robert Speicher
c8cc1c16d1
Merge branch 'issue_12658' into 'master'
...
Add group visibility level
Supersedes https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3051
Closes #12658
See merge request !3323
2016-03-21 21:37:57 -04:00
Robert Speicher and Rémy Coutable
b881282486
Merge branch 'issues-show-performance' into 'master'
...
Improve performance of viewing individual issues
This MR does two things:
1. `Issue#related_branches` no longer performs Git operations that aren't needed
2. The output of `Repository#exists?` is now cached and flushed properly
Combined these two changes should further cut down the amount of Git operations performed when viewing individual issues (and possibly other pages).
See merge request !3296
2016-03-21 16:40:54 +01:00
Douwe Maan and Rémy Coutable
cf52a9b435
Merge branch 'confidential-issues' into 'master'
...
Add confidential issues
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/3678
More information: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/227
See merge request !3282
2016-03-18 21:03:39 +01:00
Zeger-Jan van de Weg
2b97c92119
Incorporate review
2016-03-15 20:21:11 +01:00
Zeger-Jan van de Weg and Zeger-Jan van de Weg
ad97bebfed
Enhance new branch button on an issue
2016-03-15 20:21:11 +01:00
Zeger-Jan van de Weg
5352ec2e21
Fix denting and spec
2016-03-13 13:44:31 +01:00
Douwe Maan
cb81c8a5ef
Merge branch 'rs-issue-12944' into 'master'
...
Use a custom Devise failure app to handle unauthenticated .zip requests
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/12944
See merge request !2828
2016-03-11 22:34:33 +00:00
Robert Speicher
5844a21a0a
Use a custom Devise failure app to handle unauthenticated .zip requests
...
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/12944
2016-03-08 23:49:30 -05:00
Robert Speicher
b900304c38
Make better use of the visibility_level factory traits
2016-03-08 16:40:45 -05:00
Jacob Vosmaer
1764e1b7cb
Use Gitlab::Git::DiffCollections
2016-03-03 18:38:44 +01:00
Rubén Dávila
49e4ef3b41
Add specs to ForksController#index.
...
* Also refactor query to get projects accessible for current user.
ProjectsFinder actually return public projects when no user is passed.
2016-03-02 12:35:56 -05:00
Robert Speicher
dfca5bfa47
Move a few controller specs to their correct locations
2016-02-18 21:50:49 -05:00
Rubén Dávila
2770de9617
Reopened MRs should also be considered as open.
2016-02-17 21:15:13 -05:00
Douwe Maan
879d66b6ab
Merge branch 'git-archive-refactor' into 'master'
...
Refactor 'git archive' hand-off to gitlab-workhorse
We have a nicer way now to hand off HTTP responses to gitlab-workhorse.
Companion MR: https://gitlab.com/gitlab-org/gitlab-workhorse/merge_requests/36
See merge request !2675
2016-02-17 17:16:34 +00:00
Rémy Coutable
3d3ac87af9
Redirect /import to project page if no importing at all and repo exists
...
Fixes #13367 .
2016-02-17 15:05:44 +01:00
Jacob Vosmaer
a0ccb0731b
Merge branch 'master' of https://gitlab.com/gitlab-org/gitlab-ce into git-archive-refactor
2016-02-17 11:30:42 +01:00
Robert Speicher
f5ab126fd0
Ensure Commit#show responds 404 instead of 500 when given an invalid ID
...
Closes #13467
2016-02-15 15:48:16 -05:00
Robert Speicher
551ce0f245
Add spec for assigning view param from cookie
2016-02-05 16:03:20 -05:00
Rémy Coutable
f6d816f9fe
Add a controller test for the new 'diff_view' cookie
2016-02-05 15:40:44 +01:00
Jacob Vosmaer
771f14b96e
First version of "git archive" headers
2016-02-02 14:09:55 +01:00
Douglas Barbosa Alexandre
46c36e0e01
Fixi import redirect loop
2016-01-25 21:00:23 -02:00
Jacob Vosmaer
41b8a238ce
Merge branch 'master' of github.com:gitlabhq/gitlabhq
2016-01-07 12:56:18 +01:00
Douwe Maan
3639ebd081
Fix specs
2015-12-18 17:09:58 +01:00
Douwe Maan
d9c82d679f
Automatically fork a project when not allowed to edit a file.
2015-12-18 10:03:34 +01:00
Douwe Maan
51ed5225ad
Merge branch 'serve_lfs_object' into 'master'
...
Serve LFS object
Depends on gitlab-org/gitlab_git!57
See merge request !1976
2015-12-08 14:19:52 +00:00
Marin Jankovski
6245be083d
All for you rubocop.
2015-12-08 14:00:15 +01:00
Marin Jankovski
ea5b462a14
Stub the calls to disk and check what send_file returns.
2015-12-08 13:33:12 +01:00
Marin Jankovski
9bf51ae47d
Fix specs caused by update of gitlab-test repo.
2015-12-08 10:58:15 +01:00
Douglas Barbosa Alexandre
7d836a0c0a
Merge branch 'master' into fix-merge-request-that-removes-submodule
2015-12-07 13:09:01 -02:00
Marin Jankovski
e53b350cb6
Add specs for showing lfs object in UI.
2015-12-07 15:03:50 +01:00
Stan Hu
4fab178850
Fix spec that broke due to fact that iid is needed, not id, for MilestonesController
2015-12-05 00:04:44 -08:00
Douglas Barbosa Alexandre
12fdc13ad3
Fix 500 error when creating a merge request that removes a submodule
2015-12-04 17:35:14 -02:00
Minsik Yoon and 윤민식
3d0efa8e0a
Add ignore white space option in merge request diff
...
fix this issue(https://gitlab.com/gitlab-org/gitlab-ce/issues/1393 ).
Add ignore whitespace optoin to Commits Compare view
2015-11-13 16:53:53 +09:00
Stan Hu
9bfc531ec6
Redirect to a default path if HTTP_REFERER is not set
...
Safari 9.0 does not yet honor the HTML5 `origin-when-cross-origin` mode,
and it's possible load balancers/proxies strip the HTTP_REFERER from
the request header. In these cases, default to some default path.
Closes #3122
Closes https://github.com/gitlabhq/gitlabhq/issues/9731
2015-10-20 07:45:48 -07:00
Douwe Maan
c993481d99
Merge branch 'master' into git-archive-golang
2015-10-15 11:47:36 +02:00
Valery Sizov
8f584d5f2c
Fix: Images cannot show when projects' path was changed
2015-10-14 18:50:35 +03:00
Jacob Vosmaer
381ca79bfa
Remove archive file sending spec
...
This is done by gitlab-git-http-server now.
2015-10-14 15:21:14 +02:00
Stan Hu
0ab6ca93aa
Add directory feature button
...
Change "+" icon under "Files" section to have three options:
* Create file
* Upload file
* New directory
Upload file is no longer accessible from the "Create file" page.
Users can now select a target branch in upload file as well.
Closes #2799 : Fixes a bug where file modes were overwritten after a commit
Closes https://github.com/gitlabhq/gitlabhq/issues/8253 : Existing files
can no longer be overwritten in the "Create file" section.
Closes #2557
2015-10-07 04:22:55 -07:00
Douwe Maan
7c7b664c01
Merge branch 'master' into flevour/gitlab-ce-project-path-insensitive-lookup
2015-10-01 12:33:51 +02:00
Robert Speicher
ba71542a5a
Merge branch 'fix-issue-2593' into 'master'
...
Fix Error 500 when comparing non-existing branches
Closes #2593
See merge request !1355
2015-09-21 20:46:15 +00:00
Stan Hu
ea5c25bb4e
Remove milestones from merge requests when milestones are deleted
...
Reported by https://github.com/gitlabhq/gitlabhq/issues/9643
2015-09-21 07:00:55 -07:00
Stan Hu
de8497ca56
Fix Error 500 when comparing non-existing branches
...
Closes #2593
2015-09-18 12:02:01 -07:00
Francesco Levorato
1bbcc29687
Redirect case sensitive project path to the normalized one
2015-09-18 16:37:21 +02:00
Francesco Levorato
6bff207dfd
Refactor spec to go through ApplicationController#project
2015-09-18 16:37:21 +02:00
Stan Hu
d3d03d1362
Create a "destroyed Milestone" event and keep Milestone events around in the DB
...
for posterity.
Also fix issue where destroying a Milestone would cause odd, transient messages like
"created milestone" or "imported milestone".
Add "in" preposition when creating and destroying milestones
Closes #2382
2015-09-15 05:51:11 -07:00
pilsner
4144c59941
add Content-Type header of raw image file
...
Add Content-Type header to fix a bug which IE can't show image in
markdown when the image is from raw.
modified: CHANGELOG
modified: app/controllers/projects/raw_controller.rb
modified: spec/controllers/projects/raw_controller_spec.rb
2015-09-04 13:06:02 +09:00
Stan Hu
551157960e
Remove the filename argument from Content-Disposition header to avoid
...
RFC 5987 and RFC 6266 encoding issues. This change allows the browser
to determine the filename based on the URL.
See: http://greenbytes.de/tech/tc2231/
Closes https://github.com/gitlabhq/gitlabhq/issues/9595
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/1829
2015-09-02 00:20:05 -07:00