require 'spec_helper' describe API::API, api: true do include ApiHelpers let(:user1) { create(:user) } let(:user2) { create(:user) } let(:admin) { create(:admin) } let!(:group1) { create(:group) } let!(:group2) { create(:group) } before do group1.add_owner(user1) group2.add_owner(user2) group1.ldap_group_links.create cn: 'ldap-group', group_access: Gitlab::Access::MASTER end describe "GET /groups" do context "when unauthenticated" do it "should return authentication error" do get api("/groups") response.status.should == 401 end end context "when authenticated as user" do it "normal user: should return an array of groups of user1" do get api("/groups", user1) response.status.should == 200 json_response.should be_an Array json_response.length.should == 1 json_response.first['name'].should == group1.name json_response.first['ldap_cn'].should == group1.ldap_cn json_response.first['ldap_access'].should == group1.ldap_access ldap_group_link = json_response.first['ldap_group_links'].first ldap_group_link['cn'].should == group1.ldap_cn ldap_group_link['group_access'].should == group1.ldap_access end end context "when authenticated as admin" do it "admin: should return an array of all groups" do get api("/groups", admin) response.status.should == 200 json_response.should be_an Array json_response.length.should == 2 end end end describe "GET /groups/:id" do context "when authenticated as user" do it "should return one of user1's groups" do get api("/groups/#{group1.id}", user1) response.status.should == 200 json_response['name'] == group1.name end it "should not return a non existing group" do get api("/groups/1328", user1) response.status.should == 404 end it "should not return a group not attached to user1" do get api("/groups/#{group2.id}", user1) response.status.should == 403 end end context "when authenticated as admin" do it "should return any existing group" do get api("/groups/#{group2.id}", admin) response.status.should == 200 json_response['name'] == group2.name end it "should not return a non existing group" do get api("/groups/1328", admin) response.status.should == 404 end end context 'when using group path in URL' do it 'should return any existing group' do get api("/groups/#{group1.path}", admin) response.status.should == 200 json_response['name'] == group2.name end it 'should not return a non existing group' do get api('/groups/unknown', admin) response.status.should == 404 end it 'should not return a group not attached to user1' do get api("/groups/#{group2.path}", user1) response.status.should == 403 end end end describe "POST /groups" do context "when authenticated as user" do it "should not create group" do post api("/groups", user1), attributes_for(:group) response.status.should == 403 end end context "when authenticated as admin" do it "should create group" do post api("/groups", admin), attributes_for(:group) response.status.should == 201 end it "should not create group, duplicate" do post api("/groups", admin), {name: "Duplicate Test", path: group2.path} response.status.should == 400 response.message.should == "Bad Request" end it "should return 400 bad request error if name not given" do post api("/groups", admin), {path: group2.path} response.status.should == 400 end it "should return 400 bad request error if path not given" do post api("/groups", admin), { name: 'test' } response.status.should == 400 end it "creates an ldap_group_link if ldap_cn and ldap_access are supplied" do group_attributes = attributes_for(:group, ldap_cn: 'ldap-group', ldap_access: Gitlab::Access::DEVELOPER) expect { post api("/groups", admin), group_attributes }.to change{ LdapGroupLink.count }.by(1) end end end describe "DELETE /groups/:id" do context "when authenticated as user" do it "should remove group" do delete api("/groups/#{group1.id}", user1) response.status.should == 200 end it "should not remove a group if not an owner" do user3 = create(:user) group1.add_user(user3, Gitlab::Access::MASTER) delete api("/groups/#{group1.id}", user3) response.status.should == 403 end it "should not remove a non existing group" do delete api("/groups/1328", user1) response.status.should == 404 end it "should not remove a group not attached to user1" do delete api("/groups/#{group2.id}", user1) response.status.should == 403 end end context "when authenticated as admin" do it "should remove any existing group" do delete api("/groups/#{group2.id}", admin) response.status.should == 200 end it "should not remove a non existing group" do delete api("/groups/1328", admin) response.status.should == 404 end end end describe "POST /groups/:id/projects/:project_id" do let(:project) { create(:project) } before(:each) do Projects::TransferService.any_instance.stub(execute: true) Project.stub(:find).and_return(project) end context "when authenticated as user" do it "should not transfer project to group" do post api("/groups/#{group1.id}/projects/#{project.id}", user2) response.status.should == 403 end end context "when authenticated as admin" do it "should transfer project to group" do post api("/groups/#{group1.id}/projects/#{project.id}", admin) response.status.should == 201 end end end end