mirror of
https://github.com/wahyd4/gitlabhq.git
synced 2026-08-09 20:56:08 +10:00
Kamil Trzcinski
447f1e30db
This solves https://dev.gitlab.org/gitlab/gitlabhq/issues/2646 1. This MR simplifies CI permission model: - read_build: allows to read a list of builds, artifacts and trace - update_build: allows to cancel and retry builds - admin_build: allows to manage triggers, runners and variables - read_commit_status: allows to read a list of commit statuses (including the status of a build, but doesn't allow to see a build details) - create_commit_status: allows to create a new commit status using API 2. I do make sure that the proper permissions are used in all places where the CI can be shown. 3. Add the `read_build` ability if user is anonymous or guest and allow_guest_to_access_builds is enabled. 4. Add CI setting: public_builds. 5. The artifacts specific permission are removed, since they are covered by `*_build`.
34 lines
988 B
Ruby
34 lines
988 B
Ruby
module Ci
|
|
class ProjectsController < Ci::ApplicationController
|
|
before_action :project
|
|
before_action :authorize_read_project!, except: [:badge]
|
|
before_action :no_cache, only: [:badge]
|
|
protect_from_forgery
|
|
|
|
def show
|
|
# Temporary compatibility with CI badges pointing to CI project page
|
|
redirect_to namespace_project_path(project.namespace, project)
|
|
end
|
|
|
|
# Project status badge
|
|
# Image with build status for sha or ref
|
|
def badge
|
|
image = Ci::ImageForBuildService.new.execute(@project, params)
|
|
|
|
send_file image.path, filename: image.name, disposition: 'inline', type:"image/svg+xml"
|
|
end
|
|
|
|
protected
|
|
|
|
def project
|
|
@project ||= Project.find_by(ci_id: params[:id].to_i)
|
|
end
|
|
|
|
def no_cache
|
|
response.headers["Cache-Control"] = "no-cache, no-store, max-age=0, must-revalidate"
|
|
response.headers["Pragma"] = "no-cache"
|
|
response.headers["Expires"] = "Fri, 01 Jan 1990 00:00:00 GMT"
|
|
end
|
|
end
|
|
end
|