mirror of
https://github.com/wahyd4/gitlabhq.git
synced 2026-08-09 20:56:08 +10:00
Stan Hu
0fdfd2dd6e
Here was the problem: 1. When determining whether a given blob is viewable text, gitlab_git reads the first 1024 bytes and checks with Linguist whether it is a text or binary file. 2. If the blob is text, GitLab will attempt to display it. 3. However, if the text has binary characters after the first 1024 bytes, then GitLab will attempt to load the entire contents, but the encoding will be ASCII-8BIT since there are binary characters. 4. The Error 500 results when GitLab attempts to display a mix UTF-8 and ASCII-8BIT. To fix this, we load as much data as we are willing to display so that the detection will work properly. Requires an update to gitlab_git: gitlab-org/gitlab_git!86 Closes #13826
50 lines
995 B
Ruby
50 lines
995 B
Ruby
require 'rails_helper'
|
|
|
|
describe Projects::CommitController do
|
|
describe 'GET show' do
|
|
render_views
|
|
|
|
let(:project) { create(:project) }
|
|
|
|
before do
|
|
user = create(:user)
|
|
project.team << [user, :master]
|
|
|
|
sign_in(user)
|
|
end
|
|
|
|
context 'with valid id' do
|
|
it 'responds with 200' do
|
|
go id: project.commit.id
|
|
|
|
expect(response).to be_ok
|
|
end
|
|
end
|
|
|
|
context 'with invalid id' do
|
|
it 'responds with 404' do
|
|
go id: project.commit.id.reverse
|
|
|
|
expect(response).to be_not_found
|
|
end
|
|
end
|
|
|
|
it 'handles binary files' do
|
|
get(:show,
|
|
namespace_id: project.namespace.to_param,
|
|
project_id: project.to_param,
|
|
id: TestEnv::BRANCH_SHA['binary-encoding'],
|
|
format: "html")
|
|
|
|
expect(response).to be_success
|
|
end
|
|
|
|
def go(id:)
|
|
get :show,
|
|
namespace_id: project.namespace.to_param,
|
|
project_id: project.to_param,
|
|
id: id
|
|
end
|
|
end
|
|
end
|