mirror of
https://github.com/wahyd4/gitlabhq.git
synced 2026-08-12 06:06:05 +10:00
Rémy CoutableandYorick Peterse
b255cbf396
add slack notifications for wiki pages ## What does this MR do? Lets the Slack service be configured to send notifications when wiki pages are created or edited. ## Are there points in the code the reviewer needs to double check? I'm just starting to get familiar with the Gitlab codebase and I was unsure on how to get the wiki page url to pass it to the slack message, on whether or not I needed to refactor the create/update methods for wiki pages from the controller to a service (but seemed necessary to test it better), and if I needed to add a column to the web hooks table or if the services table would have been enough. Please let me know if I should change anything and I will improve the MR, thanks for checking :) ## Why was this MR needed? Related to #563 and fixes #4233. See merge request !2998
120 lines
3.9 KiB
Ruby
120 lines
3.9 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Gitlab::UrlBuilder, lib: true do
|
|
describe '.build' do
|
|
context 'when passing a Commit' do
|
|
it 'returns a proper URL' do
|
|
commit = build_stubbed(:commit)
|
|
|
|
url = described_class.build(commit)
|
|
|
|
expect(url).to eq "#{Settings.gitlab['url']}/#{commit.project.path_with_namespace}/commit/#{commit.id}"
|
|
end
|
|
end
|
|
|
|
context 'when passing an Issue' do
|
|
it 'returns a proper URL' do
|
|
issue = build_stubbed(:issue, iid: 42)
|
|
|
|
url = described_class.build(issue)
|
|
|
|
expect(url).to eq "#{Settings.gitlab['url']}/#{issue.project.path_with_namespace}/issues/#{issue.iid}"
|
|
end
|
|
end
|
|
|
|
context 'when passing a MergeRequest' do
|
|
it 'returns a proper URL' do
|
|
merge_request = build_stubbed(:merge_request, iid: 42)
|
|
|
|
url = described_class.build(merge_request)
|
|
|
|
expect(url).to eq "#{Settings.gitlab['url']}/#{merge_request.project.path_with_namespace}/merge_requests/#{merge_request.iid}"
|
|
end
|
|
end
|
|
|
|
context 'when passing a Note' do
|
|
context 'on a Commit' do
|
|
it 'returns a proper URL' do
|
|
note = build_stubbed(:note_on_commit)
|
|
|
|
url = described_class.build(note)
|
|
|
|
expect(url).to eq "#{Settings.gitlab['url']}/#{note.project.path_with_namespace}/commit/#{note.commit_id}#note_#{note.id}"
|
|
end
|
|
end
|
|
|
|
context 'on a CommitDiff' do
|
|
it 'returns a proper URL' do
|
|
note = build_stubbed(:note_on_commit_diff)
|
|
|
|
url = described_class.build(note)
|
|
|
|
expect(url).to eq "#{Settings.gitlab['url']}/#{note.project.path_with_namespace}/commit/#{note.commit_id}#note_#{note.id}"
|
|
end
|
|
end
|
|
|
|
context 'on an Issue' do
|
|
it 'returns a proper URL' do
|
|
issue = create(:issue, iid: 42)
|
|
note = build_stubbed(:note_on_issue, noteable: issue)
|
|
|
|
url = described_class.build(note)
|
|
|
|
expect(url).to eq "#{Settings.gitlab['url']}/#{issue.project.path_with_namespace}/issues/#{issue.iid}#note_#{note.id}"
|
|
end
|
|
end
|
|
|
|
context 'on a MergeRequest' do
|
|
it 'returns a proper URL' do
|
|
merge_request = create(:merge_request, iid: 42)
|
|
note = build_stubbed(:note_on_merge_request, noteable: merge_request)
|
|
|
|
url = described_class.build(note)
|
|
|
|
expect(url).to eq "#{Settings.gitlab['url']}/#{merge_request.project.path_with_namespace}/merge_requests/#{merge_request.iid}#note_#{note.id}"
|
|
end
|
|
end
|
|
|
|
context 'on a MergeRequestDiff' do
|
|
it 'returns a proper URL' do
|
|
merge_request = create(:merge_request, iid: 42)
|
|
note = build_stubbed(:note_on_merge_request_diff, noteable: merge_request)
|
|
|
|
url = described_class.build(note)
|
|
|
|
expect(url).to eq "#{Settings.gitlab['url']}/#{merge_request.project.path_with_namespace}/merge_requests/#{merge_request.iid}#note_#{note.id}"
|
|
end
|
|
end
|
|
|
|
context 'on a ProjectSnippet' do
|
|
it 'returns a proper URL' do
|
|
project_snippet = create(:project_snippet)
|
|
note = build_stubbed(:note_on_project_snippet, noteable: project_snippet)
|
|
|
|
url = described_class.build(note)
|
|
|
|
expect(url).to eq "#{Settings.gitlab['url']}/#{project_snippet.project.path_with_namespace}/snippets/#{note.noteable_id}#note_#{note.id}"
|
|
end
|
|
end
|
|
|
|
context 'on another object' do
|
|
it 'returns a proper URL' do
|
|
project = build_stubbed(:project)
|
|
|
|
expect { described_class.build(project) }.
|
|
to raise_error(NotImplementedError, 'No URL builder defined for Project')
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when passing a WikiPage' do
|
|
it 'returns a proper URL' do
|
|
wiki_page = build(:wiki_page)
|
|
url = described_class.build(wiki_page)
|
|
|
|
expect(url).to eq "#{Gitlab.config.gitlab.url}#{wiki_page.wiki.wiki_base_path}/#{wiki_page.slug}"
|
|
end
|
|
end
|
|
end
|
|
end
|