mirror of
https://github.com/wahyd4/gitlabhq.git
synced 2026-08-15 07:36:41 +10:00
Douwe MaanandRémy Coutable
f30004819a
workaround for forks with an invalid repo Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/13465 The error occurs when a project returns a `nil` commit for a variety of reasons, I assume the repository is corrupt - perhaps as a result of a failed fork. With this MR, we do not show forks with corrupted repos in the list of forks, as this does not seem to work anyway. A better solution is to fix the cause of the issue and/or any data integrity problem... Also fixing Sentry issue: 1180 `undefined method 'already_forked?' for nil:NilClass ` See merge request !2836
84 lines
2.4 KiB
Ruby
84 lines
2.4 KiB
Ruby
class Spinach::Features::ProjectFork < Spinach::FeatureSteps
|
|
include SharedAuthentication
|
|
include SharedPaths
|
|
include SharedProject
|
|
|
|
step 'I click link "Fork"' do
|
|
expect(page).to have_content "Shop"
|
|
click_link "Fork project"
|
|
end
|
|
|
|
step 'I am a member of project "Shop"' do
|
|
@project = create(:project, name: "Shop")
|
|
@project.team << [@user, :reporter]
|
|
end
|
|
|
|
step 'I should see the forked project page' do
|
|
expect(page).to have_content "Forked from"
|
|
end
|
|
|
|
step 'I already have a project named "Shop" in my namespace' do
|
|
@my_project = create(:project, name: "Shop", namespace: current_user.namespace)
|
|
end
|
|
|
|
step 'I should see a "Name has already been taken" warning' do
|
|
expect(page).to have_content "Name has already been taken"
|
|
end
|
|
|
|
step 'I fork to my namespace' do
|
|
page.within '.fork-namespaces' do
|
|
click_link current_user.name
|
|
end
|
|
end
|
|
|
|
step 'I should see "New merge request"' do
|
|
expect(page).to have_content(/new merge request/i)
|
|
end
|
|
|
|
step 'I goto the Merge Requests page' do
|
|
page.within '.page-sidebar-expanded' do
|
|
click_link "Merge Requests"
|
|
end
|
|
end
|
|
|
|
step 'I click link "New merge request"' do
|
|
expect(page).to have_content(/new merge request/i)
|
|
click_link "New Merge Request"
|
|
end
|
|
|
|
step 'I should see the new merge request page for my namespace' do
|
|
current_path.should have_content(/#{current_user.namespace.name}/i)
|
|
end
|
|
|
|
step 'I visit the forks page of the "Shop" project' do
|
|
@project = Project.where(name: 'Shop').last
|
|
visit namespace_project_forks_path(@project.namespace, @project)
|
|
end
|
|
|
|
step 'I should see my fork on the list' do
|
|
page.within('.projects-list-holder') do
|
|
project = @user.fork_of(@project)
|
|
expect(page).to have_content("#{project.namespace.human_name} / #{project.name}")
|
|
end
|
|
end
|
|
|
|
step 'I make forked repo invalid' do
|
|
project = @user.fork_of(@project)
|
|
project.path = 'test-crappy-path'
|
|
project.save!
|
|
end
|
|
|
|
step 'There is an existent fork of the "Shop" project' do
|
|
user = create(:user, name: 'Mike')
|
|
@forked_project = Projects::ForkService.new(@project, user).execute
|
|
end
|
|
|
|
step 'I should not see the other fork listed' do
|
|
expect(page).not_to have_content("#{@forked_project.namespace.human_name} / #{@forked_project.name}")
|
|
end
|
|
|
|
step 'I should see a private fork notice' do
|
|
expect(page).to have_content("1 private fork")
|
|
end
|
|
end
|