mirror of
https://github.com/wahyd4/gitlabhq.git
synced 2026-08-17 08:36:06 +10:00
Advanced cache Fixes #1993 * Build missing cache values in background job after each push * Store commit_count in project table. Refresh in background job * moved repository size calculation in background job ## Advantages Every time push is triggered - we build cache for project even without user visiting project page. That means first visit is as fast as others now. This is especially good for active projects where people have some requests fast because of cache and some slow - because cache was build in their request. Between cache expired and cache built we we had gap when Linux repo can give 502 error because calculation commits count takes 30 seconds or even more. Using value from database fix this problem. Before cache is updated you see old value from database. After - you see new one. Basically this merge request is super win to GitLab. We don't do some heavy operations in user request but instead in background job. ## Temporary problem After this migration all projects will have `0` commits in database. It fill be replaced with real value on next push. I did not add recalculation to migration because it will last forever on big instances. Can be fixed by adding rake task which will go in background on live instance without downtime See merge request !986
144 lines
5.2 KiB
Ruby
144 lines
5.2 KiB
Ruby
class GitPushService
|
|
attr_accessor :project, :user, :push_data, :push_commits
|
|
include Gitlab::CurrentSettings
|
|
include Gitlab::Access
|
|
|
|
# This method will be called after each git update
|
|
# and only if the provided user and project is present in GitLab.
|
|
#
|
|
# All callbacks for post receive action should be placed here.
|
|
#
|
|
# Next, this method:
|
|
# 1. Creates the push event
|
|
# 2. Ensures that the project satellite exists
|
|
# 3. Updates merge requests
|
|
# 4. Recognizes cross-references from commit messages
|
|
# 5. Executes the project's web hooks
|
|
# 6. Executes the project's services
|
|
#
|
|
def execute(project, user, oldrev, newrev, ref)
|
|
@project, @user = project, user
|
|
|
|
project.ensure_satellite_exists
|
|
project.repository.expire_cache
|
|
|
|
if push_remove_branch?(ref, newrev)
|
|
@push_commits = []
|
|
elsif push_to_new_branch?(ref, oldrev)
|
|
# Re-find the pushed commits.
|
|
if is_default_branch?(ref)
|
|
# Initial push to the default branch. Take the full history of that branch as "newly pushed".
|
|
@push_commits = project.repository.commits(newrev)
|
|
|
|
# Ensure HEAD points to the default branch in case it is not master
|
|
branch_name = Gitlab::Git.ref_name(ref)
|
|
project.change_head(branch_name)
|
|
|
|
# Set protection on the default branch if configured
|
|
if (current_application_settings.default_branch_protection != PROTECTION_NONE)
|
|
developers_can_push = current_application_settings.default_branch_protection == PROTECTION_DEV_CAN_PUSH ? true : false
|
|
project.protected_branches.create({ name: project.default_branch, developers_can_push: developers_can_push })
|
|
end
|
|
else
|
|
# Use the pushed commits that aren't reachable by the default branch
|
|
# as a heuristic. This may include more commits than are actually pushed, but
|
|
# that shouldn't matter because we check for existing cross-references later.
|
|
@push_commits = project.repository.commits_between(project.default_branch, newrev)
|
|
|
|
# don't process commits for the initial push to the default branch
|
|
process_commit_messages(ref)
|
|
end
|
|
elsif push_to_existing_branch?(ref, oldrev)
|
|
# Collect data for this git push
|
|
@push_commits = project.repository.commits_between(oldrev, newrev)
|
|
project.update_merge_requests(oldrev, newrev, ref, @user)
|
|
process_commit_messages(ref)
|
|
end
|
|
|
|
@push_data = build_push_data(oldrev, newrev, ref)
|
|
|
|
EventCreateService.new.push(project, user, @push_data)
|
|
project.execute_hooks(@push_data.dup, :push_hooks)
|
|
project.execute_services(@push_data.dup, :push_hooks)
|
|
ProjectCacheWorker.perform_async(project.id)
|
|
end
|
|
|
|
protected
|
|
|
|
# Extract any GFM references from the pushed commit messages. If the configured issue-closing regex is matched,
|
|
# close the referenced Issue. Create cross-reference Notes corresponding to any other referenced Mentionables.
|
|
def process_commit_messages(ref)
|
|
is_default_branch = is_default_branch?(ref)
|
|
|
|
@push_commits.each do |commit|
|
|
# Close issues if these commits were pushed to the project's default branch and the commit message matches the
|
|
# closing regex. Exclude any mentioned Issues from cross-referencing even if the commits are being pushed to
|
|
# a different branch.
|
|
issues_to_close = commit.closes_issues(user)
|
|
|
|
# Load commit author only if needed.
|
|
# For push with 1k commits it prevents 900+ requests in database
|
|
author = nil
|
|
|
|
if issues_to_close.present? && is_default_branch
|
|
author ||= commit_user(commit)
|
|
|
|
issues_to_close.each do |issue|
|
|
Issues::CloseService.new(project, author, {}).execute(issue, commit)
|
|
end
|
|
end
|
|
|
|
if project.default_issues_tracker?
|
|
create_cross_reference_notes(commit, issues_to_close)
|
|
end
|
|
end
|
|
end
|
|
|
|
def create_cross_reference_notes(commit, issues_to_close)
|
|
# Create cross-reference notes for any other references. Omit any issues that were referenced in an
|
|
# issue-closing phrase, or have already been mentioned from this commit (probably from this commit
|
|
# being pushed to a different branch).
|
|
refs = commit.references(project, user) - issues_to_close
|
|
refs.reject! { |r| commit.has_mentioned?(r) }
|
|
|
|
if refs.present?
|
|
author ||= commit_user(commit)
|
|
|
|
refs.each do |r|
|
|
SystemNoteService.cross_reference(r, commit, author)
|
|
end
|
|
end
|
|
end
|
|
|
|
def build_push_data(oldrev, newrev, ref)
|
|
Gitlab::PushDataBuilder.
|
|
build(project, user, oldrev, newrev, ref, push_commits)
|
|
end
|
|
|
|
def push_to_existing_branch?(ref, oldrev)
|
|
# Return if this is not a push to a branch (e.g. new commits)
|
|
Gitlab::Git.branch_ref?(ref) && !Gitlab::Git.blank_ref?(oldrev)
|
|
end
|
|
|
|
def push_to_new_branch?(ref, oldrev)
|
|
Gitlab::Git.branch_ref?(ref) && Gitlab::Git.blank_ref?(oldrev)
|
|
end
|
|
|
|
def push_remove_branch?(ref, newrev)
|
|
Gitlab::Git.branch_ref?(ref) && Gitlab::Git.blank_ref?(newrev)
|
|
end
|
|
|
|
def push_to_branch?(ref)
|
|
Gitlab::Git.branch_ref?(ref)
|
|
end
|
|
|
|
def is_default_branch?(ref)
|
|
Gitlab::Git.branch_ref?(ref) &&
|
|
(Gitlab::Git.ref_name(ref) == project.default_branch || project.default_branch.nil?)
|
|
end
|
|
|
|
def commit_user(commit)
|
|
commit.author || user
|
|
end
|
|
end
|