gitlabhq

mirror of https://github.com/wahyd4/gitlabhq.git synced 2026-08-10 21:26:07 +10:00

Files

T

Marin Jankovski 8fa9da49c4 Merge branch 'set-omniauth-full-host' into 'master'

Set OmniAuth full_host parameter to ensure redirect URIs are correct

### What does this MR do?

This MR sets the OmniAuth `full_host` parameter to the configured GitLab URL to ensure the `redirect_uri` parameter is called with the right GitLab host.

### Why was this MR needed?

[OmniAuth attempts to grab the request URI](http://awesomeprogrammer.com/blog/2012/12/09/dealing-with-omniauth-redirect-uri-mismatch-invalid-port-number-gotcha/) and use that. If you set up a reverse proxy that terminates SSL at the Web server layer (e.g. https://gitlab.domain.com), omniauth will use the internal URL (e.g. http://my-host:8080) in its redirect URI unless all the Web server headers are properly set (e.g. `X-Forwarded-Port`, etc.). This is easy to forget or mess up, and it's better to ensure that OmniAuth has the right value from the start.

### What are the relevant issue numbers?

Closes #1967

See merge request !991

2015-07-20 08:45:58 +00:00

environments

Merge pull request #8349 from divineforest/cleanup-assets-compress

2015-03-02 15:23:57 -08:00

initializers

Merge branch 'set-omniauth-full-host' into 'master'

2015-07-20 08:45:58 +00:00

locales

Improve OAuth application flash messages.

2015-05-13 09:41:56 +02:00

application.rb

Expire Rails cache entries after two weeks