Douwe Maan 33d8972bf9 Merge branch 'fix-18717' into 'master' ...

Ensure that group owner cannot request access to a project of their group

## What does this MR do?

It fixes two things:

- 91ad995d69e1a0f8991fd896f1d9febc109273fe Ensure that group owner cannot request access to a project of their group
- ec3ff061148d556757e7cd486cdc6083d77acf34 Ensure group/project owners can see their members' access_level (see the commit message for details)

## Are there points in the code the reviewer needs to double check?

Not really, these are pretty simple fixes.

## Why was this MR needed?

Because there was an issue created!

## What are the relevant issue numbers?

Fixes #18717.

## Does this MR meet the acceptance criteria?

- [x] CHANGELOG is not needed since the bug is only present in a 8.9 RC
- [x] Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !4729

2016-06-17 22:47:19 +00:00

..

admin

Fix admin hooks spec

2016-06-15 18:47:43 +03:00

atom

Apply reviewer notes: update CHANGELOG, adjust code formatting

2016-06-13 09:51:55 -07:00

dashboard

Change date format to be non zero padded in order to fix failing test

2016-06-09 14:38:24 -05:00

groups/members

UI and copywriting improvements

2016-06-14 13:18:14 +02:00

issues

Improved manual todos

2016-06-17 09:01:03 +01:00

merge_requests

Rename ci_commit -> pipeline

2016-06-10 14:41:38 +02:00

profiles

Implement @DouweM's feedback.

2016-06-16 08:24:13 +05:30

projects

Merge branch 'fix-18717' into 'master'

2016-06-17 22:47:19 +00:00

security

Authorize environments controller actions

2016-06-14 14:43:45 +02:00

tags

Fix spec for new project navigation

2016-05-16 12:25:37 -05:00

todos

Ensure Todos counters doesn't count Todos for projects pending delete

2016-06-17 16:17:43 -03:00

builds_spec.rb

Fix specs

2016-06-14 11:38:34 +02:00

ci_lint_spec.rb

Allow subsequent validations in CI Linter

2016-01-11 13:37:31 +01:00

commits_spec.rb

Rename all [ci_]commit to [ci_]pipeline in specs and features

2016-06-03 16:22:26 +02:00

container_registry_spec.rb

Use container registry config stub

2016-05-16 18:07:49 -05:00

dashboard_issues_spec.rb

Fixed issue with dashboard/issues not filtering by milestone

2016-04-11 11:38:24 +01:00

dashboard_milestones_spec.rb

Add missing Dashboard::LabelsController

2016-03-23 12:02:15 +01:00

environments_spec.rb

Make environments_spec more feature-spec

2016-06-15 12:24:47 +02:00

gitlab_flavored_markdown_spec.rb

Make sure the gfm helper passes the required options

2015-08-31 18:09:18 -04:00

groups_spec.rb

Add feature tag to feature specs

2015-07-06 22:39:55 -04:00

help_pages_spec.rb

Re-fix image rendering for help pages

2015-04-15 12:45:31 -04:00

issues_spec.rb

Merge branch 'issuable-sidebar-bold' into 'master'

2016-06-15 20:29:50 +00:00

login_spec.rb

Implement authentication (login) using a U2F device.

2016-06-06 12:50:31 +05:30

markdown_spec.rb

Merge branch '18019-fix-wiki-linking' into 'master'

2016-06-09 08:37:27 +00:00

milestone_spec.rb

Use a better message when milestone is newly created

2016-04-29 10:15:49 +01:00

notes_on_merge_requests_spec.rb

Incorportate feedback

2016-06-01 12:10:08 +02:00

participants_autocomplete_spec.rb

Update specs to carry out changes in note factory

2016-05-29 15:03:00 -04:00

password_reset_spec.rb

Use devise paranoid mode and ensure the same message is returned every time

2015-12-09 18:40:37 -06:00

pipelines_spec.rb

Rename all [ci_]commit to [ci_]pipeline in specs and features

2016-06-03 16:22:26 +02:00

profile_spec.rb

Use stub_application_setting in a few more specs

2015-07-06 22:39:56 -04:00

projects_spec.rb

Project title dropdown tests

2016-04-26 09:35:58 +01:00

runners_spec.rb

Enable RSpec/NotToNot cop and auto-correct offenses

2016-05-24 15:40:29 -04:00

search_spec.rb

Fix specs and add new tests.

2016-06-10 01:05:09 +03:00

signup_spec.rb

Change landing page when skipping confirmation email and add documentation

2016-05-16 14:56:32 -03:00

task_lists_spec.rb

Update specs to carry out changes in note factory

2016-05-29 15:03:00 -04:00

triggers_spec.rb

Remove ci_ prefix from all ci related things

2015-12-11 18:02:09 +01:00

u2f_spec.rb

Update u2f_spec to cover U2F being disabled until authenticator is set up.

2016-06-15 08:16:54 +05:30

users_spec.rb

Improve uniqueness of field names on the signup form

2016-04-19 16:00:45 -04:00

variables_spec.rb

Enable RSpec/NotToNot cop and auto-correct offenses

2016-05-24 15:40:29 -04:00