mirror of
https://github.com/wahyd4/gitlabhq.git
synced 2026-08-14 15:16:04 +10:00
Rémy CoutableandRobert Speicher
421b5aafbc
Show proper image ID on registry page ## What does this MR do? Display the container registry image ID (from the config blob) instead of the first image layer ID ## Are there points in the code the reviewer needs to double check? ## Why was this MR needed? To show proper image ID on container_registry page. This only supports manifest V2, since the manifest V1 doesn't expose information about Image ID. ## What are the relevant issue numbers? Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/18159. ## Screenshots (if relevant)  - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - Tests - [x] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !4821
46 lines
1.3 KiB
Ruby
46 lines
1.3 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe "Container Registry" do
|
|
let(:project) { create(:empty_project) }
|
|
let(:repository) { project.container_registry_repository }
|
|
let(:tag_name) { 'latest' }
|
|
let(:tags) { [tag_name] }
|
|
|
|
before do
|
|
login_as(:user)
|
|
project.team << [@user, :developer]
|
|
stub_container_registry_tags(*tags)
|
|
stub_container_registry_config(enabled: true)
|
|
allow(Auth::ContainerRegistryAuthenticationService).to receive(:full_access_token).and_return('token')
|
|
end
|
|
|
|
describe 'GET /:project/container_registry' do
|
|
before do
|
|
visit namespace_project_container_registry_index_path(project.namespace, project)
|
|
end
|
|
|
|
context 'when no tags' do
|
|
let(:tags) { [] }
|
|
|
|
it { expect(page).to have_content('No images in Container Registry for this project') }
|
|
end
|
|
|
|
context 'when there are tags' do
|
|
it { expect(page).to have_content(tag_name) }
|
|
it { expect(page).to have_content('d7a513a66') }
|
|
end
|
|
end
|
|
|
|
describe 'DELETE /:project/container_registry/tag' do
|
|
before do
|
|
visit namespace_project_container_registry_index_path(project.namespace, project)
|
|
end
|
|
|
|
it do
|
|
expect_any_instance_of(::ContainerRegistry::Tag).to receive(:delete).and_return(true)
|
|
|
|
click_on 'Remove'
|
|
end
|
|
end
|
|
end
|