mirror of
https://github.com/wahyd4/gitlabhq.git
synced 2026-08-11 05:36:07 +10:00
Yorick Peterse
86166d2802
This splits the Markdown rendering and reference extraction phases into two distinct code bases. The reference extraction phase no longer relies on the html-pipeline Gem (and any related code) and allows for extracting of references from multiple HTML nodes in a single pass. This means that if you want to extract user references from 200 comments you no longer need to run 200 times N number of queries, instead only a handful of queries may be needed.
63 lines
1.7 KiB
Ruby
63 lines
1.7 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Banzai::ReferenceParser::ExternalIssueParser, lib: true do
|
|
include ReferenceParserHelpers
|
|
|
|
let(:project) { create(:empty_project, :public) }
|
|
let(:user) { create(:user) }
|
|
subject { described_class.new(project, user) }
|
|
let(:link) { empty_html_link }
|
|
|
|
describe '#referenced_by' do
|
|
context 'when the link has a data-project attribute' do
|
|
before do
|
|
link['data-project'] = project.id.to_s
|
|
end
|
|
|
|
context 'when the link has a data-external-issue attribute' do
|
|
it 'returns an Array of ExternalIssue instances' do
|
|
link['data-external-issue'] = '123'
|
|
|
|
refs = subject.referenced_by([link])
|
|
|
|
expect(refs).to eq([ExternalIssue.new('123', project)])
|
|
end
|
|
end
|
|
|
|
context 'when the link does not have a data-external-issue attribute' do
|
|
it 'returns an empty Array' do
|
|
expect(subject.referenced_by([link])).to eq([])
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when the link does not have a data-project attribute' do
|
|
it 'returns an empty Array' do
|
|
expect(subject.referenced_by([link])).to eq([])
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#issue_ids_per_project' do
|
|
before do
|
|
link['data-project'] = project.id.to_s
|
|
end
|
|
|
|
it 'returns a Hash containing range IDs per project' do
|
|
link['data-external-issue'] = '123'
|
|
|
|
hash = subject.issue_ids_per_project([link])
|
|
|
|
expect(hash).to be_an_instance_of(Hash)
|
|
|
|
expect(hash[project.id].to_a).to eq(['123'])
|
|
end
|
|
|
|
it 'does not add a project when the data-external-issue attribute is empty' do
|
|
hash = subject.issue_ids_per_project([link])
|
|
|
|
expect(hash).to be_empty
|
|
end
|
|
end
|
|
end
|