Lin Jen-Shin b0908d8739 Extra tests inside shared_examples: ...

Feedback from:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093#note_12321421

The advantage of this is that tests are less about logic and more
straightforward, thus could be easier to reason about each individual
tests.

The disadvantage of this is that we write more duplicated codes and
once something changed we might need to change all places and it's
harder to reason all tests as a whole. Because now we need to look at
more places to figure out how it should work under another option!

2016-06-09 16:00:24 +08:00

..

config

Enable the Rubocop DeprecatedClassMethods cop

2016-05-08 15:33:34 -06:00

controllers

Fix endless redirections when accessing user OAuth applications when they are disabled

2016-06-08 05:52:04 -07:00

factories

Merge branch 'rename-ci-commit' into rename-ci-commit-phase-2

2016-06-06 16:46:36 +02:00

features

Combine tests for internal links

2016-06-08 13:07:20 -05:00

finders

Make upcoming milestone work across projects

2016-05-16 10:25:24 +01:00

fixtures

Set target="_blank" for external links

2016-06-08 13:07:20 -05:00

helpers

Merge remote-tracking branch 'origin/master' into rename-ci-commit

2016-06-06 11:20:17 +02:00

initializers

Add tests for setting trusted_proxies

2016-05-04 15:49:39 -07:00

javascripts

Merge branch 'notes-are-awardables' into 'master'

2016-06-06 16:48:35 +00:00

lib

Merge branch 'master' of https://gitlab.com/gitlab-org/gitlab-ce into git-http-controller

2016-06-08 10:31:33 +02:00

mailers

Update tests for the current_application_settings request store changes

2016-05-27 19:05:52 -07:00

models

Extra tests inside shared_examples:

2016-06-09 16:00:24 +08:00

requests

Prefer attributes_for_keys so that it ignores nils

2016-06-09 16:00:24 +08:00

routing

Merge branch 'health-check-route'

2016-05-12 16:39:03 -05:00

services

Fix remaining test offenses

2016-06-07 13:14:37 +02:00

support

Merge branch 'rename-ci-commit' into rename-ci-commit-phase-2

2016-06-06 16:46:36 +02:00

tasks/gitlab

Switch the gitlab:db:configure task to use tables.any? instead of looking specifically for the schema_migrations table

2016-05-25 10:47:09 -07:00

views

Move "I should see Crowd login form" feature to a view spec

2016-02-24 17:38:13 -05:00

workers

Rename all [ci_]commit to [ci_]pipeline in specs and features

2016-06-03 16:22:26 +02:00

factories_spec.rb

Enable RSpec/NotToNot cop and auto-correct offenses

2016-05-24 15:40:29 -04:00

rails_helper.rb

Started on the actual rspec 3 upgrade

2015-06-22 12:12:49 +02:00

spec_helper.rb

Enable Knapsack only in CI environment

2016-06-08 11:43:13 +02:00

teaspoon_env.rb

Add leading comment space cop

2016-05-31 19:33:46 -03:00