mirror of
https://github.com/wahyd4/gitlabhq.git
synced 2026-08-19 09:36:47 +10:00
Kamil TrzcińskiandRémy Coutable
ab3681d149
Ability to move issue to another project Tasks: - [x] Create scaffold of service that will move issue to another project. - [x] Close old issue, add system note about moving issue to a new project. - [x] Create a new issue, add system note about issue being moved from old project. - [x] Check if issue can be moved to another project before executing service - [x] Check permissions when moving an issue (`:admin_issue` ability) - [x] Display select box for a new project when editing an issue - [x] Show only projects that issue can be moved into in that select box - [x] Add project select handler, helper and some permission filters to it - [x] Preserve as much information as possible, including author - [x] Prepare mechanisms that unfolds local references in issue description - [x] Rewrite issue description with references unfolding and add some specs for it - [x] Rewrite all system notes and comments attached to issue that is being moved - [x] Update `Label` so that is was able to create cross reference labels (separate MR) - [x] Add notifications about moving issue to another project - [x] Display confirmation alert/message when issue move has been requested - [x] Make it possible to undo selecting project where issue will be moved to - [x] Add column to issue, that will indicate if it has been moved to another project - [x] Do not allow to move issue that has been already moved - [x] Write top-to-bottom feature spec in RSpec instead of Spinach UI:   Closes #3024 See merge request !2831
90 lines
3.0 KiB
Ruby
90 lines
3.0 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Gitlab::Gfm::ReferenceRewriter do
|
|
let(:text) { 'some text' }
|
|
let(:old_project) { create(:project) }
|
|
let(:new_project) { create(:project) }
|
|
let(:user) { create(:user) }
|
|
|
|
before { old_project.team << [user, :guest] }
|
|
|
|
describe '#rewrite' do
|
|
subject do
|
|
described_class.new(text, old_project, user).rewrite(new_project)
|
|
end
|
|
|
|
context 'multiple issues and merge requests referenced' do
|
|
let!(:issue_first) { create(:issue, project: old_project) }
|
|
let!(:issue_second) { create(:issue, project: old_project) }
|
|
let!(:merge_request) { create(:merge_request, source_project: old_project) }
|
|
|
|
context 'plain text description' do
|
|
let(:text) { 'Description that references #1, #2 and !1' }
|
|
|
|
it { is_expected.to include issue_first.to_reference(new_project) }
|
|
it { is_expected.to include issue_second.to_reference(new_project) }
|
|
it { is_expected.to include merge_request.to_reference(new_project) }
|
|
end
|
|
|
|
context 'description with ignored elements' do
|
|
let(:text) do
|
|
"Hi. This references #1, but not `#2`\n" +
|
|
'<pre>and not !1</pre>'
|
|
end
|
|
|
|
it { is_expected.to include issue_first.to_reference(new_project) }
|
|
it { is_expected.to_not include issue_second.to_reference(new_project) }
|
|
it { is_expected.to_not include merge_request.to_reference(new_project) }
|
|
end
|
|
|
|
context 'description ambigous elements' do
|
|
context 'url' do
|
|
let(:url) { 'http://gitlab.com/#1' }
|
|
let(:text) { "This references #1, but not #{url}" }
|
|
|
|
it { is_expected.to include url }
|
|
end
|
|
|
|
context 'code' do
|
|
let(:text) { "#1, but not `[#1]`" }
|
|
it { is_expected.to eq "#{issue_first.to_reference(new_project)}, but not `[#1]`" }
|
|
end
|
|
|
|
context 'code reverse' do
|
|
let(:text) { "not `#1`, but #1" }
|
|
it { is_expected.to eq "not `#1`, but #{issue_first.to_reference(new_project)}" }
|
|
end
|
|
|
|
context 'code in random order' do
|
|
let(:text) { "#1, `#1`, #1, `#1`" }
|
|
let(:ref) { issue_first.to_reference(new_project) }
|
|
|
|
it { is_expected.to eq "#{ref}, `#1`, #{ref}, `#1`" }
|
|
end
|
|
|
|
context 'description with labels' do
|
|
let!(:label) { create(:label, id: 123, name: 'test', project: old_project) }
|
|
let(:project_ref) { old_project.to_reference }
|
|
|
|
context 'label referenced by id' do
|
|
let(:text) { '#1 and ~123' }
|
|
it { is_expected.to eq %Q{#{project_ref}#1 and #{project_ref}~123} }
|
|
end
|
|
|
|
context 'label referenced by text' do
|
|
let(:text) { '#1 and ~"test"' }
|
|
it { is_expected.to eq %Q{#{project_ref}#1 and #{project_ref}~123} }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'reference contains milestone' do
|
|
let(:milestone) { create(:milestone) }
|
|
let(:text) { "milestone ref: #{milestone.to_reference}" }
|
|
|
|
it { is_expected.to eq text }
|
|
end
|
|
end
|
|
end
|
|
end
|