mirror of
https://github.com/wahyd4/gitlabhq.git
synced 2026-08-15 23:56:09 +10:00
Stan Hu
2f04599751
Consolidate allowed parameters in one place to avoid these kinds of bugs in the future. Closes https://github.com/gitlabhq/gitlabhq/issues/9181
59 lines
1.8 KiB
Ruby
59 lines
1.8 KiB
Ruby
class Projects::ServicesController < Projects::ApplicationController
|
|
ALLOWED_PARAMS = [:title, :token, :type, :active, :api_key, :subdomain,
|
|
:room, :recipients, :project_url, :webhook,
|
|
:user_key, :device, :priority, :sound, :bamboo_url, :username, :password,
|
|
:build_key, :server, :teamcity_url, :build_type,
|
|
:description, :issues_url, :new_issue_url, :restrict_to_branch, :channel,
|
|
:colorize_messages, :channels,
|
|
:push_events, :issues_events, :merge_requests_events, :tag_push_events,
|
|
:note_events, :send_from_committer_email, :disable_diffs, :external_wiki_url]
|
|
# Authorize
|
|
before_action :authorize_admin_project!
|
|
before_action :service, only: [:edit, :update, :test]
|
|
|
|
respond_to :html
|
|
|
|
layout "project_settings"
|
|
|
|
def index
|
|
@project.build_missing_services
|
|
@services = @project.services.visible.reload
|
|
end
|
|
|
|
def edit
|
|
end
|
|
|
|
def update
|
|
if @service.update_attributes(service_params)
|
|
redirect_to(
|
|
edit_namespace_project_service_path(@project.namespace, @project,
|
|
@service.to_param, notice:
|
|
'Successfully updated.')
|
|
)
|
|
else
|
|
render 'edit'
|
|
end
|
|
end
|
|
|
|
def test
|
|
data = Gitlab::PushDataBuilder.build_sample(project, current_user)
|
|
if @service.execute(data)
|
|
message = { notice: 'We sent a request to the provided URL' }
|
|
else
|
|
message = { alert: 'We tried to send a request to the provided URL but an error occured' }
|
|
end
|
|
|
|
redirect_to :back, message
|
|
end
|
|
|
|
private
|
|
|
|
def service
|
|
@service ||= @project.services.find { |service| service.to_param == params[:id] }
|
|
end
|
|
|
|
def service_params
|
|
params.require(:service).permit(ALLOWED_PARAMS)
|
|
end
|
|
end
|