Files
gitlabhq/lib
Robert Speicher d75ec6cd46 Merge branch 'fix-missing-saml-error-handling' into 'master'
Add proper nil and error handling to SAML login process

While writing the feature that would allow certain Omniauth providers to be marked as external I noticed that there is a scenario where the `gl_user` method can return `nil` and if this is not properly checked, it will lead to exceptions that will cause 500 errors. It is quite easy to land in this scenario, so I added `nil` checks.

I also noticed that the `saml` method in the `omniauth_callbacks_controller.rb` file lacked a `rescue` for `Gitlab::OAuth::SignupDisabledError`, which can happen if the default configuration from `1_settings.rb` is applied. So I also added this check.

See merge request !3609
2016-04-12 15:46:39 +00:00
..
2016-04-11 17:43:12 +02:00
2016-03-30 19:29:17 +02:00
2016-03-02 22:19:36 -05:00
2015-10-03 01:29:58 -05:00
2015-11-10 12:51:50 +01:00
2014-08-14 15:48:14 +04:00
2015-11-10 12:51:50 +01:00