home/gitlabhq
2
0
Fork 0
mirror of https://github.com/wahyd4/gitlabhq.git synced 2026-08-11 05:36:07 +10:00
Code Issues Packages Projects Releases Wiki Activity
Files
e27de52607369a11ee3cec7fbdd2ffa5cb6e0061
gitlabhq/app/assets/javascripts
T
History
Jacob Schatz e27de52607 Merge branch 'issuable-sidebar-dropdown-deselect-fix' into 'master' 
Fixed issue with de-selecting dropdown option in issue sidebar

## What does this MR do?

When de-selecting either an assignee or milestone, we try to send `undefined` which jQuery removes from the request causing a routing error. Instead this MR sends `null` which jQuery still sends and then correctly removes either the milestone or assignee. 

## What are the relevant issue numbers?

Closes #18641 

## Screenshots (if relevant)

![assignee](/uploads/6eaca416fb6e31eabf4c038967160c07/assignee.gif)

## Does this MR meet the acceptance criteria?

- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests
  - [ ] Added for this feature/bug
  - [ ] All builds are passing
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !4671
2016-06-15 14:59:02 +00:00
..
behaviors
Merge branch 'fix-bug-causing-comment-to-submit-twice' into 'master'
2016-04-13 15:04:09 +00:00
blob
Dropdown implementation
2016-05-20 15:58:36 -05:00
ci
Displays time remaining relative to now
2016-06-13 11:08:15 +01:00
commit
Fixed JS issue with diff image loading
2015-03-26 21:08:17 +00:00
extensions
Remove unused showAndHide, simpleFormat, and linkify functions
2015-06-02 20:32:07 -04:00
graphs
Only load Chart.js when necessary.
2016-06-07 15:27:30 -06:00
lib
Fix project star tooltip on the fly.
2016-06-15 15:14:53 +03:00
u2f
Implement authentication (login) using a U2F device.
2016-06-06 12:50:31 +05:30
users
Attempt to fix the user page.
2016-06-01 19:42:49 -06:00
activities.js.coffee
Update method name for better understanding
2016-06-09 14:38:24 -05:00
admin.js.coffee
Allow limited Markdown in Broadcast Messages
2016-02-06 14:30:07 -05:00
api.js.coffee
Dropdown implementation
2016-05-20 15:58:36 -05:00
application.js.coffee
Displays time remaining relative to now
2016-06-13 11:08:15 +01:00
aside.js.coffee
Remove console.log call
2016-03-20 10:58:59 -07:00
autosave.js.coffee
Fix syntax error in autosave coffeescript.
2016-02-26 13:22:35 +01:00
awards_handler.coffee
Minor MR comment fixes.
2016-06-10 01:56:41 +03:00
branch-graph.js.coffee
Fix missing date of month in network graph when commits span a month
2016-01-06 21:05:46 -08:00
breakpoints.coffee
Fix bug with JS error from dropdowns in filter area
2016-03-14 23:23:30 -04:00
broadcast_message.js.coffee
Allow limited Markdown in Broadcast Messages
2016-02-06 14:30:07 -05:00
build_artifacts.js.coffee
Move build artifacts javascripts into separate file
2016-01-21 15:51:44 +01:00
commit.js.coffee
Export all coffee classes with @
2014-10-20 23:03:33 +02:00
commits.js.coffee
Remove unused param
2016-04-21 00:20:13 +00:00
compare.js.coffee
Removed un-used get request
2016-04-06 11:08:40 +01:00
confirm_danger_modal.js.coffee
Fix "Cannot move project" error message from popping up after a successful project transfer
2015-04-20 12:46:02 -07:00
copy_to_clipboard.js.coffee
Rework the copy_to_clipboard logic
2015-11-24 19:12:03 -05:00
diff.js.coffee
Gitlab Issue 707: Indent unfolded code 1 character
2015-07-22 09:58:17 -04:00
dispatcher.js.coffee
Instantiate awardsHandler in application main script.
2016-06-09 02:57:53 +03:00
dropzone_input.js.coffee
Removes dropzone focus class after dropping file
2016-04-15 18:24:16 +01:00
due_date_select.js.coffee
Fixed JS errors
2016-06-05 16:15:51 -04:00
flash.js.coffee
Enhancements
2016-06-03 17:14:23 -05:00
gfm_auto_complete.js.coffee
Checks based on whether data is loaded not undefined
2016-06-09 17:20:57 -04:00
gl_crop.js.coffee
Clear original input after crop
2016-03-22 13:43:32 -05:00
gl_dropdown.js.coffee
Fixed issue with dropdown toggle not updating
2016-06-08 11:45:17 +01:00
gl_form.js.coffee
Removed GL Actions class
2016-04-14 10:28:05 +01:00
group_avatar.js.coffee
Only run avatar chooser Js on pages that need it
2014-10-21 10:46:55 +02:00
groups_select.js.coffee
Group selectbox js
2014-12-30 11:46:48 +02:00
groups.js.coffee
Only run avatar chooser Js on pages that need it
2014-10-21 10:46:55 +02:00
importer_status.js.coffee
Addressed feedback
2016-04-18 13:45:26 +01:00
issuable_context.js.coffee
Fixed issue with project dropdown links not being clickable
2016-04-22 10:57:00 +01:00
issuable_form.js.coffee
Fixed issue with move dropdown not being searchable
2016-06-15 08:53:11 +01:00
issuable.js.coffee
Use Turbolink instead of ajax
2016-06-14 12:39:51 -05:00
issue_status_select.js.coffee
Status dropdown
2016-03-10 13:54:54 +00:00
issue.js.coffee
Load the "New Branch" button asynchronously
2016-04-28 16:13:48 -04:00
issues-bulk-assignment.js.coffee
Reinitialize checkboxes to toggle event bindings
2016-06-14 12:39:51 -05:00
LabelManager.js.coffee
Improve functionality
2016-06-06 11:59:49 -05:00
labels_select.js.coffee
Merge branch 'label-create-error-messages' into 'master'
2016-06-10 15:38:32 +00:00
labels.js.coffee
Remove disableButtonIf[Any]EmptyField calls from forms
2015-06-26 22:07:59 -04:00
layout_nav.js.coffee
Removed console.log
2016-06-14 17:53:26 +01:00
line_highlighter.js.coffee
Apply new design to files page
2015-10-13 16:41:48 +02:00
logo.js.coffee
Fix #18604, logo in header wasn't an anchor link.
2016-06-14 15:57:46 -06:00
markdown_preview.js.coffee
Cache only last response in markdown preview
2016-03-09 09:30:50 +01:00
merge_request_tabs.js.coffee
Clicking changes tab scrolls the window to show the content
2016-05-18 11:13:57 +01:00
merge_request_widget.js.coffee
Fixed potential issue with 2 ci status polling events happening
2016-05-26 15:24:35 +01:00
merge_request.js.coffee
Added toolbar to comment form
2016-04-04 10:48:49 +01:00
milestone_select.js.coffee
Fixed issue with de-selecting dropdown option in issue sidebar
2016-06-15 12:40:22 +01:00
milestone.js.coffee
Updates from last code review.
2016-03-06 23:07:19 -05:00
namespace_select.js.coffee
Only run namespace select js when needed
2014-10-21 22:54:22 +02:00
network.js.coffee
Awesome shortcuts for GitLab
2014-09-01 11:49:17 +02:00
new_branch_form.js.coffee
Fix minor stylistic complaints
2015-12-21 22:21:10 -02:00
new_commit_form.js.coffee
Automatically fork a project when not allowed to edit a file.
2015-12-18 10:03:34 +01:00
notes.js.coffee
Fix note polling when a window has been hidden
2016-06-13 16:23:38 -04:00
pager.js.coffee
Fix local timeago on user dashboard
2016-06-09 14:38:24 -05:00
profile.js.coffee
Add null check to formData.append
2016-04-18 13:04:36 -05:00
project_avatar.js.coffee
Fix tests, merge conflicts, some minor issues and make the project avatar feature mergable
2015-01-24 18:51:16 +01:00
project_find_file.js.coffee
Merge branch 'master' of github.com:gitlabhq/gitlabhq
2016-01-07 12:56:18 +01:00
project_fork.js.coffee
Improve fork to namespaces feature
2014-11-14 16:06:39 +02:00
project_import.js.coffee
Export all coffee classes with @
2014-10-20 23:03:33 +02:00
project_members.js.coffee
Use same layout and interactivity for project members as group members.
2015-03-15 13:55:57 +01:00
project_new.js.coffee
Allow or not merge MR with failed build
2016-06-10 14:36:54 +02:00
project_select.js.coffee
Project dropdown in header uses new dropdown
2016-04-12 13:10:43 -04:00
project_show.js.coffee
Cleanup and some test fixes after refactoring project home page
2015-07-08 16:55:04 +02:00
project.js.coffee
Create NotificationSettings object only when user change value in dropdown
2016-03-30 10:44:20 +02:00
projects_list.js.coffee
Use modern syntax
2016-03-10 13:55:01 +01:00
protected_branches.js.coffee
Improve protected branches page UX
2015-03-25 22:45:58 -07:00
right_sidebar.js.coffee
Uses update URL to update the status of a todo
2016-06-14 08:36:07 +01:00
search_autocomplete.js.coffee
Fixed issue with search autocomplete not allow arrow key navigation
2016-06-03 12:48:49 -04:00
search.js.coffee
Focus field
2016-04-26 09:03:04 +01:00
shortcuts_dashboard_navigation.js.coffee
Fix dashboard shortcuts
2016-05-17 00:35:16 -05:00
shortcuts_find_file.js.coffee
Merge branch 'master' of github.com:gitlabhq/gitlabhq
2016-01-07 12:56:18 +01:00
shortcuts_issuable.coffee
Remove prev/next buttons on issues and merge requests
2016-06-06 12:01:50 -04:00
shortcuts_navigation.coffee
Set i as a shortcut for creating a new issue
2016-04-18 15:03:36 -05:00
shortcuts_network.js.coffee
Awesome shortcuts for GitLab
2014-09-01 11:49:17 +02:00
shortcuts.js.coffee
Use gon.shortcuts_path directly
2016-04-21 12:47:09 -05:00
sidebar.js.coffee
Move tanuki icon to center of nav bar; keep nav closed by default; remove collapsed nav cookie
2016-06-10 12:01:51 -05:00
star.js.coffee
Fix project star tooltip on the fly.
2016-06-15 15:14:53 +03:00
subscription.js.coffee
Updated subscribe icon
2016-06-09 17:19:14 +01:00
syntax_highlight.coffee
Add specs for syntax_highlight JS
2015-09-10 15:38:24 -04:00
todos.js.coffee
Allow middle-click on a Todo row to open in a new tab
2016-04-24 15:01:52 -04:00
tree.js.coffee
Fix search in Files
2015-10-06 11:43:32 +03:00
user_tabs.js.coffee
Fix local timeago on user dashboard
2016-06-09 14:38:24 -05:00
user.js.coffee
Refactor projects list
2016-03-03 13:09:58 +01:00
users_select.js.coffee
Fixed issue with de-selecting dropdown option in issue sidebar
2016-06-15 12:40:22 +01:00
wikis.js.coffee
Set of small improvements to wiki frontend
2016-02-07 17:57:28 +01:00
zen_mode.js.coffee
Restyling on elements in comment form
2016-04-04 10:48:49 +01:00