Rémy Coutable f73def90a8 Merge branch 'fix-ci-commit-creation' into 'master' ...

Fix creation of Ci::Commit object which can lead to pending, failed in some scenarios

## What does this MR do?

If we use a new `project.ci_commits` it will add it to array, and some other services which can do a save on a project can lead to a scenario when `ci_commit` will be saved, where it should not be.

## What are the relevant issue numbers?

https://gitlab.com/gitlab-com/support-forum/issues/717 https://gitlab.com/gitlab-com/support-forum/issues/715 https://gitlab.com/gitlab-org/gitlab-ce/issues/17596 https://gitlab.com/gitlab-com/support-forum/issues/714 https://gitlab.com/gitlab-org/gitlab-ce/issues/13402

cc @rymai 


See merge request !4214

2016-05-19 21:42:24 +00:00

..

auth

Fix 401 message

2016-05-16 17:12:45 -05:00

ci

Create pipeline objects with parameters

2016-05-18 17:01:42 -05:00

commits

Add support to cherry-pick any commit

2016-04-18 15:39:07 +08:00

files

Automatically fork a project when not allowed to edit a file.

2015-12-18 10:03:34 +01:00

groups

Address feedback

2016-03-22 00:09:20 +01:00

issues

Move #create_confidentiality_note to Issues::UpdateService

2016-05-18 17:43:40 -05:00

merge_requests

Create a todo on failing MR build

2016-05-17 10:17:45 +01:00

milestones

Implement review suggestions

2016-04-07 10:59:24 -03:00

notes

Prevent privilege escalation via notes API

2016-04-26 14:40:51 -04:00

oauth2

Rubocop: no trailing newlines

2015-02-02 21:53:27 -08:00

projects

Merge branch 'docker-registry-view' into 'master'

2016-05-18 18:19:01 +00:00

search

Restrict access to confidential issues on search results

2016-03-17 20:55:59 -03:00

wiki_pages

Fix error when trying to create a wiki page

2016-04-29 06:50:18 -07:00

audit_event_service.rb

Audit log for user authentication

2015-07-06 12:36:08 +03:00

base_service.rb

Tweaks, refactoring, and specs

2016-03-20 21:04:07 +01:00

compare_service.rb

Use Gitlab::Git::DiffCollections

2016-03-03 18:38:44 +01:00

create_branch_service.rb

Use a similar approach to branch creation for tag creation

2016-05-04 17:19:13 +02:00

create_commit_builds_service.rb

Fix creation of Ci::Commit object which can lead to pending, failed in some scenarios

2016-05-19 15:51:41 -05:00

create_release_service.rb

Allow editing a release in API via PUT method

2015-11-21 22:34:53 +01:00

create_snippet_service.rb

Tweaks, refactoring, and specs

2016-03-20 21:04:07 +01:00

create_spam_log_service.rb

Support Akismet spam checking for creation of issues via API

2016-02-02 11:25:44 -02:00

create_tag_service.rb

Use a similar approach to branch creation for tag creation

2016-05-04 17:19:13 +02:00

delete_branch_service.rb

Fix duplicated branch creation/deletion Web hooks/service notifications when using Web UI

2016-02-09 06:22:49 -08:00

delete_tag_service.rb

Refactor release code a bit

2015-11-09 15:30:50 +01:00

delete_user_service.rb

Clearify who deletes the user

2016-03-15 21:09:25 +01:00

destroy_group_service.rb

Add ability to delete a user with force

2016-03-15 21:09:25 +01:00

event_create_service.rb

Create a "destroyed Milestone" event and keep Milestone events around in the DB

2015-09-15 05:51:11 -07:00

git_hooks_service.rb

Raise the exception from #execute instead of #run_hook. #1156 #3069

2015-12-03 09:39:15 -05:00

git_push_service.rb

Expire repository exists? and has_visible_content? caches after a push if necessary

2016-05-04 11:59:12 -07:00

git_tag_push_service.rb

Expire repository exists? and has_visible_content? caches after a push if necessary

2016-05-04 11:59:12 -07:00

gravatar_service.rb

Add support for HiDPI displays in gravatar service

2015-09-26 20:53:16 +02:00

issuable_base_service.rb

Move #create_confidentiality_note to Issues::UpdateService

2016-05-18 17:43:40 -05:00

notification_service.rb

Reuse User#notification_settings_for when it's possible

2016-04-11 20:50:26 -03:00

repair_ldap_blocked_user_service.rb

Code style fixes and some code simplified

2016-01-08 16:26:04 -02:00

system_hooks_service.rb

Codestyle: make sure we have space around operators

2016-05-13 04:46:56 -03:00

system_note_service.rb

Move #create_confidentiality_note to Issues::UpdateService

2016-05-18 17:43:40 -05:00

test_hook_service.rb

Added X-GitLab-Event header for web hooks

2015-05-08 16:49:03 +03:00

todo_service.rb

Create a todo on failing MR build

2016-05-17 10:17:45 +01:00

update_release_service.rb

Allow editing a release in API via PUT method

2015-11-21 22:34:53 +01:00

update_snippet_service.rb

Tweaks, refactoring, and specs

2016-03-20 21:04:07 +01:00