Rémy Coutable dc38551b93 Merge branch '18377-cherry-pick-crashes-when-choosing-a-tag' into 'master' ...

Only show branches for revert / cherry-pick

## What does this MR do?

Stop showing tags in the revert and cherry-pick select options. You can't change a tag anyway.

## Are there points in the code the reviewer needs to double check?

Uncertain.

## Why was this MR needed?

Showing tags doesn't make any sense and will just throw an exception if the user tries to cherry-pick or revert onto a tag.

## What are the relevant issue numbers?

Fixes #18377.

## Screenshots (if relevant)

On the GitLab CE repo:

![image](/uploads/9c5a6f09300a7c46d0a794bef2956992/image.png)

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests
  - [x] Added for this feature/bug
  - [ ] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !4596

2016-06-13 12:46:29 +00:00

..

appearances_helper.rb

Start adding SVG icons

2016-06-08 12:56:02 -05:00

application_helper.rb

Merge branch 'issue-filter-name-options' into 'master'

2016-05-25 19:44:06 +00:00

application_settings_helper.rb

Allow custom text on 'almost there' page

2016-06-08 19:08:53 +01:00

auth_helper.rb

Add a U2fRegistrations table/model.

2016-06-06 12:50:31 +05:30

blob_helper.rb

Dropdown implementation

2016-05-20 15:58:36 -05:00

branches_helper.rb

Only show branches for revert / cherry-pick

2016-06-13 11:05:22 +01:00

broadcast_messages_helper.rb

Allow limited Markdown in Broadcast Messages

2016-02-06 14:30:07 -05:00

button_helper.rb

Fix wiki project clone address error

2016-06-02 09:46:26 +02:00

ci_status_helper.rb

Rename all ci_commit[s] in application code to pipeline[s]

2016-06-03 16:27:50 +02:00

commits_helper.rb

Reduced number of buttons in commit header

2016-05-26 11:19:11 +01:00

compare_helper.rb

Move helpers back to original directory

2015-09-09 14:37:34 +02:00

dashboard_helper.rb

Move helpers back to original directory

2015-09-09 14:37:34 +02:00

diff_helper.rb

Enable Style/RedundantParentheses rubocop cop

2016-05-30 15:07:18 +02:00

dropdowns_helper.rb

Added tests

2016-06-09 17:13:51 +01:00

emails_helper.rb

Syntax-highlight diffs in push emails

2016-05-17 13:23:17 +01:00

events_helper.rb

Remove event_to_atom helper

2016-05-23 12:37:40 -04:00

explore_helper.rb

Make projects sort dropdown shared so it can be reused for other pages

2016-03-04 19:26:10 +01:00

external_wiki_helper.rb

Fixed Rubocop offenses

2015-12-15 00:53:52 -02:00

form_helper.rb

Standardize the way we check for and display form errors

2016-04-04 21:37:07 -04:00

git_helper.rb

Move helpers back to original directory

2015-09-09 14:37:34 +02:00

gitlab_markdown_helper.rb

Hook up the updated WikiLinkFilter to the wiki controllers.

2016-06-09 10:15:01 +05:30

gitlab_routing_helper.rb

Fix CI tests

2016-05-12 13:03:04 -05:00

graph_helper.rb

Migrate CI::Project to Project

2015-12-11 18:02:09 +01:00

groups_helper.rb

Fix link to blank group icon

2016-06-02 11:19:27 +01:00

icons_helper.rb

audit log UI update

2016-03-02 17:06:01 +00:00

import_helper.rb

Fix GitHub project's link on import page when provider has a custom URL

2016-04-19 13:21:30 -03:00

issuables_helper.rb

Remove prev/next buttons on issues and merge requests

2016-06-06 12:01:50 -04:00

issues_helper.rb

Merge branch 'master' into awardables

2016-05-30 18:54:08 +02:00

javascript_helper.rb

Fix indentation

2016-06-01 19:42:49 -06:00

labels_helper.rb

Fixed failing tests

2016-06-09 17:19:14 +01:00

merge_requests_helper.rb

Refactor revert_commit_link helper.

2016-02-19 13:14:54 -05:00

milestones_helper.rb

Fixes for MR comments.

2016-06-09 00:04:46 +03:00

namespaces_helper.rb

hide help block when user is creating a new project inside a group

2016-04-12 14:41:34 +01:00

nav_helper.rb

Add back sidebar counters and username

2016-06-10 12:39:58 -05:00

notes_helper.rb

Extract LegacyDiffNote out of Note

2016-05-13 17:31:43 -05:00

notifications_helper.rb

Remove notification level fild from users, improve migrations and specs

2016-06-10 11:49:30 -03:00

page_layout_helper.rb

Implement top navigation concept for profile area

2016-04-19 20:05:30 +02:00

preferences_helper.rb

Implementing 'Groups View' and 'TODOs View' as options for dashboard preferences.

2016-03-24 19:59:54 +01:00

projects_helper.rb

Allow anonymous user to access pipelines

2016-05-23 01:31:51 +02:00

runners_helper.rb

Migrate CI::Project to Project

2015-12-11 18:02:09 +01:00

search_helper.rb

Codestyle: make sure we have space around operators

2016-05-13 04:46:56 -03:00

selects_helper.rb

Codestyle: make sure we have space around operators

2016-05-13 04:46:56 -03:00

snippets_helper.rb

Remove Snippet#expires_at

2016-03-05 18:12:17 -05:00

sorting_helper.rb

Sort by label priority

2016-06-06 11:59:49 -05:00

submodule_helper.rb

Move helpers back to original directory

2015-09-09 14:37:34 +02:00

tab_helper.rb

Use start_with? instead of regex

2016-05-24 00:23:23 +02:00

tags_helper.rb

Move helpers back to original directory

2015-09-09 14:37:34 +02:00

time_helper.rb

Refactor CI helpers

2015-09-29 16:26:40 +02:00

todos_helper.rb

Add tooltips to todo target links

2016-05-30 23:05:02 -04:00

tree_helper.rb

Add support to cherry-pick any commit

2016-04-18 15:39:07 +08:00

triggers_helper.rb

Reimplement Trigger API

2015-12-11 18:02:09 +01:00

version_check_helper.rb

Move the version_check_enabled check from view to helper

2015-09-23 16:28:51 -04:00

visibility_level_helper.rb

Address feedback

2016-03-22 00:09:20 +01:00

workhorse_helper.rb

Add send_git_diff helper

2016-06-08 14:30:15 +02:00