Files
gitlabhq/app/helpers
Douwe MaanandRémy Coutable 70ada081ed Merge branch 'rs-issue-15126' into 'master'
Remove persistent XSS vulnerability in `commit_person_link` helper

Because we were incorrectly supplying the tooltip title as
`data-original-title` (which Bootstrap's Tooltip JS automatically
applies based on the `title` attribute; we should never be setting it
directly), the value was being passed through as-is.

Instead, we should be supplying the normal `title` attribute and letting
Rails escape the value, which also negates the need for us to call
`sanitize` on it.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/15126

See merge request !1948

Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-04-19 17:24:13 +02:00
..
2015-12-11 18:02:09 +01:00
2016-03-15 16:24:51 +01:00
2015-12-15 00:53:52 -02:00
2015-12-11 18:02:09 +01:00
2016-03-02 17:06:01 +00:00
2016-02-18 16:16:32 -05:00
2016-03-05 18:12:17 -05:00
2015-09-29 16:26:40 +02:00
2015-12-11 18:02:09 +01:00