From 4757d3fa6018e356ca3f30d862acb2642edc6d92 Mon Sep 17 00:00:00 2001 From: Junwei Zhao Date: Wed, 6 Aug 2025 22:50:15 +1000 Subject: [PATCH] Update helm chart releasing logic --- .github/workflows/ci.yml | 3 ++- .github/workflows/helm-release.yml | 10 +++------- helm/passkey-auth/templates/NOTES.txt | 2 +- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9a76ee8..ebf7991 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -90,7 +90,8 @@ jobs: type=semver,pattern={{version}} type=semver,pattern={{major}}.{{minor}} type=semver,pattern={{major}} - type=sha,prefix={{branch}}- + type=sha,prefix={{branch}}-,enable=${{ github.ref_type == 'branch' }} + type=sha,enable=${{ github.ref_type == 'tag' }} type=raw,value=latest,enable={{is_default_branch}} labels: | org.opencontainers.image.title=Passkey Auth diff --git a/.github/workflows/helm-release.yml b/.github/workflows/helm-release.yml index b3c1d6b..d8eebf1 100644 --- a/.github/workflows/helm-release.yml +++ b/.github/workflows/helm-release.yml @@ -2,12 +2,8 @@ name: Release Helm Chart on: push: - branches: - - main - paths: - - 'helm/passkey-auth/**' - release: - types: [published] + tags: + - 'v*.*.*' permissions: contents: write @@ -63,7 +59,7 @@ jobs: release: needs: lint-test runs-on: ubuntu-latest - if: github.ref == 'refs/heads/main' || github.event_name == 'release' + if: startsWith(github.ref, 'refs/tags/v') steps: - name: Checkout uses: actions/checkout@v4 diff --git a/helm/passkey-auth/templates/NOTES.txt b/helm/passkey-auth/templates/NOTES.txt index 401b24f..5cb5578 100644 --- a/helm/passkey-auth/templates/NOTES.txt +++ b/helm/passkey-auth/templates/NOTES.txt @@ -30,7 +30,7 @@ 3. Visit the admin panel to manage users: {{- if .Values.ingress.enabled }} - http{{ if .Values.ingress.tls }}s{{ end }}://{{ (index .Values.ingress.hosts 0).host }}/admin + http{{ if .Values.ingress.tls }}s{{ end }}://{{ (index .Values.ingress.hosts 0).host }}/ {{- end }} Important Security Notes: