From 29cdecba8128805a955f39efee7dc5b6b4b3642d Mon Sep 17 00:00:00 2001 From: Woonduk Kang Date: Fri, 25 Sep 2015 15:50:37 +0900 Subject: [PATCH] remove unusedModifier --- .../bootstrap/async/AsyncTraceIdAccessor.java | 4 +-- .../pinpoint/bootstrap/config/Filter.java | 2 +- .../context/ServerMetaDataHolder.java | 4 +-- .../bootstrap/context/StackOperation.java | 4 +-- .../bootstrap/instrument/ClassFilter.java | 4 +-- .../bootstrap/instrument/Instrumentor.java | 14 +++++----- .../bootstrap/instrument/MethodFilter.java | 4 +-- .../PinpointClassFileTransformer.java | 2 +- .../interceptor/group/InterceptorGroup.java | 4 +-- .../plugin/ApplicationTypeDetector.java | 4 +-- .../plugin/ProfilerPluginSetupContext.java | 6 ++--- .../plugin/jdbc/BindValueAccessor.java | 4 +-- .../plugin/jdbc/DatabaseInfoAccessor.java | 4 +-- .../plugin/jdbc/ParsingResultAccessor.java | 4 +-- .../plugin/test/PluginTestVerifier.java | 26 +++++++++---------- .../resolver/condition/Condition.java | 2 +- .../resolver/condition/ConditionValue.java | 2 +- 17 files changed, 47 insertions(+), 47 deletions(-) diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/async/AsyncTraceIdAccessor.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/async/AsyncTraceIdAccessor.java index 6e9e6d7a4..effdbb2d7 100644 --- a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/async/AsyncTraceIdAccessor.java +++ b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/async/AsyncTraceIdAccessor.java @@ -21,6 +21,6 @@ import com.navercorp.pinpoint.bootstrap.context.AsyncTraceId; * */ public interface AsyncTraceIdAccessor { - public void _$PINPOINT$_setAsyncTraceId(AsyncTraceId id); - public AsyncTraceId _$PINPOINT$_getAsyncTraceId(); + void _$PINPOINT$_setAsyncTraceId(AsyncTraceId id); + AsyncTraceId _$PINPOINT$_getAsyncTraceId(); } diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/config/Filter.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/config/Filter.java index f7635d4fe..9cc185e23 100644 --- a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/config/Filter.java +++ b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/config/Filter.java @@ -20,7 +20,7 @@ package com.navercorp.pinpoint.bootstrap.config; * @author emeroad */ public interface Filter { - public static final boolean FILTERED = true; + boolean FILTERED = true; boolean filter(T value); } diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/context/ServerMetaDataHolder.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/context/ServerMetaDataHolder.java index a46ba77f9..9dd936122 100644 --- a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/context/ServerMetaDataHolder.java +++ b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/context/ServerMetaDataHolder.java @@ -35,9 +35,9 @@ public interface ServerMetaDataHolder { void publishServerMetaData(); - public interface ServerMetaDataListener { + interface ServerMetaDataListener { - public void publishServerMetaData(ServerMetaData serverMetaData); + void publishServerMetaData(ServerMetaData serverMetaData); } } diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/context/StackOperation.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/context/StackOperation.java index 243f1985d..e87b51263 100644 --- a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/context/StackOperation.java +++ b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/context/StackOperation.java @@ -20,9 +20,9 @@ package com.navercorp.pinpoint.bootstrap.context; * @author emeroad */ public interface StackOperation { - public static final int DEFAULT_STACKID = -1; + int DEFAULT_STACKID = -1; - public static final int ROOT_STACKID = 0; + int ROOT_STACKID = 0; SpanEventRecorder traceBlockBegin(); diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/instrument/ClassFilter.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/instrument/ClassFilter.java index 5af44b413..6ba5fa5d0 100644 --- a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/instrument/ClassFilter.java +++ b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/instrument/ClassFilter.java @@ -21,8 +21,8 @@ package com.navercorp.pinpoint.bootstrap.instrument; * @author jaehong.kim */ public interface ClassFilter { - public static final boolean ACCEPT = true; - public static final boolean REJECT = false; + boolean ACCEPT = true; + boolean REJECT = false; boolean accept(InstrumentClass clazz); } diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/instrument/Instrumentor.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/instrument/Instrumentor.java index 481e9156d..c06888aac 100644 --- a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/instrument/Instrumentor.java +++ b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/instrument/Instrumentor.java @@ -23,17 +23,17 @@ import com.navercorp.pinpoint.bootstrap.interceptor.group.InterceptorGroup; * */ public interface Instrumentor { - public TraceContext getTraceContext(); + TraceContext getTraceContext(); - public InstrumentClass getInstrumentClass(ClassLoader classLoader, String className, byte[] classfileBuffer); + InstrumentClass getInstrumentClass(ClassLoader classLoader, String className, byte[] classfileBuffer); - public boolean exist(ClassLoader classLoader, String className); + boolean exist(ClassLoader classLoader, String className); - public InterceptorGroup getInterceptorGroup(String name); + InterceptorGroup getInterceptorGroup(String name); - public Class injectClass(ClassLoader targetClassLoader, String className); + Class injectClass(ClassLoader targetClassLoader, String className); - public void addClassFileTransformer(ClassLoader classLoader, String targetClassName, PinpointClassFileTransformer transformer); + void addClassFileTransformer(ClassLoader classLoader, String targetClassName, PinpointClassFileTransformer transformer); - public void retransform(Class target, PinpointClassFileTransformer transformer); + void retransform(Class target, PinpointClassFileTransformer transformer); } diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/instrument/MethodFilter.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/instrument/MethodFilter.java index aaeb27953..6e49198f7 100644 --- a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/instrument/MethodFilter.java +++ b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/instrument/MethodFilter.java @@ -21,8 +21,8 @@ package com.navercorp.pinpoint.bootstrap.instrument; * @author emeroad */ public interface MethodFilter { - public static final boolean ACCEPT = true; - public static final boolean REJECT = false; + boolean ACCEPT = true; + boolean REJECT = false; boolean accept(InstrumentMethod method); } diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/instrument/transformer/PinpointClassFileTransformer.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/instrument/transformer/PinpointClassFileTransformer.java index 531f5f3ac..90c1e1907 100644 --- a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/instrument/transformer/PinpointClassFileTransformer.java +++ b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/instrument/transformer/PinpointClassFileTransformer.java @@ -23,5 +23,5 @@ import com.navercorp.pinpoint.bootstrap.instrument.Instrumentor; public interface PinpointClassFileTransformer { - public byte[] transform(Instrumentor instrumentor, ClassLoader classLoader, String className, Class classBeingRedefined, ProtectionDomain protectionDomain, byte[] classfileBuffer) throws InstrumentException; + byte[] transform(Instrumentor instrumentor, ClassLoader classLoader, String className, Class classBeingRedefined, ProtectionDomain protectionDomain, byte[] classfileBuffer) throws InstrumentException; } diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/interceptor/group/InterceptorGroup.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/interceptor/group/InterceptorGroup.java index 98e689e37..4180cd19d 100644 --- a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/interceptor/group/InterceptorGroup.java +++ b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/interceptor/group/InterceptorGroup.java @@ -20,6 +20,6 @@ package com.navercorp.pinpoint.bootstrap.interceptor.group; * */ public interface InterceptorGroup { - public String getName(); - public InterceptorGroupInvocation getCurrentInvocation(); + String getName(); + InterceptorGroupInvocation getCurrentInvocation(); } diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/ApplicationTypeDetector.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/ApplicationTypeDetector.java index dd91104ae..ca8c2aab5 100644 --- a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/ApplicationTypeDetector.java +++ b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/ApplicationTypeDetector.java @@ -32,7 +32,7 @@ public interface ApplicationTypeDetector { * @see ServiceType#isWas() * @see com.navercorp.pinpoint.common.trace.ServiceTypeCategory#SERVER */ - public ServiceType getApplicationType(); + ServiceType getApplicationType(); /** * Checks whether the provided conditions satisfy the requirements given by the plugins implementing this class. @@ -45,5 +45,5 @@ public interface ApplicationTypeDetector { * @return true if the provided conditions satisfy the requirements, false if otherwise * @see ConditionProvider */ - public boolean detect(ConditionProvider provider); + boolean detect(ConditionProvider provider); } diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/ProfilerPluginSetupContext.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/ProfilerPluginSetupContext.java index a32523d2d..6af0e0f4a 100644 --- a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/ProfilerPluginSetupContext.java +++ b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/ProfilerPluginSetupContext.java @@ -31,14 +31,14 @@ public interface ProfilerPluginSetupContext { * * @return {@link ProfilerConfig} */ - public ProfilerConfig getConfig(); + ProfilerConfig getConfig(); /** * Add a {@link ApplicationTypeDetector} to Pinpoint agent. * * @param detectors */ - public void addApplicationTypeDetector(ApplicationTypeDetector... detectors); + void addApplicationTypeDetector(ApplicationTypeDetector... detectors); - public void addClassFileTransformer(String targetClassName, PinpointClassFileTransformer transformer); + void addClassFileTransformer(String targetClassName, PinpointClassFileTransformer transformer); } diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/jdbc/BindValueAccessor.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/jdbc/BindValueAccessor.java index eb6b05270..4939e14a9 100644 --- a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/jdbc/BindValueAccessor.java +++ b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/jdbc/BindValueAccessor.java @@ -21,6 +21,6 @@ import java.util.Map; * */ public interface BindValueAccessor { - public void _$PINPOINT$_setBindValue(Map map); - public Map _$PINPOINT$_getBindValue(); + void _$PINPOINT$_setBindValue(Map map); + Map _$PINPOINT$_getBindValue(); } diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/jdbc/DatabaseInfoAccessor.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/jdbc/DatabaseInfoAccessor.java index 6d06b61da..eaaa289b0 100644 --- a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/jdbc/DatabaseInfoAccessor.java +++ b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/jdbc/DatabaseInfoAccessor.java @@ -21,6 +21,6 @@ import com.navercorp.pinpoint.bootstrap.context.DatabaseInfo; * */ public interface DatabaseInfoAccessor { - public void _$PINPOINT$_setDatabaseInfo(DatabaseInfo info); - public DatabaseInfo _$PINPOINT$_getDatabaseInfo(); + void _$PINPOINT$_setDatabaseInfo(DatabaseInfo info); + DatabaseInfo _$PINPOINT$_getDatabaseInfo(); } diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/jdbc/ParsingResultAccessor.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/jdbc/ParsingResultAccessor.java index a5ae784ba..955be245c 100644 --- a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/jdbc/ParsingResultAccessor.java +++ b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/jdbc/ParsingResultAccessor.java @@ -21,6 +21,6 @@ import com.navercorp.pinpoint.bootstrap.context.ParsingResult; * */ public interface ParsingResultAccessor { - public void _$PINPOINT$_setParsingResult(ParsingResult result); - public ParsingResult _$PINPOINT$_getParsingResult(); + void _$PINPOINT$_setParsingResult(ParsingResult result); + ParsingResult _$PINPOINT$_getParsingResult(); } diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/test/PluginTestVerifier.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/test/PluginTestVerifier.java index 5d2611ad6..12cd74ad9 100644 --- a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/test/PluginTestVerifier.java +++ b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/test/PluginTestVerifier.java @@ -26,17 +26,17 @@ import com.navercorp.pinpoint.common.trace.LoggingInfo; * */ public interface PluginTestVerifier { - public void verifyServerType(String expected); - public void verifyServerInfo(String expected); - public void verifyConnector(String protocol, int port); - public void verifyService(String context, List libs); - public void verifyTraceCount(int expected); - public void verifyTrace(ExpectedTrace... expectations); - public void verifyDiscreteTrace(ExpectedTrace... expectations); - public void ignoreServiceType(String... serviceTypes); - public void printCache(PrintStream out); - public void printCache(); - public void initialize(boolean initializeTraceObject); - public void cleanUp(boolean detachTraceObject); - public void verifyIsLoggingTransactionInfo(LoggingInfo loggingInfo); + void verifyServerType(String expected); + void verifyServerInfo(String expected); + void verifyConnector(String protocol, int port); + void verifyService(String context, List libs); + void verifyTraceCount(int expected); + void verifyTrace(ExpectedTrace... expectations); + void verifyDiscreteTrace(ExpectedTrace... expectations); + void ignoreServiceType(String... serviceTypes); + void printCache(PrintStream out); + void printCache(); + void initialize(boolean initializeTraceObject); + void cleanUp(boolean detachTraceObject); + void verifyIsLoggingTransactionInfo(LoggingInfo loggingInfo); } diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/resolver/condition/Condition.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/resolver/condition/Condition.java index 51f0e5531..33a52e0c8 100644 --- a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/resolver/condition/Condition.java +++ b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/resolver/condition/Condition.java @@ -21,6 +21,6 @@ package com.navercorp.pinpoint.bootstrap.resolver.condition; */ public interface Condition { - public boolean check(T condition); + boolean check(T condition); } diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/resolver/condition/ConditionValue.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/resolver/condition/ConditionValue.java index d05d274bb..06bbbc7e4 100644 --- a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/resolver/condition/ConditionValue.java +++ b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/resolver/condition/ConditionValue.java @@ -21,6 +21,6 @@ package com.navercorp.pinpoint.bootstrap.resolver.condition; */ public interface ConditionValue { - public V getValue(); + V getValue(); }