From fb3b0ad239d78ee9d275c97114969105edfb6360 Mon Sep 17 00:00:00 2001 From: Woonduk Kang Date: Thu, 18 Dec 2014 11:45:16 +0900 Subject: [PATCH] #119 code clean-up - findbug, pmd, klocwork warning --- .../bootstrap/config/ProfilerConfig.java | 13 +++---- .../DatabaseInfoTraceValueUtils.java | 5 ++- .../bootstrap/logging/LoggingUtils.java | 4 ++- .../bootstrap/plugin/BytecodeUtils.java | 36 ++++++++++--------- .../bootstrap/plugin/ClassEditorBuilder.java | 2 +- .../pinpoint/bootstrap/plugin/TypeUtils.java | 6 +++- .../bootstrap/util/IdValidateUtils.java | 3 +- .../zookeeper/ZookeeperWebClusterManager.java | 12 +++---- .../receiver/AbstractDispatchHandler.java | 2 +- .../pinpoint/collector/util/PacketUtils.java | 4 ++- .../pinpoint/common/bo/ApiMetaDataBo.java | 10 +++--- .../pinpoint/common/bo/SqlMetaDataBo.java | 9 +++-- .../pinpoint/common/bo/StringMetaDataBo.java | 10 +++--- .../pinpoint/common/util/AnnotationUtils.java | 4 ++- .../util/ApplicationMapStatisticsUtils.java | 2 ++ .../pinpoint/common/util/BytesUtils.java | 2 ++ .../common/util/ClassLoaderUtils.java | 3 ++ .../pinpoint/common/util/ClassUtils.java | 7 ++-- .../pinpoint/common/util/HttpUtils.java | 5 ++- .../pinpoint/common/util/JvmUtils.java | 3 +- .../pinpoint/common/util/PropertyUtils.java | 31 ++++++++-------- .../pinpoint/common/util/RowKeyUtils.java | 6 ++-- .../pinpoint/common/util/SpanEventUtils.java | 8 ++++- .../pinpoint/common/util/SpanUtils.java | 5 ++- .../pinpoint/common/util/TimeUtils.java | 2 ++ .../common/util/TransactionIdUtils.java | 3 ++ .../profiler/logging/Slf4jPLoggerAdapter.java | 1 - .../modifier/arcus/ParameterUtils.java | 5 ++- ...racleNetConnectionDescriptorTokenizer.java | 2 -- .../profiler/util/AnnotationValueMapper.java | 1 - .../profiler/util/ErrorInjectUtils.java | 6 +++- .../profiler/util/PreparedStatementUtils.java | 5 ++- .../profiler/util/RuntimeMXBeanUtils.java | 6 +++- .../pinpoint/profiler/util/SystemUtils.java | 6 ++-- .../pinpoint/profiler/util/LoaderUtils.java | 3 ++ .../rpc/client/PinpointSocketHandler.java | 2 +- .../rpc/control/ControlMessageEncoder.java | 8 ++--- .../rpc/util/ControlMessageEncodingUtils.java | 2 +- .../navercorp/pinpoint/rpc/util/MapUtils.java | 2 +- .../navercorp/pinpoint/rpc/TestByteUtils.java | 5 ++- .../pinpoint/thrift/io/BytesUtils.java | 6 +++- .../pinpoint/thrift/io/HeaderUtils.java | 3 ++ .../pinpoint/web/dao/ibatis/SqlUtils.java | 5 ++- .../pinpoint/web/util/LimitUtils.java | 3 ++ .../pinpoint/web/util/TimeUtils.java | 3 ++ 45 files changed, 172 insertions(+), 99 deletions(-) diff --git a/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/config/ProfilerConfig.java b/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/config/ProfilerConfig.java index 3041e8702..26fad5a46 100644 --- a/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/config/ProfilerConfig.java +++ b/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/config/ProfilerConfig.java @@ -17,6 +17,7 @@ import java.util.logging.Logger; */ public class ProfilerConfig { private static final Logger logger = Logger.getLogger(ProfilerConfig.class.getName()); + private static final String DEFAULT_IP = "127.0.0.1"; private final Properties properties; private final PropertyPlaceholderHelper propertyPlaceholderHelper = new PropertyPlaceholderHelper("${", "}"); @@ -63,13 +64,13 @@ public class ProfilerConfig { private boolean profileEnable = false; - private String collectorSpanServerIp = "127.0.0.1"; + private String collectorSpanServerIp = DEFAULT_IP; private int collectorSpanServerPort = 9996; - private String collectorStatServerIp = "127.0.0.1"; + private String collectorStatServerIp = DEFAULT_IP; private int collectorStatServerPort = 9995; - private String collectorTcpServerIp = "127.0.0.1"; + private String collectorTcpServerIp = DEFAULT_IP; private int collectorTcpServerPort = 9994; private int spanDataSenderWriteQueueSize = 1024 * 5; @@ -564,13 +565,13 @@ public class ProfilerConfig { this.profileEnable = readBoolean("profiler.enable", true); - this.collectorSpanServerIp = readString("profiler.collector.span.ip", "127.0.0.1", placeHolderResolver); + this.collectorSpanServerIp = readString("profiler.collector.span.ip", DEFAULT_IP, placeHolderResolver); this.collectorSpanServerPort = readInt("profiler.collector.span.port", 9996); - this.collectorStatServerIp = readString("profiler.collector.stat.ip", "127.0.0.1", placeHolderResolver); + this.collectorStatServerIp = readString("profiler.collector.stat.ip", DEFAULT_IP, placeHolderResolver); this.collectorStatServerPort = readInt("profiler.collector.stat.port", 9995); - this.collectorTcpServerIp = readString("profiler.collector.tcp.ip", "127.0.0.1", placeHolderResolver); + this.collectorTcpServerIp = readString("profiler.collector.tcp.ip", DEFAULT_IP, placeHolderResolver); this.collectorTcpServerPort = readInt("profiler.collector.tcp.port", 9994); this.spanDataSenderWriteQueueSize = readInt("profiler.spandatasender.write.queue.size", 1024 * 5); diff --git a/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/interceptor/tracevalue/DatabaseInfoTraceValueUtils.java b/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/interceptor/tracevalue/DatabaseInfoTraceValueUtils.java index 097667c3b..71c7c88ce 100644 --- a/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/interceptor/tracevalue/DatabaseInfoTraceValueUtils.java +++ b/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/interceptor/tracevalue/DatabaseInfoTraceValueUtils.java @@ -5,7 +5,10 @@ import com.navercorp.pinpoint.bootstrap.context.DatabaseInfo; /** * @author emeroad */ -public class DatabaseInfoTraceValueUtils { +public final class DatabaseInfoTraceValueUtils { + + private DatabaseInfoTraceValueUtils() { + } public static DatabaseInfo __getTraceDatabaseInfo(Object target, DatabaseInfo defaultValue) { if (target == null) { diff --git a/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/logging/LoggingUtils.java b/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/logging/LoggingUtils.java index 82b9a3e48..fb8d335b0 100644 --- a/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/logging/LoggingUtils.java +++ b/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/logging/LoggingUtils.java @@ -5,8 +5,10 @@ import java.util.Arrays; /** * @author emeroad */ -public class LoggingUtils { +public final class LoggingUtils { + private LoggingUtils() { + } public static void logBefore(PLogger logger, Object target, String className, String methodName, String parameterDescription, Object[] args) { StringBuilder sb = new StringBuilder(512); diff --git a/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/BytecodeUtils.java b/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/BytecodeUtils.java index 037f9c4a2..ca321695e 100644 --- a/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/BytecodeUtils.java +++ b/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/BytecodeUtils.java @@ -8,29 +8,31 @@ import java.nio.ByteBuffer; import java.nio.channels.Channels; import java.nio.channels.ReadableByteChannel; -public abstract class BytecodeUtils { - private BytecodeUtils() { } +public final class BytecodeUtils { - private static final Method DEFINE_CLASS; - - static { - Method method = null; - + private static final Method DEFINE_CLASS = getDefineClassMethod(); + + private BytecodeUtils() { + } + + + private static Method getDefineClassMethod() { try { - method = ClassLoader.class.getDeclaredMethod("defineClass", String.class, byte[].class, int.class, int.class); + final Method method = ClassLoader.class.getDeclaredMethod("defineClass", String.class, byte[].class, int.class, int.class); method.setAccessible(true); + return method; } catch (NoSuchMethodException e) { - e.printStackTrace(); + // link error + throw new RuntimeException("defineClass not found. Caused:" + e.getMessage(), e); } catch (SecurityException e) { - e.printStackTrace(); + // link error + throw new RuntimeException("defineClass error. Caused:" + e.getMessage(), e); } - - DEFINE_CLASS = method; } public static Class defineClass(ClassLoader classLoader, String className, byte[] classFile) { try { - return (Class)DEFINE_CLASS.invoke(classLoader, className, classFile, 0, classFile.length); + return (Class) DEFINE_CLASS.invoke(classLoader, className, classFile, 0, classFile.length); } catch (Exception e) { return null; } @@ -48,13 +50,13 @@ public abstract class BytecodeUtils { if (is == null) { throw new RuntimeException("No such class file: " + className); } - + ReadableByteChannel channel = Channels.newChannel(is); ByteBuffer buffer; - + try { buffer = ByteBuffer.allocate(is.available()); - + while (channel.read(buffer) >= 0) { if (buffer.remaining() == 0) { buffer.flip(); @@ -68,7 +70,7 @@ public abstract class BytecodeUtils { } finally { close(is); } - + return buffer.array(); } diff --git a/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/ClassEditorBuilder.java b/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/ClassEditorBuilder.java index 7a08401d5..27231f57f 100644 --- a/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/ClassEditorBuilder.java +++ b/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/ClassEditorBuilder.java @@ -130,7 +130,7 @@ public class ClassEditorBuilder { } } - public class MetadataBuilder { + public static class MetadataBuilder { private String metadataAccessorTypeName; private MetadataInitializationStrategy initializationStrategy; diff --git a/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/TypeUtils.java b/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/TypeUtils.java index 29128e9d5..fd8c527d7 100644 --- a/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/TypeUtils.java +++ b/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/TypeUtils.java @@ -1,6 +1,10 @@ package com.navercorp.pinpoint.bootstrap.plugin; -public abstract class TypeUtils { +public final class TypeUtils { + + private TypeUtils() { + } + public static Class getWrapperOf(Class primitive) { if (primitive == boolean.class) { return Boolean.class; diff --git a/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/util/IdValidateUtils.java b/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/util/IdValidateUtils.java index 8ed07d385..e30b76978 100644 --- a/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/util/IdValidateUtils.java +++ b/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/util/IdValidateUtils.java @@ -3,14 +3,13 @@ package com.navercorp.pinpoint.bootstrap.util; import com.navercorp.pinpoint.common.PinpointConstants; import com.navercorp.pinpoint.common.util.BytesUtils; -import java.io.UnsupportedEncodingException; import java.util.regex.Matcher; import java.util.regex.Pattern; /** * @author emeroad */ -public class IdValidateUtils { +public final class IdValidateUtils { private static final int DEFAULT_MAX_LENGTH = PinpointConstants.AGENT_NAME_MAX_LEN; diff --git a/collector/src/main/java/com/navercorp/pinpoint/collector/cluster/zookeeper/ZookeeperWebClusterManager.java b/collector/src/main/java/com/navercorp/pinpoint/collector/cluster/zookeeper/ZookeeperWebClusterManager.java index b5f0988d9..671a1e6fc 100644 --- a/collector/src/main/java/com/navercorp/pinpoint/collector/cluster/zookeeper/ZookeeperWebClusterManager.java +++ b/collector/src/main/java/com/navercorp/pinpoint/collector/cluster/zookeeper/ZookeeperWebClusterManager.java @@ -97,9 +97,12 @@ public class ZookeeperWebClusterManager implements Runnable { logger.info("{} destorying started.", this.getClass().getSimpleName()); - queue.offer(stopTask); + final boolean stopOffer = queue.offer(stopTask); + if (!stopOffer) { + logger.warn("stopTask offer fail. Message Queue."); + } - boolean interrupted = false; + boolean interrupted = false; while (this.workerThread.isAlive()) { this.workerThread.interrupt(); try { @@ -112,7 +115,6 @@ public class ZookeeperWebClusterManager implements Runnable { this.workerState.changeStateStoped(); logger.info("{} destorying completed.", this.getClass().getSimpleName()); - return; } // NoNode인 경우 Node생성후 재 호출 @@ -121,8 +123,7 @@ public class ZookeeperWebClusterManager implements Runnable { public void handleAndRegisterWatcher(String path) { if (workerState.isStarted()) { if (zNodePath.equals(path)) { - boolean offerSuccess = queue.offer(getAndRegisterTask); - + final boolean offerSuccess = queue.offer(getAndRegisterTask); if (!offerSuccess) { logger.info("Message Queue is Full."); } @@ -132,7 +133,6 @@ public class ZookeeperWebClusterManager implements Runnable { } else { WorkerState state = this.workerState.getCurrentState(); logger.info("{} invalid state {}.", this.getClass().getSimpleName(), state.toString()); - return; } } diff --git a/collector/src/main/java/com/navercorp/pinpoint/collector/receiver/AbstractDispatchHandler.java b/collector/src/main/java/com/navercorp/pinpoint/collector/receiver/AbstractDispatchHandler.java index dc020ef3a..6e7b8032a 100644 --- a/collector/src/main/java/com/navercorp/pinpoint/collector/receiver/AbstractDispatchHandler.java +++ b/collector/src/main/java/com/navercorp/pinpoint/collector/receiver/AbstractDispatchHandler.java @@ -51,7 +51,7 @@ public abstract class AbstractDispatchHandler implements DispatchHandler { throw new UnsupportedOperationException("Handler not found. Unknown type of data received. tBase=" + tBase); } - public TBase dispatchRequestMessage(org.apache.thrift.TBase tBase, byte[] packet, int offset, int length) { + public TBase dispatchRequestMessage(TBase tBase, byte[] packet, int offset, int length) { // accepted time 마크 acceptedTimeService.accept(); diff --git a/collector/src/main/java/com/navercorp/pinpoint/collector/util/PacketUtils.java b/collector/src/main/java/com/navercorp/pinpoint/collector/util/PacketUtils.java index 10920755b..d0a78b626 100644 --- a/collector/src/main/java/com/navercorp/pinpoint/collector/util/PacketUtils.java +++ b/collector/src/main/java/com/navercorp/pinpoint/collector/util/PacketUtils.java @@ -7,7 +7,9 @@ import java.net.DatagramPacket; /** * @author emeroad */ -public class PacketUtils { +public final class PacketUtils { + private PacketUtils() { + } public static String dumpDatagramPacket(DatagramPacket datagramPacket) { if (datagramPacket == null) { diff --git a/commons/src/main/java/com/navercorp/pinpoint/common/bo/ApiMetaDataBo.java b/commons/src/main/java/com/navercorp/pinpoint/common/bo/ApiMetaDataBo.java index 446d5a97d..77c845c2f 100644 --- a/commons/src/main/java/com/navercorp/pinpoint/common/bo/ApiMetaDataBo.java +++ b/commons/src/main/java/com/navercorp/pinpoint/common/bo/ApiMetaDataBo.java @@ -1,14 +1,12 @@ package com.navercorp.pinpoint.common.bo; +import com.navercorp.pinpoint.common.PinpointConstants; import com.navercorp.pinpoint.common.util.BytesUtils; import com.navercorp.pinpoint.common.util.RowKeyUtils; import com.navercorp.pinpoint.common.util.TimeUtils; import org.apache.hadoop.hbase.util.Bytes; -import static com.navercorp.pinpoint.common.PinpointConstants.*; -import static com.navercorp.pinpoint.common.util.BytesUtils.*; - /** * @author emeroad */ @@ -76,17 +74,17 @@ public class ApiMetaDataBo { } public void readRowKey(byte[] bytes) { - this.agentId = Bytes.toString(bytes, 0, AGENT_NAME_MAX_LEN).trim(); + this.agentId = Bytes.toString(bytes, 0, PinpointConstants.AGENT_NAME_MAX_LEN).trim(); this.startTime = TimeUtils.recoveryTimeMillis(readTime(bytes)); this.apiId = readKeyCode(bytes); } private static long readTime(byte[] rowKey) { - return BytesUtils.bytesToLong(rowKey, AGENT_NAME_MAX_LEN); + return BytesUtils.bytesToLong(rowKey, PinpointConstants.AGENT_NAME_MAX_LEN); } private static int readKeyCode(byte[] rowKey) { - return BytesUtils.bytesToInt(rowKey, AGENT_NAME_MAX_LEN + LONG_BYTE_LENGTH); + return BytesUtils.bytesToInt(rowKey, PinpointConstants.AGENT_NAME_MAX_LEN + BytesUtils.LONG_BYTE_LENGTH); } public byte[] toRowKey() { diff --git a/commons/src/main/java/com/navercorp/pinpoint/common/bo/SqlMetaDataBo.java b/commons/src/main/java/com/navercorp/pinpoint/common/bo/SqlMetaDataBo.java index db3b82e4d..2763845b0 100644 --- a/commons/src/main/java/com/navercorp/pinpoint/common/bo/SqlMetaDataBo.java +++ b/commons/src/main/java/com/navercorp/pinpoint/common/bo/SqlMetaDataBo.java @@ -1,13 +1,12 @@ package com.navercorp.pinpoint.common.bo; +import com.navercorp.pinpoint.common.PinpointConstants; import com.navercorp.pinpoint.common.util.BytesUtils; import com.navercorp.pinpoint.common.util.RowKeyUtils; import com.navercorp.pinpoint.common.util.TimeUtils; import org.apache.hadoop.hbase.util.Bytes; -import static com.navercorp.pinpoint.common.PinpointConstants.*; -import static com.navercorp.pinpoint.common.util.BytesUtils.*; /** * @author emeroad @@ -67,18 +66,18 @@ public class SqlMetaDataBo { } public void readRowKey(byte[] rowKey) { - this.agentId = Bytes.toString(rowKey, 0, AGENT_NAME_MAX_LEN).trim(); + this.agentId = Bytes.toString(rowKey, 0, PinpointConstants.AGENT_NAME_MAX_LEN).trim(); this.startTime = TimeUtils.recoveryTimeMillis(readTime(rowKey)); this.hashCode = readKeyCode(rowKey); } private static long readTime(byte[] rowKey) { - return BytesUtils.bytesToLong(rowKey, AGENT_NAME_MAX_LEN); + return BytesUtils.bytesToLong(rowKey, PinpointConstants.AGENT_NAME_MAX_LEN); } private static int readKeyCode(byte[] rowKey) { - return BytesUtils.bytesToInt(rowKey, AGENT_NAME_MAX_LEN + LONG_BYTE_LENGTH); + return BytesUtils.bytesToInt(rowKey, PinpointConstants.AGENT_NAME_MAX_LEN + BytesUtils.LONG_BYTE_LENGTH); } public byte[] toRowKey() { diff --git a/commons/src/main/java/com/navercorp/pinpoint/common/bo/StringMetaDataBo.java b/commons/src/main/java/com/navercorp/pinpoint/common/bo/StringMetaDataBo.java index 5cf995ac9..7ee1aad73 100644 --- a/commons/src/main/java/com/navercorp/pinpoint/common/bo/StringMetaDataBo.java +++ b/commons/src/main/java/com/navercorp/pinpoint/common/bo/StringMetaDataBo.java @@ -1,14 +1,12 @@ package com.navercorp.pinpoint.common.bo; +import com.navercorp.pinpoint.common.PinpointConstants; import com.navercorp.pinpoint.common.util.BytesUtils; import com.navercorp.pinpoint.common.util.RowKeyUtils; import com.navercorp.pinpoint.common.util.TimeUtils; import org.apache.hadoop.hbase.util.Bytes; -import static com.navercorp.pinpoint.common.PinpointConstants.*; -import static com.navercorp.pinpoint.common.util.BytesUtils.*; - /** * @author emeroad */ @@ -67,18 +65,18 @@ public class StringMetaDataBo { } public void readRowKey(byte[] rowKey) { - this.agentId = Bytes.toString(rowKey, 0, AGENT_NAME_MAX_LEN).trim(); + this.agentId = Bytes.toString(rowKey, 0, PinpointConstants.AGENT_NAME_MAX_LEN).trim(); this.startTime = TimeUtils.recoveryTimeMillis(readTime(rowKey)); this.stringId = readKeyCode(rowKey); } private static long readTime(byte[] rowKey) { - return BytesUtils.bytesToLong(rowKey, AGENT_NAME_MAX_LEN); + return BytesUtils.bytesToLong(rowKey, PinpointConstants.AGENT_NAME_MAX_LEN); } private static int readKeyCode(byte[] rowKey) { - return BytesUtils.bytesToInt(rowKey, AGENT_NAME_MAX_LEN + LONG_BYTE_LENGTH); + return BytesUtils.bytesToInt(rowKey, PinpointConstants.AGENT_NAME_MAX_LEN + BytesUtils.LONG_BYTE_LENGTH); } public byte[] toRowKey() { diff --git a/commons/src/main/java/com/navercorp/pinpoint/common/util/AnnotationUtils.java b/commons/src/main/java/com/navercorp/pinpoint/common/util/AnnotationUtils.java index c7fa1fb6e..006ecc0cc 100644 --- a/commons/src/main/java/com/navercorp/pinpoint/common/util/AnnotationUtils.java +++ b/commons/src/main/java/com/navercorp/pinpoint/common/util/AnnotationUtils.java @@ -10,7 +10,9 @@ import com.navercorp.pinpoint.common.bo.Span; /** * @author emeroad */ -public class AnnotationUtils { +public final class AnnotationUtils { + private AnnotationUtils() { + } public static String findApiAnnotation(List list) { if (list == null) { diff --git a/commons/src/main/java/com/navercorp/pinpoint/common/util/ApplicationMapStatisticsUtils.java b/commons/src/main/java/com/navercorp/pinpoint/common/util/ApplicationMapStatisticsUtils.java index 2b8befb0c..9025f910b 100644 --- a/commons/src/main/java/com/navercorp/pinpoint/common/util/ApplicationMapStatisticsUtils.java +++ b/commons/src/main/java/com/navercorp/pinpoint/common/util/ApplicationMapStatisticsUtils.java @@ -19,6 +19,8 @@ import org.apache.hadoop.hbase.util.Bytes; * @author emeroad */ public class ApplicationMapStatisticsUtils { + private ApplicationMapStatisticsUtils() { + } public static byte[] makeColumnName(short serviceType, String applicationName, String destHost, short slotNumber) { if (applicationName == null) { diff --git a/commons/src/main/java/com/navercorp/pinpoint/common/util/BytesUtils.java b/commons/src/main/java/com/navercorp/pinpoint/common/util/BytesUtils.java index 42e328933..f9d56f421 100644 --- a/commons/src/main/java/com/navercorp/pinpoint/common/util/BytesUtils.java +++ b/commons/src/main/java/com/navercorp/pinpoint/common/util/BytesUtils.java @@ -21,6 +21,8 @@ public final class BytesUtils { private static final String UTF8 = "UTF-8"; private static final Logger LOGGER = Logger.getLogger(BytesUtils.class.getName()); + private BytesUtils() { + } public static byte[] stringLongLongToBytes(final String string, final int maxStringSize, final long value1, final long value2) { if (string == null) { diff --git a/commons/src/main/java/com/navercorp/pinpoint/common/util/ClassLoaderUtils.java b/commons/src/main/java/com/navercorp/pinpoint/common/util/ClassLoaderUtils.java index 288657397..025f9445a 100644 --- a/commons/src/main/java/com/navercorp/pinpoint/common/util/ClassLoaderUtils.java +++ b/commons/src/main/java/com/navercorp/pinpoint/common/util/ClassLoaderUtils.java @@ -12,6 +12,9 @@ public final class ClassLoaderUtils { } }; + private ClassLoaderUtils() { + } + public static ClassLoader getDefaultClassLoader() { return getDefaultClassLoader(DEFAULT_CLASS_LOADER_CALLABLE); } diff --git a/commons/src/main/java/com/navercorp/pinpoint/common/util/ClassUtils.java b/commons/src/main/java/com/navercorp/pinpoint/common/util/ClassUtils.java index f9e24d0ea..84a55b417 100644 --- a/commons/src/main/java/com/navercorp/pinpoint/common/util/ClassUtils.java +++ b/commons/src/main/java/com/navercorp/pinpoint/common/util/ClassUtils.java @@ -3,11 +3,14 @@ package com.navercorp.pinpoint.common.util; /** * @author hyungil.jeong */ -public class ClassUtils { +public final class ClassUtils { private static final Object CLASS_NOT_LOADED = null; private static final char PACKAGE_SEPARATOR = '.'; - + + private ClassUtils() { + } + public static boolean isLoaded(String name) { return isLoaded(name, ClassLoaderUtils.getDefaultClassLoader()); } diff --git a/commons/src/main/java/com/navercorp/pinpoint/common/util/HttpUtils.java b/commons/src/main/java/com/navercorp/pinpoint/common/util/HttpUtils.java index 5a219fe5a..6117c90a1 100644 --- a/commons/src/main/java/com/navercorp/pinpoint/common/util/HttpUtils.java +++ b/commons/src/main/java/com/navercorp/pinpoint/common/util/HttpUtils.java @@ -3,12 +3,15 @@ package com.navercorp.pinpoint.common.util; /** * @author emeroad */ -public class HttpUtils { +public final class HttpUtils { private static final String UTF8 = "UTF-8"; private static final String CHARSET = "charset="; + private HttpUtils() { + } + public static String parseContentTypeCharset(String contentType) { return parseContentTypeCharset(contentType, UTF8); } diff --git a/commons/src/main/java/com/navercorp/pinpoint/common/util/JvmUtils.java b/commons/src/main/java/com/navercorp/pinpoint/common/util/JvmUtils.java index bbf991a17..df42333b5 100644 --- a/commons/src/main/java/com/navercorp/pinpoint/common/util/JvmUtils.java +++ b/commons/src/main/java/com/navercorp/pinpoint/common/util/JvmUtils.java @@ -7,14 +7,13 @@ import java.util.Map; /** * @author hyungil.jeong */ -public class JvmUtils { +public final class JvmUtils { private static final RuntimeMXBean RUNTIME_MX_BEAN = ManagementFactory.getRuntimeMXBean(); private static final Map SYSTEM_PROPERTIES = RUNTIME_MX_BEAN.getSystemProperties(); private static final JvmVersion JVM_VERSION = _getVersion(); private JvmUtils() { - throw new IllegalAccessError(); } public static JvmVersion getVersion() { diff --git a/commons/src/main/java/com/navercorp/pinpoint/common/util/PropertyUtils.java b/commons/src/main/java/com/navercorp/pinpoint/common/util/PropertyUtils.java index 8db9f2410..91e9a9eb4 100644 --- a/commons/src/main/java/com/navercorp/pinpoint/common/util/PropertyUtils.java +++ b/commons/src/main/java/com/navercorp/pinpoint/common/util/PropertyUtils.java @@ -6,7 +6,7 @@ import java.util.Properties; /** * @author emeroad */ -public class PropertyUtils { +public final class PropertyUtils { public static final String DEFAULT_ENCODING = "UTF-8"; private static final ClassLoaderUtils.ClassLoaderCallable CLASS_LOADER_CALLABLE = new ClassLoaderUtils.ClassLoaderCallable() { @@ -20,6 +20,9 @@ public class PropertyUtils { InputStream openInputStream() throws IOException; } + private PropertyUtils() { + } + public static Properties loadProperty(final String filePath) throws IOException { if (filePath == null) { throw new NullPointerException("filePath must not be null"); @@ -31,7 +34,7 @@ public class PropertyUtils { } }; return loadProperty(new Properties(), inputStreamFactory, DEFAULT_ENCODING); - } + } public static Properties loadPropertyFromClassPath(final String classPath) throws IOException { if (classPath == null) { @@ -46,18 +49,18 @@ public class PropertyUtils { return loadProperty(new Properties(), inputStreamFactory, DEFAULT_ENCODING); } - public static Properties loadPropertyFromClassLoader(final ClassLoader classLoader, final String classPath) throws IOException { - if (classLoader == null) { - throw new NullPointerException("classLoader must not be null"); - } - final InputStreamFactory inputStreamFactory = new InputStreamFactory() { - @Override - public InputStream openInputStream() throws IOException { - return classLoader.getResourceAsStream(classPath); - } - }; - return loadProperty(new Properties(), inputStreamFactory, DEFAULT_ENCODING); - } + public static Properties loadPropertyFromClassLoader(final ClassLoader classLoader, final String classPath) throws IOException { + if (classLoader == null) { + throw new NullPointerException("classLoader must not be null"); + } + final InputStreamFactory inputStreamFactory = new InputStreamFactory() { + @Override + public InputStream openInputStream() throws IOException { + return classLoader.getResourceAsStream(classPath); + } + }; + return loadProperty(new Properties(), inputStreamFactory, DEFAULT_ENCODING); + } public static Properties loadProperty(Properties properties, InputStreamFactory inputStreamFactory, String encoding) throws IOException { diff --git a/commons/src/main/java/com/navercorp/pinpoint/common/util/RowKeyUtils.java b/commons/src/main/java/com/navercorp/pinpoint/common/util/RowKeyUtils.java index ba79f88d5..b71f62606 100644 --- a/commons/src/main/java/com/navercorp/pinpoint/common/util/RowKeyUtils.java +++ b/commons/src/main/java/com/navercorp/pinpoint/common/util/RowKeyUtils.java @@ -8,9 +8,11 @@ import org.apache.hadoop.hbase.util.Bytes; /** * @author emeroad */ -public class RowKeyUtils { +public final class RowKeyUtils { + private RowKeyUtils() { + } - public static byte[] concatFixedByteAndLong(byte[] fixedBytes, int maxFixedLength, long l) { + public static byte[] concatFixedByteAndLong(byte[] fixedBytes, int maxFixedLength, long l) { if (fixedBytes == null) { throw new NullPointerException("fixedBytes must not null"); } diff --git a/commons/src/main/java/com/navercorp/pinpoint/common/util/SpanEventUtils.java b/commons/src/main/java/com/navercorp/pinpoint/common/util/SpanEventUtils.java index 3de30534a..0dbcd297c 100644 --- a/commons/src/main/java/com/navercorp/pinpoint/common/util/SpanEventUtils.java +++ b/commons/src/main/java/com/navercorp/pinpoint/common/util/SpanEventUtils.java @@ -6,9 +6,15 @@ import com.navercorp.pinpoint.thrift.dto.TSpanEvent; /** * @author emeroad */ -public class SpanEventUtils { +public final class SpanEventUtils { + + private SpanEventUtils() { + } public static boolean hasException(TSpanEvent spanEvent) { + if (spanEvent == null) { + throw new NullPointerException("spanEvent must not be null"); + } if (spanEvent.isSetExceptionInfo()) { return true; } diff --git a/commons/src/main/java/com/navercorp/pinpoint/common/util/SpanUtils.java b/commons/src/main/java/com/navercorp/pinpoint/common/util/SpanUtils.java index 5da6d0d55..4c75bf6f9 100644 --- a/commons/src/main/java/com/navercorp/pinpoint/common/util/SpanUtils.java +++ b/commons/src/main/java/com/navercorp/pinpoint/common/util/SpanUtils.java @@ -10,7 +10,10 @@ import com.navercorp.pinpoint.thrift.dto.TSpanChunk; /** * @author emeroad */ -public class SpanUtils { +public final class SpanUtils { + private SpanUtils() { + } + @Deprecated public static byte[] getAgentIdTraceIndexRowKey(String agentId, long timestamp) { if (agentId == null) { diff --git a/commons/src/main/java/com/navercorp/pinpoint/common/util/TimeUtils.java b/commons/src/main/java/com/navercorp/pinpoint/common/util/TimeUtils.java index 4d44e1def..c98f4b4ce 100644 --- a/commons/src/main/java/com/navercorp/pinpoint/common/util/TimeUtils.java +++ b/commons/src/main/java/com/navercorp/pinpoint/common/util/TimeUtils.java @@ -4,6 +4,8 @@ package com.navercorp.pinpoint.common.util; * @author emeroad */ public final class TimeUtils { + private TimeUtils() { + } public static long reverseTimeMillis(long currentTimeMillis) { return Long.MAX_VALUE - currentTimeMillis; diff --git a/commons/src/main/java/com/navercorp/pinpoint/common/util/TransactionIdUtils.java b/commons/src/main/java/com/navercorp/pinpoint/common/util/TransactionIdUtils.java index 961ab38f7..019d27b47 100644 --- a/commons/src/main/java/com/navercorp/pinpoint/common/util/TransactionIdUtils.java +++ b/commons/src/main/java/com/navercorp/pinpoint/common/util/TransactionIdUtils.java @@ -12,6 +12,9 @@ public final class TransactionIdUtils { public static final String TRANSACTION_ID_DELIMITER = "^"; public static final byte VERSION = 0; + private TransactionIdUtils() { + } + public static String formatString(String agentId, long agentStartTime, long transactionSequence) { if (agentId == null) { throw new NullPointerException("agentId must not be null"); diff --git a/profiler/src/main/java/com/navercorp/pinpoint/profiler/logging/Slf4jPLoggerAdapter.java b/profiler/src/main/java/com/navercorp/pinpoint/profiler/logging/Slf4jPLoggerAdapter.java index 1d3eaada4..76ca2dff6 100644 --- a/profiler/src/main/java/com/navercorp/pinpoint/profiler/logging/Slf4jPLoggerAdapter.java +++ b/profiler/src/main/java/com/navercorp/pinpoint/profiler/logging/Slf4jPLoggerAdapter.java @@ -175,7 +175,6 @@ public class Slf4jPLoggerAdapter implements PLogger { } sb.append(')'); } - return; } private static String normalizedParameter(Object arg) { diff --git a/profiler/src/main/java/com/navercorp/pinpoint/profiler/modifier/arcus/ParameterUtils.java b/profiler/src/main/java/com/navercorp/pinpoint/profiler/modifier/arcus/ParameterUtils.java index 34870c635..2d9858c87 100644 --- a/profiler/src/main/java/com/navercorp/pinpoint/profiler/modifier/arcus/ParameterUtils.java +++ b/profiler/src/main/java/com/navercorp/pinpoint/profiler/modifier/arcus/ParameterUtils.java @@ -5,7 +5,10 @@ import com.navercorp.pinpoint.bootstrap.instrument.MethodInfo; /** * @author emeroad */ -public class ParameterUtils { +public final class ParameterUtils { + + private ParameterUtils() { + } public static int findFirstString(MethodInfo method, int maxIndex) { if (method == null) { diff --git a/profiler/src/main/java/com/navercorp/pinpoint/profiler/modifier/db/oracle/parser/OracleNetConnectionDescriptorTokenizer.java b/profiler/src/main/java/com/navercorp/pinpoint/profiler/modifier/db/oracle/parser/OracleNetConnectionDescriptorTokenizer.java index 084fa6a13..650f56082 100644 --- a/profiler/src/main/java/com/navercorp/pinpoint/profiler/modifier/db/oracle/parser/OracleNetConnectionDescriptorTokenizer.java +++ b/profiler/src/main/java/com/navercorp/pinpoint/profiler/modifier/db/oracle/parser/OracleNetConnectionDescriptorTokenizer.java @@ -184,7 +184,6 @@ public class OracleNetConnectionDescriptorTokenizer { if (!(token == TOKEN_EQUAL_OBJECT)) { throw new OracleConnectionStringException("Syntax error. Expected token='=' :" + token.getToken()); } - return ; } public void checkEndToken() { @@ -196,7 +195,6 @@ public class OracleNetConnectionDescriptorTokenizer { if (!(token == TOKEN_KEY_END_OBJECT)) { throw new OracleConnectionStringException("Syntax error. Expected token=')' :" + token.getToken()); } - return; } public Token getLiteralToken() { diff --git a/profiler/src/main/java/com/navercorp/pinpoint/profiler/util/AnnotationValueMapper.java b/profiler/src/main/java/com/navercorp/pinpoint/profiler/util/AnnotationValueMapper.java index ca19e8809..1ddf12fb0 100644 --- a/profiler/src/main/java/com/navercorp/pinpoint/profiler/util/AnnotationValueMapper.java +++ b/profiler/src/main/java/com/navercorp/pinpoint/profiler/util/AnnotationValueMapper.java @@ -51,7 +51,6 @@ public final class AnnotationValueMapper { } String str = StringUtils.drop(value.toString()); annotation.setValue(TAnnotationValue.stringValue(str)); - return; } } diff --git a/profiler/src/main/java/com/navercorp/pinpoint/profiler/util/ErrorInjectUtils.java b/profiler/src/main/java/com/navercorp/pinpoint/profiler/util/ErrorInjectUtils.java index f0303f2c3..a4a6b4f60 100644 --- a/profiler/src/main/java/com/navercorp/pinpoint/profiler/util/ErrorInjectUtils.java +++ b/profiler/src/main/java/com/navercorp/pinpoint/profiler/util/ErrorInjectUtils.java @@ -5,15 +5,19 @@ import java.util.Random; /** * */ -public class ErrorInjectUtils { +public final class ErrorInjectUtils { private static final Random random = new Random(); + private ErrorInjectUtils() { + } + public static void randomSleep(int mod) { int i = Math.abs(random.nextInt() % mod); try { Thread.sleep(i); } catch (InterruptedException e) { + Thread.currentThread().interrupt();; } } diff --git a/profiler/src/main/java/com/navercorp/pinpoint/profiler/util/PreparedStatementUtils.java b/profiler/src/main/java/com/navercorp/pinpoint/profiler/util/PreparedStatementUtils.java index e7a2f7f33..351e60944 100644 --- a/profiler/src/main/java/com/navercorp/pinpoint/profiler/util/PreparedStatementUtils.java +++ b/profiler/src/main/java/com/navercorp/pinpoint/profiler/util/PreparedStatementUtils.java @@ -13,12 +13,15 @@ import java.util.regex.Pattern; /** * @author emeroad */ -public class PreparedStatementUtils { +public final class PreparedStatementUtils { private static final Pattern BIND_SETTER = Pattern.compile("set[A-Z]([a-zA-Z]+)"); private static final List bindMethod; + private PreparedStatementUtils() { + } + static { bindMethod = findBindVariableSetMethod0(); } diff --git a/profiler/src/main/java/com/navercorp/pinpoint/profiler/util/RuntimeMXBeanUtils.java b/profiler/src/main/java/com/navercorp/pinpoint/profiler/util/RuntimeMXBeanUtils.java index c7e831a07..4b7bd8aa6 100644 --- a/profiler/src/main/java/com/navercorp/pinpoint/profiler/util/RuntimeMXBeanUtils.java +++ b/profiler/src/main/java/com/navercorp/pinpoint/profiler/util/RuntimeMXBeanUtils.java @@ -29,7 +29,7 @@ public final class RuntimeMXBeanUtils { } public static List getVmArgs() { - List vmArgs = RUNTIME_MBEAN.getInputArguments(); + final List vmArgs = RUNTIME_MBEAN.getInputArguments(); if (vmArgs == null) { return Collections.emptyList(); } @@ -76,6 +76,10 @@ public final class RuntimeMXBeanUtils { } } + public static String getName() { + return RUNTIME_MBEAN.getName(); + } + private static Logger getLogger() { return Logger.getLogger(RuntimeMXBeanUtils.class.getName()); } diff --git a/profiler/src/main/java/com/navercorp/pinpoint/profiler/util/SystemUtils.java b/profiler/src/main/java/com/navercorp/pinpoint/profiler/util/SystemUtils.java index f6d1e9032..75420703c 100644 --- a/profiler/src/main/java/com/navercorp/pinpoint/profiler/util/SystemUtils.java +++ b/profiler/src/main/java/com/navercorp/pinpoint/profiler/util/SystemUtils.java @@ -10,10 +10,10 @@ public final class SystemUtils { } public static long getCurrentThreadCpuTime() { - return THREAD_MX_BEAN.getCurrentThreadCpuTime(); - } + return THREAD_MX_BEAN.getCurrentThreadCpuTime(); + } public static long getCurrentThreadUserTime() { - return THREAD_MX_BEAN.getCurrentThreadUserTime(); + return THREAD_MX_BEAN.getCurrentThreadUserTime(); } } diff --git a/profiler/src/test/java/com/navercorp/pinpoint/profiler/util/LoaderUtils.java b/profiler/src/test/java/com/navercorp/pinpoint/profiler/util/LoaderUtils.java index 590f7b8ad..3bd233dc7 100644 --- a/profiler/src/test/java/com/navercorp/pinpoint/profiler/util/LoaderUtils.java +++ b/profiler/src/test/java/com/navercorp/pinpoint/profiler/util/LoaderUtils.java @@ -8,6 +8,9 @@ import javassist.Loader; */ public final class LoaderUtils { + private LoaderUtils() { + } + public static Loader createLoader(ClassPool classPool) { if (classPool == null) { throw new NullPointerException("classPool must not be null"); diff --git a/rpc/src/main/java/com/navercorp/pinpoint/rpc/client/PinpointSocketHandler.java b/rpc/src/main/java/com/navercorp/pinpoint/rpc/client/PinpointSocketHandler.java index 702213acd..f160d2f15 100644 --- a/rpc/src/main/java/com/navercorp/pinpoint/rpc/client/PinpointSocketHandler.java +++ b/rpc/src/main/java/com/navercorp/pinpoint/rpc/client/PinpointSocketHandler.java @@ -668,7 +668,7 @@ public class PinpointSocketHandler extends SimpleChannelHandler implements Socke } } - class SocketHandlerContext { + static class SocketHandlerContext { private final Channel channel; private final StreamChannelManager streamChannelManager; diff --git a/rpc/src/main/java/com/navercorp/pinpoint/rpc/control/ControlMessageEncoder.java b/rpc/src/main/java/com/navercorp/pinpoint/rpc/control/ControlMessageEncoder.java index 842adba2c..0dba5f24e 100644 --- a/rpc/src/main/java/com/navercorp/pinpoint/rpc/control/ControlMessageEncoder.java +++ b/rpc/src/main/java/com/navercorp/pinpoint/rpc/control/ControlMessageEncoder.java @@ -40,7 +40,7 @@ public class ControlMessageEncoder { } private void encode(Object value, ChannelBuffer cb) throws ProtocolException { - try { +// try { if (value == null) { encodeNull(cb); } else if (value instanceof String) { @@ -75,9 +75,9 @@ public class ControlMessageEncoder { } else { throw new ProtocolException("Unsupported type : " + value.getClass().getName()); } - } catch (Exception e) { - throw new ProtocolException(e); - } +// } catch (Exception e) { +// throw new ProtocolException(e); +// } } private void encodeNull(ChannelBuffer out) { diff --git a/rpc/src/main/java/com/navercorp/pinpoint/rpc/util/ControlMessageEncodingUtils.java b/rpc/src/main/java/com/navercorp/pinpoint/rpc/util/ControlMessageEncodingUtils.java index bee113961..f6cde8103 100644 --- a/rpc/src/main/java/com/navercorp/pinpoint/rpc/util/ControlMessageEncodingUtils.java +++ b/rpc/src/main/java/com/navercorp/pinpoint/rpc/util/ControlMessageEncodingUtils.java @@ -9,7 +9,7 @@ import com.navercorp.pinpoint.rpc.control.ProtocolException; /** * @author koo.taejin */ -public class ControlMessageEncodingUtils { +public final class ControlMessageEncodingUtils { private static final ControlMessageEncoder encoder = new ControlMessageEncoder(); private static final ControlMessageDecoder decoder = new ControlMessageDecoder(); diff --git a/rpc/src/main/java/com/navercorp/pinpoint/rpc/util/MapUtils.java b/rpc/src/main/java/com/navercorp/pinpoint/rpc/util/MapUtils.java index 8c9f0c23d..70e8a9fe2 100644 --- a/rpc/src/main/java/com/navercorp/pinpoint/rpc/util/MapUtils.java +++ b/rpc/src/main/java/com/navercorp/pinpoint/rpc/util/MapUtils.java @@ -6,7 +6,7 @@ import java.util.Map; /** * @author koo.taejin */ -public class MapUtils { +public final class MapUtils { private MapUtils() { } diff --git a/rpc/src/test/java/com/navercorp/pinpoint/rpc/TestByteUtils.java b/rpc/src/test/java/com/navercorp/pinpoint/rpc/TestByteUtils.java index 87977b83a..8cf782c38 100644 --- a/rpc/src/test/java/com/navercorp/pinpoint/rpc/TestByteUtils.java +++ b/rpc/src/test/java/com/navercorp/pinpoint/rpc/TestByteUtils.java @@ -5,10 +5,13 @@ import java.util.Random; /** * @author emeroad */ -public class TestByteUtils { +public final class TestByteUtils { private static final Random RANDOM = new Random(); + private TestByteUtils() { + } + public static byte[] createRandomByte(int size) { byte[] bytes = new byte[size]; RANDOM.nextBytes(bytes); diff --git a/thrift/src/main/java/com/navercorp/pinpoint/thrift/io/BytesUtils.java b/thrift/src/main/java/com/navercorp/pinpoint/thrift/io/BytesUtils.java index 3f3bcf012..d04316b82 100644 --- a/thrift/src/main/java/com/navercorp/pinpoint/thrift/io/BytesUtils.java +++ b/thrift/src/main/java/com/navercorp/pinpoint/thrift/io/BytesUtils.java @@ -3,7 +3,11 @@ package com.navercorp.pinpoint.thrift.io; /** * @author emeroad */ -class BytesUtils { +final class BytesUtils { + + private BytesUtils() { + } + public static byte writeShort1(final short value) { return (byte) (value >> 8); } diff --git a/thrift/src/main/java/com/navercorp/pinpoint/thrift/io/HeaderUtils.java b/thrift/src/main/java/com/navercorp/pinpoint/thrift/io/HeaderUtils.java index 3e6abb4a9..519cb8dc8 100644 --- a/thrift/src/main/java/com/navercorp/pinpoint/thrift/io/HeaderUtils.java +++ b/thrift/src/main/java/com/navercorp/pinpoint/thrift/io/HeaderUtils.java @@ -9,6 +9,9 @@ final class HeaderUtils { public static final int PASS_L4 = 85; // Udp public static final int FAIL = 0; + private HeaderUtils() { + } + public static int validateSignature(byte signature) { if (Header.SIGNATURE == signature) { return OK; diff --git a/web/src/main/java/com/navercorp/pinpoint/web/dao/ibatis/SqlUtils.java b/web/src/main/java/com/navercorp/pinpoint/web/dao/ibatis/SqlUtils.java index 91a2a840a..62765f792 100644 --- a/web/src/main/java/com/navercorp/pinpoint/web/dao/ibatis/SqlUtils.java +++ b/web/src/main/java/com/navercorp/pinpoint/web/dao/ibatis/SqlUtils.java @@ -9,7 +9,10 @@ import java.util.StringTokenizer; * @author emeroad * @since 1.7.4 */ -public class SqlUtils { +public final class SqlUtils { + private SqlUtils() { + } + /** * query의 빈줄" \t\n\r\f"을 모두 제거하여 한줄로 만든다. * @param original 원본 query diff --git a/web/src/main/java/com/navercorp/pinpoint/web/util/LimitUtils.java b/web/src/main/java/com/navercorp/pinpoint/web/util/LimitUtils.java index b9a42a795..263f3018c 100644 --- a/web/src/main/java/com/navercorp/pinpoint/web/util/LimitUtils.java +++ b/web/src/main/java/com/navercorp/pinpoint/web/util/LimitUtils.java @@ -6,6 +6,9 @@ package com.navercorp.pinpoint.web.util; public final class LimitUtils { public static final int MAX = 10000; + private LimitUtils() { + } + public static int checkRange(final int limit) { if (limit < 0) { throw new IllegalArgumentException("negative limit:" + limit); diff --git a/web/src/main/java/com/navercorp/pinpoint/web/util/TimeUtils.java b/web/src/main/java/com/navercorp/pinpoint/web/util/TimeUtils.java index 60b3d050e..6f55f45d3 100644 --- a/web/src/main/java/com/navercorp/pinpoint/web/util/TimeUtils.java +++ b/web/src/main/java/com/navercorp/pinpoint/web/util/TimeUtils.java @@ -4,6 +4,9 @@ package com.navercorp.pinpoint.web.util; * */ public class TimeUtils { + private TimeUtils() { + } + public static long getDelayLastTime() { return System.currentTimeMillis() - 3000; }