diff --git a/commons/src/main/java/com/navercorp/pinpoint/common/hbase/distributor/RangeOneByteSimpleHash.java b/commons/src/main/java/com/navercorp/pinpoint/common/hbase/distributor/RangeOneByteSimpleHash.java index c3bf0489f..1ade1aff1 100644 --- a/commons/src/main/java/com/navercorp/pinpoint/common/hbase/distributor/RangeOneByteSimpleHash.java +++ b/commons/src/main/java/com/navercorp/pinpoint/common/hbase/distributor/RangeOneByteSimpleHash.java @@ -68,7 +68,7 @@ public class RangeOneByteSimpleHash implements RowKeyDistributorByHashPrefix.Has @Override public void init(String storedParams) { - this.mod = Integer.valueOf(storedParams); + this.mod = Integer.parseInt(storedParams); } } diff --git a/profiler/src/main/java/com/navercorp/pinpoint/profiler/AgentInformationFactory.java b/profiler/src/main/java/com/navercorp/pinpoint/profiler/AgentInformationFactory.java index fb636d2b3..8f529d2f5 100644 --- a/profiler/src/main/java/com/navercorp/pinpoint/profiler/AgentInformationFactory.java +++ b/profiler/src/main/java/com/navercorp/pinpoint/profiler/AgentInformationFactory.java @@ -41,10 +41,13 @@ public class AgentInformationFactory { } private void validateId(String id, String idName, int maxlen) { + if (id == null) { + throw new NullPointerException("id must not be null"); + } // 에러 체크 로직을 bootclass 앞단으로 이동시켜야 함. // 아니면 여기서 체크해서 실패시 agent동작을 하지 않도록 하던가 하는 추가 동작을 해야함. - byte[] bytes = BytesUtils.toBytes(id); - if (bytes.length > maxlen) { + final byte[] bytes = BytesUtils.toBytes(id); + if (bytes.length > maxlen) { logger.warn("{} is too long(1~24). value={}", idName, id); } } diff --git a/web/src/main/java/com/navercorp/pinpoint/web/filter/FromToResponseFilter1.java b/web/src/main/java/com/navercorp/pinpoint/web/filter/FromToResponseFilter1.java index f3eee1d07..88ecfff66 100644 --- a/web/src/main/java/com/navercorp/pinpoint/web/filter/FromToResponseFilter1.java +++ b/web/src/main/java/com/navercorp/pinpoint/web/filter/FromToResponseFilter1.java @@ -56,15 +56,15 @@ public class FromToResponseFilter1 implements Filter { String[] conditions = condition.split(","); if (conditions.length == 2) { // from,to findError = false; - fromResponseTime = Long.valueOf(conditions[0]); - toResponseTime = Long.valueOf(conditions[1]); + fromResponseTime = Long.parseLong(conditions[0]); + toResponseTime = Long.parseLong(conditions[1]); } else if (conditions.length == 3) { // error,from,to findError = ERROR.equals(conditions[0]); if (!findError) { throw new IllegalArgumentException("invalid conditions:" + condition); } - fromResponseTime = Long.valueOf(conditions[1]); - toResponseTime = Long.valueOf(conditions[2]); + fromResponseTime = Long.parseLong(conditions[1]); + toResponseTime = Long.parseLong(conditions[2]); } else if (conditions.length == 1) { // error only findError = ERROR.equals(conditions[0]); if (!findError) {