From dfbaa71c19bc60f17aa95ab7b00ca6f7248c6bce Mon Sep 17 00:00:00 2001
From: Jongho Moon <jongho.moon@navercorp.com>
Date: Fri, 27 Mar 2015 16:57:25 +0900
Subject: [PATCH] throw exception when resolving MetadataAccessor or
 FieldAccessor if @Name is not present

---
 .../plugin/objectfactory/PinpointTypeResolver.java       | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/profiler/src/main/java/com/navercorp/pinpoint/profiler/plugin/objectfactory/PinpointTypeResolver.java b/profiler/src/main/java/com/navercorp/pinpoint/profiler/plugin/objectfactory/PinpointTypeResolver.java
index 52fc676c9..ffb8e3a35 100644
--- a/profiler/src/main/java/com/navercorp/pinpoint/profiler/plugin/objectfactory/PinpointTypeResolver.java
+++ b/profiler/src/main/java/com/navercorp/pinpoint/profiler/plugin/objectfactory/PinpointTypeResolver.java
@@ -27,6 +27,7 @@ import com.navercorp.pinpoint.bootstrap.interceptor.MethodDescriptor;
 import com.navercorp.pinpoint.bootstrap.plugin.Cached;
 import com.navercorp.pinpoint.bootstrap.plugin.Name;
 import com.navercorp.pinpoint.bootstrap.plugin.ProfilerPluginContext;
+import com.navercorp.pinpoint.exception.PinpointException;
 import com.navercorp.pinpoint.profiler.plugin.TypeUtils;
 
 /**
@@ -72,7 +73,7 @@ public class PinpointTypeResolver implements ParameterResolver {
             Annotation annotation = TypeUtils.findAnnotation(annotations, Name.class);
             
             if (annotation == null) {
-                return null;
+                throw new PinpointException("MetadataAccessor parameter must be annotated with @Name");
             }
             
             MetadataAccessor accessor = pluginContext.getMetadataAccessor(((Name)annotation).value());
@@ -81,11 +82,11 @@ public class PinpointTypeResolver implements ParameterResolver {
             Annotation annotation = TypeUtils.findAnnotation(annotations, Name.class);
             
             if (annotation == null) {
-                return null;
+                throw new PinpointException("FieldAccessor parameter must be annotated with @Name");
             }
             
-            FieldAccessor snooper = pluginContext.getFieldSnooper(((Name)annotation).value());
-            return Option.<Object>withValue(snooper);
+            FieldAccessor accessor = pluginContext.getFieldAccessor(((Name)annotation).value());
+            return Option.<Object>withValue(accessor);
         }
         
         return Option.<Object>empty();