From 7ac1b089510703555f9694de2c09f16ae83f8620 Mon Sep 17 00:00:00 2001 From: Xylus Date: Wed, 31 Dec 2014 18:25:14 +0900 Subject: [PATCH] modified comments in English --- .../pinpoint/bootstrap/interceptor/InterceptorRegistry.java | 2 +- .../navercorp/pinpoint/bootstrap/AgentClassLoaderTest.java | 4 ++-- .../navercorp/pinpoint/bootstrap/PinpointBootStrapTest.java | 2 +- .../pinpoint/bootstrap/PinpointURLClassLoaderTest.java | 6 +++--- .../navercorp/pinpoint/bootstrap/util/NetworkUtilsTest.java | 2 +- .../java/com/navercorp/pinpoint/common/ServiceType.java | 2 +- .../com/navercorp/pinpoint/common/hbase/HBaseTables.java | 3 +-- 7 files changed, 10 insertions(+), 11 deletions(-) diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/interceptor/InterceptorRegistry.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/interceptor/InterceptorRegistry.java index 57ad16805..867294d3d 100644 --- a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/interceptor/InterceptorRegistry.java +++ b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/interceptor/InterceptorRegistry.java @@ -84,7 +84,7 @@ public class InterceptorRegistry { public StaticAroundInterceptor getInterceptor0(int key) { StaticAroundInterceptor interceptor = index[key]; if (interceptor == null) { - // 로직이 잘못되었을 경우 에러가 발생하지 않도록 더미를 리턴. + // return DUMMY upon wrong logic return DUMMY; } return interceptor; diff --git a/bootstrap/src/test/java/com/navercorp/pinpoint/bootstrap/AgentClassLoaderTest.java b/bootstrap/src/test/java/com/navercorp/pinpoint/bootstrap/AgentClassLoaderTest.java index e4aadacca..df9fd23f6 100644 --- a/bootstrap/src/test/java/com/navercorp/pinpoint/bootstrap/AgentClassLoaderTest.java +++ b/bootstrap/src/test/java/com/navercorp/pinpoint/bootstrap/AgentClassLoaderTest.java @@ -41,7 +41,7 @@ public class AgentClassLoaderTest { AgentClassLoader agentClassLoader = new AgentClassLoader(new URL[0]); agentClassLoader.setBootClass("com.navercorp.pinpoint.bootstrap.DummyAgent"); agentClassLoader.boot("agentPath", "test", new DummyInstrumentation(), new ProfilerConfig()); - // TODO logger가져오는 기능이 달라져서 확인이 필요함. + // TODO need verification - implementation for obtaining logger changed // PLoggerBinder loggerBinder = (PLoggerBinder) agentClassLoader.initializeLoggerBinder(); // PLogger test = loggerBinder.getLogger("test"); // test.info("slf4j logger test"); @@ -49,7 +49,7 @@ public class AgentClassLoaderTest { } private String getProjectLibDir() { - // 필요는 없으나 protectionDomain을 테스트하기 좋아 내비둠. + // not really necessary, but useful for testing protectionDomain ProtectionDomain protectionDomain = AgentClassLoader.class.getProtectionDomain(); CodeSource codeSource = protectionDomain.getCodeSource(); URL location = codeSource.getLocation(); diff --git a/bootstrap/src/test/java/com/navercorp/pinpoint/bootstrap/PinpointBootStrapTest.java b/bootstrap/src/test/java/com/navercorp/pinpoint/bootstrap/PinpointBootStrapTest.java index 634ed0c67..938a6812f 100644 --- a/bootstrap/src/test/java/com/navercorp/pinpoint/bootstrap/PinpointBootStrapTest.java +++ b/bootstrap/src/test/java/com/navercorp/pinpoint/bootstrap/PinpointBootStrapTest.java @@ -34,7 +34,7 @@ public class PinpointBootStrapTest { Assert.assertTrue(PinpointBootStrap.getLoadState()); PinpointBootStrap.premain("test", new DummyInstrumentation()); - // 중복 된경우를 체크 할수 있는 방법이 로그 확인 뿐이 없나?? + // is leaving a log the only way to test for duplicate loading? // ? check } } diff --git a/bootstrap/src/test/java/com/navercorp/pinpoint/bootstrap/PinpointURLClassLoaderTest.java b/bootstrap/src/test/java/com/navercorp/pinpoint/bootstrap/PinpointURLClassLoaderTest.java index 8762251f3..766fef9c4 100644 --- a/bootstrap/src/test/java/com/navercorp/pinpoint/bootstrap/PinpointURLClassLoaderTest.java +++ b/bootstrap/src/test/java/com/navercorp/pinpoint/bootstrap/PinpointURLClassLoaderTest.java @@ -44,9 +44,9 @@ public class PinpointURLClassLoaderTest { // } catch (ClassNotFoundException e) { // // } -// 사실 위에 코드로 정상 테스트가 가능해야 겠지만 bootstrap testcase에서는 jar라서 찾을수 없음 -// 아래 코드로 로드 하는 클래스인지 체크 정도만 하자. -// URL에 다가 pinpoint.jar를 걸면 되긴하겠지만. 관리가 힘들듯함. + // should be able to test using the above code, but it is not possible from bootstrap testcase. + // it could be possible by specifying the full path to the URL classloader, but it would be harder to maintain. + // for now, just test if DefaultAgent is specified to be loaded Assert.assertTrue(cl.onLoadClass("com.navercorp.pinpoint.profiler.DefaultAgent")); } } diff --git a/bootstrap/src/test/java/com/navercorp/pinpoint/bootstrap/util/NetworkUtilsTest.java b/bootstrap/src/test/java/com/navercorp/pinpoint/bootstrap/util/NetworkUtilsTest.java index 468a37c50..36eaa5c07 100644 --- a/bootstrap/src/test/java/com/navercorp/pinpoint/bootstrap/util/NetworkUtilsTest.java +++ b/bootstrap/src/test/java/com/navercorp/pinpoint/bootstrap/util/NetworkUtilsTest.java @@ -61,7 +61,7 @@ public class NetworkUtilsTest { Assert.assertEquals("www.naver.com", hostFromURL1_1); - // TODO default port가 기본값으로 들어갔을 경우 어떤 처리가 맞는건가? + // TODO how should we resolve host when the url includes the default port? String hostFromURL2 = NetworkUtils.getHostFromURL("http://www.naver.com:80"); Assert.assertEquals("www.naver.com:80", hostFromURL2); diff --git a/commons/src/main/java/com/navercorp/pinpoint/common/ServiceType.java b/commons/src/main/java/com/navercorp/pinpoint/common/ServiceType.java index 80a80f685..50fe203c3 100644 --- a/commons/src/main/java/com/navercorp/pinpoint/common/ServiceType.java +++ b/commons/src/main/java/com/navercorp/pinpoint/common/ServiceType.java @@ -59,7 +59,7 @@ public enum ServiceType { /** * Database - * xxx_EXECUTE_QUERY만 server map통계정보에 집계된다. + * shown only as xxx_EXECUTE_QUERY at the statistics info section in the server map */ // DB 2000 UNKNOWN_DB((short) 2050, "UNKNOWN_DB", TERMINAL, !RECORD_STATISTICS, INCLUDE_DESTINATION, NORMAL_SCHEMA), diff --git a/commons/src/main/java/com/navercorp/pinpoint/common/hbase/HBaseTables.java b/commons/src/main/java/com/navercorp/pinpoint/common/hbase/HBaseTables.java index 5924fa5d7..e4902fe42 100644 --- a/commons/src/main/java/com/navercorp/pinpoint/common/hbase/HBaseTables.java +++ b/commons/src/main/java/com/navercorp/pinpoint/common/hbase/HBaseTables.java @@ -72,9 +72,8 @@ public final class HBaseTables { public static final byte[] MAP_STATISTICS_CALLER_CF_COUNTER = Bytes.toBytes("C"); public static final String MAP_STATISTICS_CALLEE = "ApplicationMapStatisticsCallee"; - // 나중에 삭제할것. 관련 코드도같이 제거해도 됨. + // to be removed - use ver2 instead. remove relevant code as well. public static final byte[] MAP_STATISTICS_CALLEE_CF_COUNTER = Bytes.toBytes("C"); - // 신버전의 column Name저장용. public static final byte[] MAP_STATISTICS_CALLEE_CF_VER2_COUNTER = Bytes.toBytes("D"); public static final String MAP_STATISTICS_SELF = "ApplicationMapStatisticsSelf";