From 418face282d1f3593301330a0c0c3c29f5f97599 Mon Sep 17 00:00:00 2001 From: Woonduk Kang Date: Thu, 17 Mar 2016 11:34:34 +0900 Subject: [PATCH] code cleanup - fix static inner class - remove unused field --- .../interceptor/SpanAsyncEventSimpleAroundInterceptor.java | 2 +- .../okhttp/interceptor/DispatcherEnqueueMethodInterceptor.java | 1 - .../interceptor/HttpEngineReadResponseMethodInterceptor.java | 1 - .../java/com/navercorp/pinpoint/web/scatter/ScatterData.java | 2 +- 4 files changed, 2 insertions(+), 4 deletions(-) diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/interceptor/SpanAsyncEventSimpleAroundInterceptor.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/interceptor/SpanAsyncEventSimpleAroundInterceptor.java index b54adea42..f500cea93 100644 --- a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/interceptor/SpanAsyncEventSimpleAroundInterceptor.java +++ b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/interceptor/SpanAsyncEventSimpleAroundInterceptor.java @@ -14,7 +14,7 @@ import com.navercorp.pinpoint.common.trace.ServiceType; public abstract class SpanAsyncEventSimpleAroundInterceptor implements AroundInterceptor { protected final PLogger logger = PLoggerFactory.getLogger(getClass()); protected final boolean isDebug = logger.isDebugEnabled(); - protected final String SCOPE_NAME = "##ASYNC_TRACE_SCOPE"; + protected static final String SCOPE_NAME = "##ASYNC_TRACE_SCOPE"; protected final MethodDescriptor methodDescriptor; protected final TraceContext traceContext; diff --git a/plugins/okhttp/src/main/java/com/navercorp/pinpoint/plugin/okhttp/interceptor/DispatcherEnqueueMethodInterceptor.java b/plugins/okhttp/src/main/java/com/navercorp/pinpoint/plugin/okhttp/interceptor/DispatcherEnqueueMethodInterceptor.java index f3a185506..d2edc743d 100644 --- a/plugins/okhttp/src/main/java/com/navercorp/pinpoint/plugin/okhttp/interceptor/DispatcherEnqueueMethodInterceptor.java +++ b/plugins/okhttp/src/main/java/com/navercorp/pinpoint/plugin/okhttp/interceptor/DispatcherEnqueueMethodInterceptor.java @@ -38,7 +38,6 @@ public class DispatcherEnqueueMethodInterceptor implements AroundInterceptor { private TraceContext traceContext; private MethodDescriptor methodDescriptor; - private InterceptorScope interceptorScope; public DispatcherEnqueueMethodInterceptor(TraceContext traceContext, MethodDescriptor methodDescriptor) { this.traceContext = traceContext; diff --git a/plugins/okhttp/src/main/java/com/navercorp/pinpoint/plugin/okhttp/interceptor/HttpEngineReadResponseMethodInterceptor.java b/plugins/okhttp/src/main/java/com/navercorp/pinpoint/plugin/okhttp/interceptor/HttpEngineReadResponseMethodInterceptor.java index faaa8c1e8..422c5250f 100644 --- a/plugins/okhttp/src/main/java/com/navercorp/pinpoint/plugin/okhttp/interceptor/HttpEngineReadResponseMethodInterceptor.java +++ b/plugins/okhttp/src/main/java/com/navercorp/pinpoint/plugin/okhttp/interceptor/HttpEngineReadResponseMethodInterceptor.java @@ -36,7 +36,6 @@ public class HttpEngineReadResponseMethodInterceptor implements AroundIntercepto private TraceContext traceContext; private MethodDescriptor methodDescriptor; - private InterceptorScope interceptorScope; private final boolean statusCode; public HttpEngineReadResponseMethodInterceptor(TraceContext traceContext, MethodDescriptor methodDescriptor, boolean statusCode) { diff --git a/web/src/main/java/com/navercorp/pinpoint/web/scatter/ScatterData.java b/web/src/main/java/com/navercorp/pinpoint/web/scatter/ScatterData.java index a406bb1a5..6a0e26f64 100644 --- a/web/src/main/java/com/navercorp/pinpoint/web/scatter/ScatterData.java +++ b/web/src/main/java/com/navercorp/pinpoint/web/scatter/ScatterData.java @@ -186,7 +186,7 @@ public class ScatterData { return latestAcceptedTime; } - private class XCoordinatesComparator implements Comparator { + private static class XCoordinatesComparator implements Comparator { @Override public int compare(Long o1, Long o2) {