From ee7e46c2ef67f59544bfa5d68437f324a296940e Mon Sep 17 00:00:00 2001 From: Xylus Date: Wed, 31 Dec 2014 18:38:58 +0900 Subject: [PATCH] modified comments in English --- .../pinpoint/common/bo/AgentStatCpuLoadBoTest.java | 2 +- .../java/com/navercorp/pinpoint/common/bo/SpanBoTest.java | 2 +- .../com/navercorp/pinpoint/common/bo/SpanEventBoTest.java | 2 +- .../pinpoint/common/buffer/AutomaticBufferTest.java | 1 - .../navercorp/pinpoint/common/buffer/FixedBufferTest.java | 4 ++-- .../com/navercorp/pinpoint/common/util/SqlParserTest.java | 6 +++--- 6 files changed, 8 insertions(+), 9 deletions(-) diff --git a/commons/src/test/java/com/navercorp/pinpoint/common/bo/AgentStatCpuLoadBoTest.java b/commons/src/test/java/com/navercorp/pinpoint/common/bo/AgentStatCpuLoadBoTest.java index 015cf4050..0ffadcd1c 100644 --- a/commons/src/test/java/com/navercorp/pinpoint/common/bo/AgentStatCpuLoadBoTest.java +++ b/commons/src/test/java/com/navercorp/pinpoint/common/bo/AgentStatCpuLoadBoTest.java @@ -27,7 +27,7 @@ import com.navercorp.pinpoint.common.bo.AgentStatCpuLoadBo; */ public class AgentStatCpuLoadBoTest { - // CPU 사용량 소수점 2자리 표시 + // for comparing CPU Usage up to 2 decimal places private static final double DELTA = 1e-4; @Test diff --git a/commons/src/test/java/com/navercorp/pinpoint/common/bo/SpanBoTest.java b/commons/src/test/java/com/navercorp/pinpoint/common/bo/SpanBoTest.java index 200f1b2ba..e25b58fbd 100644 --- a/commons/src/test/java/com/navercorp/pinpoint/common/bo/SpanBoTest.java +++ b/commons/src/test/java/com/navercorp/pinpoint/common/bo/SpanBoTest.java @@ -87,7 +87,7 @@ public class SpanBoTest { Assert.assertEquals(newSpanBo.getErrCode(), spanBo.getErrCode()); Assert.assertEquals(newSpanBo.getFlag(), spanBo.getFlag()); -// 이건 serialize에서 안가져옴. +// not included for serialization // Assert.assertEquals(newSpanBo.getTraceAgentStartTime(), spanBo.getTraceAgentStartTime()); // Assert.assertEquals(newSpanBo.getTraceTransactionSequence(), spanBo.getTraceTransactionSequence()); Assert.assertEquals(newSpanBo.getParentSpanId(), spanBo.getParentSpanId()); diff --git a/commons/src/test/java/com/navercorp/pinpoint/common/bo/SpanEventBoTest.java b/commons/src/test/java/com/navercorp/pinpoint/common/bo/SpanEventBoTest.java index bb63004ed..70dc044c7 100644 --- a/commons/src/test/java/com/navercorp/pinpoint/common/bo/SpanEventBoTest.java +++ b/commons/src/test/java/com/navercorp/pinpoint/common/bo/SpanEventBoTest.java @@ -66,7 +66,7 @@ public class SpanEventBoTest { Assert.assertEquals(spanEventBo.getStartElapsed(), newSpanEventBo.getStartElapsed()); - // 아래는 rowKeye에서 가져 오는값. + // we get these from the row key spanEventBo.setSpanId(1); newSpanEventBo.setSpanId(1); Assert.assertEquals(spanEventBo.getSpanId(), newSpanEventBo.getSpanId()); diff --git a/commons/src/test/java/com/navercorp/pinpoint/common/buffer/AutomaticBufferTest.java b/commons/src/test/java/com/navercorp/pinpoint/common/buffer/AutomaticBufferTest.java index c71af7136..7855912a3 100644 --- a/commons/src/test/java/com/navercorp/pinpoint/common/buffer/AutomaticBufferTest.java +++ b/commons/src/test/java/com/navercorp/pinpoint/common/buffer/AutomaticBufferTest.java @@ -196,7 +196,6 @@ public class AutomaticBufferTest { Buffer buffer = new AutomaticBuffer(1); buffer.putPrefixedString(null); byte[] internalBuffer = buffer.getInternalBuffer(); - // 상속 관계에 의해서 강제로 버퍼 사이즈를 늘어나지 않아도 되는데 사이즈가 늘어남. Assert.assertEquals(1, internalBuffer.length); } diff --git a/commons/src/test/java/com/navercorp/pinpoint/common/buffer/FixedBufferTest.java b/commons/src/test/java/com/navercorp/pinpoint/common/buffer/FixedBufferTest.java index ad0731c30..172b93364 100644 --- a/commons/src/test/java/com/navercorp/pinpoint/common/buffer/FixedBufferTest.java +++ b/commons/src/test/java/com/navercorp/pinpoint/common/buffer/FixedBufferTest.java @@ -364,9 +364,9 @@ public class FixedBufferTest { @Test public void testPutSVar32() throws Exception { - // 63이 1바이트 경계. + // 63 is the boundary for a 1 byte number checkSVarInt(63, -1); - // 8191이 2바이트 경계 + // 8191 is the boundary for a 2 byte number checkSVarInt((1024*8)-1, -1); checkSVarInt(3, -1); diff --git a/commons/src/test/java/com/navercorp/pinpoint/common/util/SqlParserTest.java b/commons/src/test/java/com/navercorp/pinpoint/common/util/SqlParserTest.java index a2a9174b5..4dc606410 100644 --- a/commons/src/test/java/com/navercorp/pinpoint/common/util/SqlParserTest.java +++ b/commons/src/test/java/com/navercorp/pinpoint/common/util/SqlParserTest.java @@ -122,7 +122,7 @@ public class SqlParserTest { @Test public void numberState() { assertEqual("123", "0#", "123"); - // -가 진짜 숫자의 -인지 알려면 구문분석이 필요하므로 그냥 숫자만 치환한다. + // just converting numbers as it is too much work to find out if '-' represents a negative number, or is part of the SQL expression assertEqual("-123", "-0#", "123"); assertEqual("+123", "+0#", "123"); assertEqual("1.23", "0#", "1.23"); @@ -146,7 +146,7 @@ public class SqlParserTest { assertEqual("test_123", "test_123", ""); assertEqual("test_ 123", "test_ 0#", "123"); - // 사실 이건 불가능한 토큰임. + // this is effectively an impossible token assertEqual("123tst", "0#tst", "123"); } @@ -154,7 +154,7 @@ public class SqlParserTest { public void numberState2() { assertEqual("1.23e", "0#", "1.23e"); assertEqual("1.23E", "0#", "1.23E"); - // -가 진짜 숫자의 -인지 알려면 구문분석이 필요하므로 그냥 숫자만 치환한다. + // just converting numbers as it is too much work to find out if '-' represents a negative number, or is part of the SQL expression assertEqual("1.4e-10", "0#-1#", "1.4e,10"); }