From fff109d32fb554121ec4880338f996145b01c472 Mon Sep 17 00:00:00 2001 From: emeroad Date: Wed, 5 Apr 2017 19:17:13 +0900 Subject: [PATCH] [#2826] Deprecate TraceContext.getAsyncId() - Delete unnecessary code --- .../navercorp/pinpoint/bootstrap/context/TraceContext.java | 7 ++++++- .../pinpoint/plugin/arcus/interceptor/ApiInterceptor.java | 1 - 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/context/TraceContext.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/context/TraceContext.java index b4a329b14..ec864a567 100644 --- a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/context/TraceContext.java +++ b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/context/TraceContext.java @@ -79,7 +79,7 @@ public interface TraceContext { boolean cacheSql(ParsingResult parsingResult); - TraceId createTraceId(String transactionId, long parentSpanID, long spanID, short flags); + TraceId createTraceId(String transactionId, long parentSpanId, long spanId, short flags); Trace disableSampling(); @@ -87,6 +87,11 @@ public interface TraceContext { ServerMetaDataHolder getServerMetaDataHolder(); + /** + * internal api + * @deprecated Since 1.7.0 + */ + @Deprecated int getAsyncId(); JdbcContext getJdbcContext(); diff --git a/plugins/arcus/src/main/java/com/navercorp/pinpoint/plugin/arcus/interceptor/ApiInterceptor.java b/plugins/arcus/src/main/java/com/navercorp/pinpoint/plugin/arcus/interceptor/ApiInterceptor.java index 7599c43f3..0438aadc7 100644 --- a/plugins/arcus/src/main/java/com/navercorp/pinpoint/plugin/arcus/interceptor/ApiInterceptor.java +++ b/plugins/arcus/src/main/java/com/navercorp/pinpoint/plugin/arcus/interceptor/ApiInterceptor.java @@ -159,7 +159,6 @@ public class ApiInterceptor implements AroundInterceptor { try { if (isAsynchronousInvocation(target, args, result, throwable)) { // set asynchronous trace - this.traceContext.getAsyncId(); final AsyncTraceId asyncTraceId = trace.getAsyncTraceId(); recorder.recordNextAsyncId(asyncTraceId.getAsyncId()); // type check isAsynchronousInvocation