From 2ee695f388d76d56baf1e8424b2a925a2c66d5fb Mon Sep 17 00:00:00 2001 From: greg linton Date: Wed, 7 Aug 2019 12:31:42 -0600 Subject: [PATCH] Add note about force-pushing after a review has begun --- CONTRIBUTING.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index badf71c1..2258a3b5 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -61,6 +61,9 @@ make test-all Use `make docker-kill` to stop the containers. +**Addressing Feedback:** + +Once a pull request review has begun, refrain from force-pushing anything that will overwrite the history. This adds to the wait time and complexity of a review as a full review is required, rather than simply reviewing the feedback changes. [cla]: https://www.influxdata.com/legal/cla/ [new issue]: https://github.com/influxdata/telegraf/issues/new/choose