Commit Graph
1416 Commits
Author SHA1 Message Date
Daniel NelsonandGitHub 9ba023fd67 [inputs/diskio] Fix how major and minor identifiers of block devices are read. (#5566)
* Fix how major and minor identifiers of block devices are read.

The current implementation assure that the major and the minor are
coded on one byte. But they are not:

```
brw-rw----  1 root disk    252, 290 Feb 25 11:36 dm-290
```

290 as minor in this example is over 1 byte.

So after wondering why all my devices iops weren't correctly stored,
I found out that several points were added for some disks. For `dm-290`
it was overriding `252:34`, instead of getting udev stats for `252:290`.

The solution is here:
https://sites.uclouvain.be/SystInfo/usr/include/sys/sysmacros.h.html

The implementation is directly taken from this, fixing my bug.

* Use unix.Major/unix.Minor instead of custom implementation

* [diskio] Force type of stat.Rdev uint64 for mipsle compatibility

For most platforms, stat.Rdev is already a uint64 so this is without any effect
for linux,mipsle, unix.Stat_t.Rdev is a uint32, but the way to compute major and minor doesn't change, casting the uint32 has no impact either
2019-03-22 14:03:48 -07:00
Soulou 205de66dd6 [diskio] Force type of stat.Rdev uint64 for mipsle compatibility
For most platforms, stat.Rdev is already a uint64 so this is without any effect
for linux,mipsle, unix.Stat_t.Rdev is a uint32, but the way to compute major and minor doesn't change, casting the uint32 has no impact either
2019-03-21 12:00:20 +01:00
GregandDaniel Nelson 3b1ab6f362 Don't add empty healthcheck tags to consul input (#5575) 2019-03-19 13:39:42 -07:00
GregandDaniel Nelson 6a97b259eb Minimize call to collect uptime in system input (#5592) 2019-03-18 11:07:44 -07:00
Soulou 2118fbe78a Use unix.Major/unix.Minor instead of custom implementation 2019-03-15 14:36:56 +01:00
Daniel Nelson c61c48e10b Remove trailing whitespace and wordwrap readme in vsphere 2019-03-11 12:31:48 -07:00
Daniel Nelson 9db15651ea Fix ClusterRole aggregation documentation in kube_inventory 2019-03-11 12:00:20 -07:00
Daniel Nelson f298f87f0c Update changelog; vsphere readme 2019-03-11 11:55:20 -07:00
Pontus RydinandDaniel Nelson 19988a94de Add use_int_samples option for backwards compatibility (#5563) 2019-03-11 11:16:32 -07:00
Pontus RydinandDaniel Nelson 1752619e35 Remove calls to destroy on ViewManager (#5557) 2019-03-11 11:08:53 -07:00
Soulou 92b01ab4f9 Fix how major and minor identifiers of block devices are read.
The current implementation assure that the major and the minor are
coded on one byte. But they are not:

```
brw-rw----  1 root disk    252, 290 Feb 25 11:36 dm-290
```

290 as minor in this example is over 1 byte.

So after wondering why all my devices iops weren't correctly stored,
I found out that several points were added for some disks. For `dm-290`
it was overriding `252:34`, instead of getting udev stats for `252:290`.

The solution is here:
https://sites.uclouvain.be/SystInfo/usr/include/sys/sysmacros.h.html

The implementation is directly taken from this, fixing my bug.
2019-03-11 01:31:30 +01:00
Dheeraj DwivediandDaniel Nelson 80155029c4 Add TTL field to ping input (#5556) 2019-03-08 14:30:38 -08:00
Daniel Nelson 7da57fe5f5 Fix incorrect option in net_response sample config 2019-03-08 14:10:55 -08:00
GregandDaniel Nelson 03920075e4 Fix links and add config to webhook readme (#5558) 2019-03-08 11:25:20 -08:00
Daniel NelsonandGitHub c3e793bb4e Return any errors when creating tls config (#5541) 2019-03-06 17:37:44 -08:00
emilyandDaniel Nelson dd67144660 Add Base64-encoding/decoding for Google Cloud PubSub plugins (#5543) 2019-03-06 17:34:47 -08:00
Matthew CrenshawandDaniel Nelson 1872356103 Add multicast support to socket_listener input 2019-02-27 10:43:39 -08:00
Daniel NelsonandGitHub b805e83b71 Add additional metrics to rabbitmq input 2019-02-26 18:41:18 -08:00
GregandDaniel Nelson c6612a4e4a Add cloud pubsub push input plugin (#5442) 2019-02-26 18:25:42 -08:00
Daniel Nelson c023ffe0a5 Add unique_timestamp option from grok parser to logparser grok 2019-02-26 18:05:04 -08:00
GregandDaniel Nelson 9740e956ca Log permission error and ignore in filecount input (#5483) 2019-02-26 14:03:25 -08:00
GregandDaniel Nelson 5253cbfa01 Add ceph_health metrics to ceph input (#5482) 2019-02-25 16:02:30 -08:00
GregandDaniel Nelson 7fa8b33066 Add backwards compatibility fields in ceph usage and pool stats (#5466) 2019-02-25 15:32:05 -08:00
GregandDaniel Nelson 9d8a574ac7 Add kinesis input plugin (#5341) 2019-02-25 12:02:57 -08:00
Daniel NelsonandGitHub eb794ec30f Log the protocol and address that socket_listener is listening on (#5454) 2019-02-25 11:11:25 -08:00
Daniel NelsonandGitHub 0882479cbf Add command logging to snmp input at debug level (#5474) 2019-02-25 11:04:34 -08:00
Daniel NelsonandGitHub 9e0248898f Disable results by row in azuredb query (#5467) 2019-02-25 10:54:19 -08:00
Daniel Nelson 0a2cc3ac3f Update link to grok built in patterns 2019-02-21 12:11:00 -08:00
Daniel Nelson 3c95b25588 Update link to grok built in patterns 2019-02-21 12:08:59 -08:00
Daniel Nelson f8cc9719a2 Document how to increase the file limit in the ping input 2019-02-20 17:57:39 -08:00
emilyandDaniel Nelson 0a01713bcc Retry restarting receiver on PubSub service error (#5458) 2019-02-20 17:33:56 -08:00
Daniel NelsonandGitHub 843d842d02 Add stackdriver input plugin (#5406) 2019-02-20 13:23:59 -08:00
GregandDaniel Nelson e586fdb27f Append host if arguments are specified for ping input (#5450) 2019-02-19 11:18:15 -08:00
GregandDaniel Nelson 3e9703a573 Add rcode tag and field to dns_query input (#5417) 2019-02-12 17:57:20 -08:00
Tomas BartonandDaniel Nelson ee5827ccbd Remove error log when snmp6 directory does not exists with nstat input (#5403) (#5413) 2019-02-12 16:17:09 -08:00
Pontus RydinandDaniel Nelson c0bb8625dc Add resource path based filtering to vsphere input (#5165) 2019-02-12 14:05:14 -08:00
GregandDaniel Nelson ddf35ddaf3 Note how to use all namespaces in kube_inventory (#5416) 2019-02-12 11:36:22 -08:00
Phil SchwartzandDaniel Nelson c8832a28c4 Set deadlock priority in sqlserver input (#5301) 2019-02-11 17:10:42 -08:00
GregandDaniel Nelson 16a7ce39da Add internal metric for line too long in influxdb_listener (#5396) 2019-02-11 12:49:06 -08:00
GregandDaniel Nelson 1137fa50ad Continue checking cert from other sources if error occurs (#5381) 2019-02-05 17:38:04 -08:00
GregandDaniel Nelson 94de223916 Add kube_inventory input plugin (#5110) 2019-02-04 12:28:43 -08:00
Daniel NelsonandGitHub 00734c56c4 Return new Syslog instance for each plugin (#5372) 2019-02-04 11:21:16 -08:00
Daniel Nelson 8e46414da2 Clean pubsub sample config 2019-02-01 12:27:31 -08:00
Pontus RydinandDaniel Nelson d207269a30 Added performance section to vsphere README (#5353) 2019-01-29 17:32:48 -08:00
Jeff AshtonandDaniel Nelson 4ca0a04df1 Removing authentication from the /ping route to match influxdb (#5316) 2019-01-25 12:57:35 -08:00
vignemail1andDaniel Nelson 7a229e25a6 Update sudo config recommendation (#5337) 2019-01-24 10:54:25 -08:00
Daniel Nelson 35d18d3fd7 Update multifile plugin docs 2019-01-23 17:26:50 -08:00
Martin PittermannandDaniel Nelson 7a031c48cd Add multifile input plugin (#5256) 2019-01-23 16:23:58 -08:00
Daniel NelsonandGitHub d1610d50e6 Always send basic auth in jenkins input (#5329) 2019-01-23 14:17:57 -08:00
Daniel Nelson 17460be771 List deprecation version for consul datacentre 2019-01-23 14:12:19 -08:00