From 692d1edea62a7d82c0b886170310e95943bf7185 Mon Sep 17 00:00:00 2001 From: Nicholas Kinsey Date: Sat, 24 Sep 2011 16:07:32 +1000 Subject: [PATCH] Revert "Optimising THREE.ExtrudeGeometry::addShape" This reverts commit 285b51a1c1a029af6cd5294bffe13f857e6076a4. --- src/extras/geometries/ExtrudeGeometry.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/extras/geometries/ExtrudeGeometry.js b/src/extras/geometries/ExtrudeGeometry.js index 927640e0..b05a44a0 100644 --- a/src/extras/geometries/ExtrudeGeometry.js +++ b/src/extras/geometries/ExtrudeGeometry.js @@ -198,9 +198,11 @@ THREE.ExtrudeGeometry.prototype.addShape = function( shape, options ) { var contour = vertices; // vertices has all points but contour has only points of circumference for ( h = 0, hl = holes.length; h < hl; h ++ ) { - - Array.prototype.push.apply( vertices, holes[ h ] ); - + + ahole = holes[ h ]; + + vertices = vertices.concat( ahole ); + } @@ -382,7 +384,7 @@ THREE.ExtrudeGeometry.prototype.addShape = function( shape, options ) { } holesMovements.push( oneHoleMovements ); - Array.prototype.push.apply( verticesMovements, oneHoleMovements ); + verticesMovements = verticesMovements.concat( oneHoleMovements ); }