Merge pull request #496 from munnerz/ratelimiter

release-0.2: Always use AddRateLimited. Adjust exponential backoff base/max.
This commit is contained in:
jetstack-bot
2018-04-23 10:29:45 +01:00
committed by GitHub
4 changed files with 9 additions and 9 deletions
+4 -4
View File
@@ -66,11 +66,11 @@ func New(
) *Controller {
ctrl := &Controller{client: client, cmClient: cmClient, issuerFactory: issuerFactory, recorder: recorder}
ctrl.syncHandler = ctrl.processNextWorkItem
ctrl.queue = workqueue.NewNamedRateLimitingQueue(workqueue.DefaultControllerRateLimiter(), "certificates")
ctrl.queue = workqueue.NewNamedRateLimitingQueue(workqueue.NewItemExponentialFailureRateLimiter(time.Second*2, time.Minute*1), "certificates")
// Create a scheduled work queue that calls the ctrl.queue.Add method for
// each object in the queue. This is used to schedule re-checks of
// Certificate resources when they get near to expiry
ctrl.scheduledWorkQueue = scheduler.NewScheduledWorkQueue(ctrl.queue.Add)
ctrl.scheduledWorkQueue = scheduler.NewScheduledWorkQueue(ctrl.queue.AddRateLimited)
certificatesInformer.Informer().AddEventHandler(&controllerpkg.QueuingEventHandler{Queue: ctrl.queue})
ctrl.certificateLister = certificatesInformer.Lister()
@@ -117,7 +117,7 @@ func (c *Controller) secretDeleted(obj interface{}) {
runtime.HandleError(err)
continue
}
c.queue.Add(key)
c.queue.AddRateLimited(key)
}
}
@@ -138,7 +138,7 @@ func (c *Controller) ingressDeleted(obj interface{}) {
runtime.HandleError(err)
continue
}
c.queue.Add(key)
c.queue.AddRateLimited(key)
}
}
+2 -2
View File
@@ -57,7 +57,7 @@ func New(
) *Controller {
ctrl := &Controller{client: cl, cmClient: cmClient, issuerFactory: issuerFactory, recorder: recorder, clusterResourceNamespace: clusterResourceNamespace}
ctrl.syncHandler = ctrl.processNextWorkItem
ctrl.queue = workqueue.NewNamedRateLimitingQueue(workqueue.DefaultControllerRateLimiter(), "clusterissuers")
ctrl.queue = workqueue.NewNamedRateLimitingQueue(workqueue.NewItemExponentialFailureRateLimiter(time.Second*2, time.Minute*1), "clusterissuers")
clusterIssuersInformer.Informer().AddEventHandler(&controllerpkg.QueuingEventHandler{Queue: ctrl.queue})
ctrl.issuerInformerSynced = clusterIssuersInformer.Informer().HasSynced
@@ -90,7 +90,7 @@ func (c *Controller) secretDeleted(obj interface{}) {
runtime.HandleError(err)
continue
}
c.queue.Add(key)
c.queue.AddRateLimited(key)
}
}
+2 -2
View File
@@ -55,7 +55,7 @@ func New(
) *Controller {
ctrl := &Controller{client: cl, cmClient: cmClient, issuerFactory: issuerFactory, recorder: recorder}
ctrl.syncHandler = ctrl.processNextWorkItem
ctrl.queue = workqueue.NewNamedRateLimitingQueue(workqueue.DefaultControllerRateLimiter(), "issuers")
ctrl.queue = workqueue.NewNamedRateLimitingQueue(workqueue.NewItemExponentialFailureRateLimiter(time.Second*2, time.Minute*1), "issuers")
issuersInformer.Informer().AddEventHandler(&controllerpkg.QueuingEventHandler{Queue: ctrl.queue})
ctrl.issuerInformerSynced = issuersInformer.Informer().HasSynced
@@ -88,7 +88,7 @@ func (c *Controller) secretDeleted(obj interface{}) {
runtime.HandleError(err)
continue
}
c.queue.Add(key)
c.queue.AddRateLimited(key)
}
}
+1 -1
View File
@@ -24,7 +24,7 @@ func (q *QueuingEventHandler) Enqueue(obj interface{}) {
runtime.HandleError(err)
return
}
q.Queue.Add(key)
q.Queue.AddRateLimited(key)
}
func (q *QueuingEventHandler) OnAdd(obj interface{}) {