mirror of
https://github.com/wahyd4/cert-manager.git
synced 2026-08-09 05:06:38 +10:00
Adds note as to why v1beta1 is still an accepted
`conversionReviewVersion` Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
This commit is contained in:
@@ -27,6 +27,13 @@ spec:
|
||||
strategy: Webhook
|
||||
# webhookClientConfig is required when strategy is `Webhook` and it configures the webhook endpoint to be called by API server.
|
||||
webhook:
|
||||
# We don't actually support `v1beta1` but is listed here as it is a
|
||||
# required value for [Kubernetes v1.16](kubernetes/kubernetes#82023). The
|
||||
# API server reads the supported versions in order, so _should always_
|
||||
# attempt a `v1` request which is understood by the cert-manager webhook.
|
||||
# Any `v1beta1` request will return an error and fail closed for that
|
||||
# resource (the whole object request is rejected).
|
||||
# When we no longer support v1.16 we can remove `v1beta1` from this list.
|
||||
conversionReviewVersions: ["v1", "v1beta1"]
|
||||
clientConfig:
|
||||
# {{- if .Values.webhook.url.host }}
|
||||
|
||||
@@ -27,6 +27,13 @@ spec:
|
||||
strategy: Webhook
|
||||
# webhookClientConfig is required when strategy is `Webhook` and it configures the webhook endpoint to be called by API server.
|
||||
webhook:
|
||||
# We don't actually support `v1beta1` but is listed here as it is a
|
||||
# required value for [Kubernetes v1.16](kubernetes/kubernetes#82023). The
|
||||
# API server reads the supported versions in order, so _should always_
|
||||
# attempt a `v1` request which is understood by the cert-manager webhook.
|
||||
# Any `v1beta1` request will return an error and fail closed for that
|
||||
# resource (the whole object request is rejected).
|
||||
# When we no longer support v1.16 we can remove `v1beta1` from this list.
|
||||
conversionReviewVersions: ["v1", "v1beta1"]
|
||||
clientConfig:
|
||||
# {{- if .Values.webhook.url.host }}
|
||||
|
||||
@@ -25,6 +25,13 @@ spec:
|
||||
strategy: Webhook
|
||||
# webhookClientConfig is required when strategy is `Webhook` and it configures the webhook endpoint to be called by API server.
|
||||
webhook:
|
||||
# We don't actually support `v1beta1` but is listed here as it is a
|
||||
# required value for [Kubernetes v1.16](kubernetes/kubernetes#82023). The
|
||||
# API server reads the supported versions in order, so _should always_
|
||||
# attempt a `v1` request which is understood by the cert-manager webhook.
|
||||
# Any `v1beta1` request will return an error and fail closed for that
|
||||
# resource (the whole object request is rejected).
|
||||
# When we no longer support v1.16 we can remove `v1beta1` from this list.
|
||||
conversionReviewVersions: ["v1", "v1beta1"]
|
||||
clientConfig:
|
||||
# {{- if .Values.webhook.url.host }}
|
||||
|
||||
@@ -24,6 +24,13 @@ spec:
|
||||
strategy: Webhook
|
||||
# webhookClientConfig is required when strategy is `Webhook` and it configures the webhook endpoint to be called by API server.
|
||||
webhook:
|
||||
# We don't actually support `v1beta1` but is listed here as it is a
|
||||
# required value for [Kubernetes v1.16](kubernetes/kubernetes#82023). The
|
||||
# API server reads the supported versions in order, so _should always_
|
||||
# attempt a `v1` request which is understood by the cert-manager webhook.
|
||||
# Any `v1beta1` request will return an error and fail closed for that
|
||||
# resource (the whole object request is rejected).
|
||||
# When we no longer support v1.16 we can remove `v1beta1` from this list.
|
||||
conversionReviewVersions: ["v1", "v1beta1"]
|
||||
clientConfig:
|
||||
# {{- if .Values.webhook.url.host }}
|
||||
|
||||
@@ -24,6 +24,13 @@ spec:
|
||||
strategy: Webhook
|
||||
# webhookClientConfig is required when strategy is `Webhook` and it configures the webhook endpoint to be called by API server.
|
||||
webhook:
|
||||
# We don't actually support `v1beta1` but is listed here as it is a
|
||||
# required value for [Kubernetes v1.16](kubernetes/kubernetes#82023). The
|
||||
# API server reads the supported versions in order, so _should always_
|
||||
# attempt a `v1` request which is understood by the cert-manager webhook.
|
||||
# Any `v1beta1` request will return an error and fail closed for that
|
||||
# resource (the whole object request is rejected).
|
||||
# When we no longer support v1.16 we can remove `v1beta1` from this list.
|
||||
conversionReviewVersions: ["v1", "v1beta1"]
|
||||
clientConfig:
|
||||
# {{- if .Values.webhook.url.host }}
|
||||
|
||||
@@ -25,6 +25,13 @@ spec:
|
||||
strategy: Webhook
|
||||
# webhookClientConfig is required when strategy is `Webhook` and it configures the webhook endpoint to be called by API server.
|
||||
webhook:
|
||||
# We don't actually support `v1beta1` but is listed here as it is a
|
||||
# required value for [Kubernetes v1.16](kubernetes/kubernetes#82023). The
|
||||
# API server reads the supported versions in order, so _should always_
|
||||
# attempt a `v1` request which is understood by the cert-manager webhook.
|
||||
# Any `v1beta1` request will return an error and fail closed for that
|
||||
# resource (the whole object request is rejected).
|
||||
# When we no longer support v1.16 we can remove `v1beta1` from this list.
|
||||
conversionReviewVersions: ["v1", "v1beta1"]
|
||||
clientConfig:
|
||||
# {{- if .Values.webhook.url.host }}
|
||||
|
||||
Reference in New Issue
Block a user