home/cert-manager
2
0
Fork 0
mirror of https://github.com/wahyd4/cert-manager.git synced 2026-08-09 05:06:38 +10:00
Code Issues Packages Projects Releases Wiki Activity

Update root ctl command to no longer pass a factory to sub commands

Browse Source 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
This commit is contained in:
joshvanl
2021-08-24 16:30:44 +01:00
parent 20c1de7626
commit 80a7bc5412
3 changed files with 9 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/ctl/BUILD.bazel
+1
View File
@@ -38,6 +38,7 @@ filegroup(
"//cmd/ctl/pkg/create:all-srcs",
"//cmd/ctl/pkg/deny:all-srcs",
"//cmd/ctl/pkg/experimental:all-srcs",
"//cmd/ctl/pkg/factory:all-srcs",
"//cmd/ctl/pkg/inspect:all-srcs",
"//cmd/ctl/pkg/install:all-srcs",
"//cmd/ctl/pkg/renew:all-srcs",
cmd/ctl/cmd/BUILD.bazel
-2
View File
@@ -18,9 +18,7 @@ go_library(
"//cmd/ctl/pkg/version:go_default_library",
"@com_github_spf13_cobra//:go_default_library",
"@io_k8s_cli_runtime//pkg/genericclioptions:go_default_library",
"@io_k8s_client_go//plugin/pkg/client/auth:go_default_library",
"@io_k8s_klog_v2//:go_default_library",
"@io_k8s_kubectl//pkg/cmd/util:go_default_library",
],
)
cmd/ctl/cmd/cmd.go
+8 -17
View File
@@ -25,10 +25,7 @@ import (
"github.com/spf13/cobra"
"k8s.io/cli-runtime/pkg/genericclioptions"
// Load all auth plugins
_ "k8s.io/client-go/plugin/pkg/client/auth"
"k8s.io/klog/v2"
"k8s.io/kubectl/pkg/cmd/util"
"github.com/jetstack/cert-manager/cmd/ctl/pkg/approve"
"github.com/jetstack/cert-manager/cmd/ctl/pkg/check"
@@ -51,12 +48,6 @@ kubectl cert-manager is a CLI tool manage and configure cert-manager resources f
}
cmds.SetUsageTemplate(usageTemplate)
kubeConfigFlags := genericclioptions.NewConfigFlags(true)
kubeConfigFlags.AddFlags(cmds.PersistentFlags())
matchVersionKubeConfigFlags := util.NewMatchVersionFlags(kubeConfigFlags)
matchVersionKubeConfigFlags.AddFlags(cmds.PersistentFlags())
factory := util.NewFactory(matchVersionKubeConfigFlags)
cmds.Flags().AddGoFlagSet(flag.CommandLine)
flag.CommandLine.Parse([]string{})
fakefs := flag.NewFlagSet("fake", flag.ExitOnError)
@@ -69,16 +60,16 @@ kubectl cert-manager is a CLI tool manage and configure cert-manager resources f
ioStreams := genericclioptions.IOStreams{In: in, Out: out, ErrOut: err}
cmds.AddCommand(version.NewCmdVersion(ctx, ioStreams, factory))
cmds.AddCommand(convert.NewCmdConvert(ctx, ioStreams))
cmds.AddCommand(create.NewCmdCreate(ctx, ioStreams, factory))
cmds.AddCommand(renew.NewCmdRenew(ctx, ioStreams, factory))
cmds.AddCommand(status.NewCmdStatus(ctx, ioStreams, factory))
cmds.AddCommand(inspect.NewCmdInspect(ctx, ioStreams, factory))
cmds.AddCommand(approve.NewCmdApprove(ctx, ioStreams, factory))
cmds.AddCommand(deny.NewCmdDeny(ctx, ioStreams, factory))
cmds.AddCommand(check.NewCmdCheck(ctx, ioStreams, factory))
cmds.AddCommand(create.NewCmdCreate(ctx, ioStreams))
cmds.AddCommand(renew.NewCmdRenew(ctx, ioStreams))
cmds.AddCommand(status.NewCmdStatus(ctx, ioStreams))
cmds.AddCommand(inspect.NewCmdInspect(ctx, ioStreams))
cmds.AddCommand(approve.NewCmdApprove(ctx, ioStreams))
cmds.AddCommand(deny.NewCmdDeny(ctx, ioStreams))
cmds.AddCommand(check.NewCmdCheck(ctx, ioStreams))
// Experimental features
cmds.AddCommand(experimental.NewCmdExperimental(ctx, ioStreams, factory))
cmds.AddCommand(experimental.NewCmdExperimental(ctx, ioStreams))
return cmds
}