Merge pull request #1121 from munnerz/crt-issue-status-condition

Don't update Certificate status condition upon issuance
This commit is contained in:
jetstack-bot
2018-11-30 11:42:13 +00:00
committed by GitHub
+1 -11
View File
@@ -55,12 +55,6 @@ const (
successCertificateRenewed = "CertRenewed"
messageErrorSavingCertificate = "Error saving TLS certificate: "
messageIssuingCertificate = "Issuing certificate..."
messageRenewingCertificate = "Renewing certificate..."
messageCertificateIssued = "Certificate issued successfully"
messageCertificateRenewed = "Certificate renewed successfully"
)
const (
@@ -365,11 +359,7 @@ func (c *Controller) issue(ctx context.Context, issuer issuer.Interface, crt *v1
}
if len(resp.Certificate) > 0 {
s := messageCertificateIssued
glog.Info(s)
c.Recorder.Event(crt, corev1.EventTypeNormal, successCertificateIssued, s)
crt.UpdateStatusCondition(v1alpha1.CertificateConditionReady, v1alpha1.ConditionTrue, successCertificateIssued, s, true)
c.Recorder.Event(crt, corev1.EventTypeNormal, successCertificateIssued, "Certificate issued successfully")
// as we have just written a certificate, we should schedule it for renewal
c.scheduleRenewal(crt)
}