Handle case where revision of cert not set yet

Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
This commit is contained in:
Haoxiang Zhou
2020-07-10 13:54:41 +01:00
parent f5ebea1b27
commit cbf8da3197
@@ -189,8 +189,15 @@ func formatTimeString(t *metav1.Time) string {
func findMatchingCR(reqs *cmapi.CertificateRequestList, crt *cmapi.Certificate) (*cmapi.CertificateRequest, error) {
possibleMatches := []*cmapi.CertificateRequest{}
// CertificateRequest revisions begin from 1. If no revision is set on the
// status then assume no revision yet set.
nextRevision := 1
if crt.Status.Revision != nil {
nextRevision = *crt.Status.Revision + 1
}
for _, req := range reqs.Items {
if predicate.CertificateRequestRevision(*crt.Status.Revision+1)(&req) &&
if predicate.CertificateRequestRevision(nextRevision)(&req) &&
predicate.ResourceOwnedBy(crt)(&req) {
possibleMatches = append(possibleMatches, &req)
}