home/cert-manager
2
0
Fork 0
mirror of https://github.com/wahyd4/cert-manager.git synced 2026-08-14 15:46:33 +10:00
Code Issues Packages Projects Releases Wiki Activity
5,279 Commits 37 Branches 119 Tags
issue/3915
Commit Graph
5279 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
David Bond 15381e4286 Make controller's sync period configurable 
Fixes #3915

Adds the `sync-period` flag (defaulted to 1s), that allows modification of the frequency at which the controller will
pull items off the workqueue for processing.

```release-note
Adds --sync-period flag to modify the period of time between items being pulled from the controller's workqueue.
```

Signed-off-by: David Bond <davidsbond93@gmail.com>
 2021-04-23 10:44:58 +01:00
jetstack-botandGitHub 1d761f3e93 Merge pull request #3914 from SgtCoDFish/pubkeycomparison 
Fix incorrect comparison function for public keys
 2021-04-22 16:35:37 +01:00
Ashley Davis 3df1173a22 fix incorrect comparison function for public keys 
also adds/improves doc comments on related functions, and adds tests of
comparisons RSA keys and ECDSA keys. these tests failed as expected
before the function was changed, e.g.:

```text
Executing tests from //pkg/util/pki:go_default_test
---------------------------------------------------
--- FAIL: TestPublicKeysEqualECDSA (0.00s)
  generate_test.go:492: got an incorrect match from different curves:
    pub1 type: "P-256"
    pub2 type: "P-521"
--- FAIL: TestPublicKeysEqualRSA (0.00s)
  generate_test.go:560: got an incorrect match from different RSA keys:
    pub1: &rsa.PublicKey{N:2293...<snip>...8869, E:65537}
    pub2: &rsa.PublicKey{N:2293...<snip>...8869, E:3}
```

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
 2021-04-22 16:07:18 +01:00
jetstack-botandGitHub 17bf228fbb Merge pull request #3902 from SgtCoDFish/modcompatguarantee 
Add note about module compat and code style
 2021-04-20 13:57:57 +01:00
Ashley Davis 4b000dd05a Add note about module compat and code style 
Also includes some minor changes to language and title casing

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
 2021-04-20 13:20:04 +01:00
jetstack-botandGitHub 384c356f27 Merge pull request #3903 from irbekrm/temp_disable_venafi_cloud_e2e_tests 
Temporarily revert "Enable the Venafi Cloud E2E tests"
 2021-04-20 12:44:00 +01:00
irbekrm 70f3d0b8c2 Temporarily revert "Enable the Venafi Cloud E2E tests" 
This reverts commit 4ddfcbf96b.

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-04-20 12:19:43 +01:00
jetstack-botandGitHub b95836421f Merge pull request #3878 from JoshVanL/certificate-request-controller-denied-ready-condition 
Set the Ready condition to False when a CertificateRequest has been denied for all CertificateRequests that reference a cert-manager.io signer
 2021-04-13 17:22:11 +01:00
jetstack-botandGitHub 06b68d35e0 Merge pull request #3835 from RinkiyaKeDad/3620_constants_in_eventf 
chore: used constants for string literals when recording new events
 2021-04-13 15:14:11 +01:00
jetstack-botandGitHub b5be5a8730 Merge pull request #3877 from irbekrm/move_crypto_fork 
Use upstream golang/crypto for ACME EAB + move crypto fork to cert-manager org
 2021-04-13 13:28:15 +01:00
RinkiyaKeDad 0b87eeae97 added reason prefix for all 
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
 2021-04-13 16:40:56 +05:30
jetstack-botandGitHub 0c71fe7795 Merge pull request #3882 from irbekrm/fixes_helm_upgrade_error 
Certificate's revision history limit validated by webhook
 2021-04-12 15:21:07 +01:00
irbekrm fc9d966a1c Certificate's revision history limit validated by webhook 
To avoid helm upgrade issues, see https://github.com/jetstack/cert-manager/issues/3880

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-04-12 14:59:28 +01:00
jetstack-botandGitHub 0f58c3ac08 Merge pull request #3885 from alrs/alrs-fix-certificate-err 
test/integration/certificates: fix dropped error
 2021-04-12 14:50:08 +01:00
Lars Lehtonen 635dc187f5 test/integration/certificates: fix dropped error 
Signed-off-by: Lars Lehtonen <lars.lehtonen@gmail.com>
 2021-04-12 05:45:57 -07:00
irbekrm d213b4bfdb Standardize deprecation warnings 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-04-12 09:38:49 +01:00
joshvanl e05adbf06b Remove expected events when Ready Denied condition set 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-04-09 18:20:07 +01:00
joshvanl ff3e4bb07d Don't fire an event when the Denied ready condition is set 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-04-09 18:19:44 +01:00
joshvanl 9a5e36e732 Change Denied CertificateRequest Ready reason to just 'Denied' 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-04-09 18:19:11 +01:00
joshvanl 50a84eaf1d Sets the Ready condition to False when a request is Denied 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-04-09 15:34:32 +01:00
joshvanl 1d75fc480e Adds Denied to certificaterequests reporter 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-04-09 15:26:15 +01:00
joshvanl b61757187e Adds the RequestDenied Ready condition reason to API 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-04-09 15:11:28 +01:00
irbekrm 697836e446 Update comment for replace directive in go.mod 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-04-09 15:11:22 +01:00
irbekrm 2c2b3da2a7 Add e2e test cases for different ACME EAB configurations 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-04-09 10:28:34 +01:00
irbekrm 09af959071 Issuer's ACME EAB algorithm can no longer be set 
It is hardcoded to HS256 in golang.org/x/crypto

Also, we now use a fork of golang.org/x/crypto
in cert-manager org.

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-04-09 10:28:19 +01:00
jetstack-botandGitHub 1dad685e48 Merge pull request #3873 from irbekrm/remove_legacy_functions 
Remove legacy e2e util functions for Issuer creation
 2021-04-09 10:24:45 +01:00
jetstack-botandGitHub a5458a88af Merge pull request #3867 from wallrj/3555-reenable-venafi-e2e-tests 
Re-enable E2E tests for the Venafi Issuer
 2021-04-08 19:49:44 +01:00
irbekrm 333f600661 Remove legacy e2e util functions for Issuer creation 
Use test/util/gen instead

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-04-08 18:30:45 +01:00
Richard Wall c769432db5 Re-enable the Venafi TPP E2E tests 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2021-04-08 18:23:48 +01:00
Richard Wall 4ddfcbf96b Enable the Venafi Cloud E2E tests 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2021-04-08 18:23:48 +01:00
jetstack-botandGitHub 805ca33b9e Merge pull request #3622 from foosinn/fix-letsencrypt-multi 
Fix letsencrypt with rfc2136 and multiple dnsNames
 2021-04-08 15:11:45 +01:00
jetstack-botandGitHub 948c14c813 Merge pull request #3872 from maelvls/comment-rewording 
issuing-controller: explain why we do the Ready + Denied checks
 2021-04-08 14:48:45 +01:00
Maël Valais 88a6fa1315 issuing-controller: explain why we do the Ready + Denied checks 
Signed-off-by: Maël Valais <mael@vls.dev>
 2021-04-08 15:16:36 +02:00
RinkiyaKeDad bba7c1011d added prefix and made constants public 
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
 2021-04-08 12:17:15 +05:30
jetstack-botandGitHub 9c42eeebfd Merge pull request #3818 from SgtCoDFish/securitymd 
Add SECURITY.md documenting vuln report process
v1.3.0 		2021-04-07 14:47:18 +01:00
jetstack-botandGitHub 9f612f0c2e Merge pull request #3862 from jetstack/revert-3847-fix/3619 
Revert "Handle CA issuer working as intermediate correctly"
v1.3.0-beta.0 		2021-04-07 09:46:57 +01:00
Maël Valais f56db9f93d Revert "Handle CA issuer working as intermediate" (#3847) 
As discussed in #3847, I went too fast and /lgtm from my bed. That led
to having a piece of code that could potentially break people's
cert-manager deployments.

Our plan is to have the same PR re-opened so that we can have it
released for v1.4 (due on Friday 11 June 2021 as per our timeline).

Signed-off-by: Maël Valais <mael@vls.dev>
 2021-04-07 10:25:31 +02:00
jetstack-botandGitHub 79ccab3e69 Merge pull request #3847 from erikgb/fix/3619 
Handle CA issuer working as intermediate correctly
 2021-04-07 07:33:57 +01:00
jetstack-botandGitHub 2dd6b6e224 Merge pull request #3795 from JoshVanL/certificates-issuing-retry-denied-requests 
Adds Denied check to CertificateRequests in issuing controller to retry denied requests
 2021-04-06 21:34:57 +01:00
jetstack-botandGitHub 10a871dc62 Merge pull request #3444 from maelvls/bug-certificaterequest-not-updated 
Bug: certificaterequest not updated after its certificate is updated
 2021-04-06 20:17:57 +01:00
jetstack-botandGitHub 6ad91e0700 Merge pull request #3833 from JoshVanL/controller-issuer-context 
Pass context through to client calls in controllers and acme issuer
 2021-04-06 18:53:57 +01:00
Erik Godding BoyeandErik Godding Boye bbafeeef67 fix #3619: Handle CA issuer working as intermediate correctly 
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
 2021-04-06 19:45:48 +02:00
Erik Godding BoyeandErik Godding Boye 861db7bf4e Fix minor local dev environment issue 
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
 2021-04-06 19:45:48 +02:00
Maël ValaisandJosh Soref 8f5a094b0c trigger-controller: PR comment: failure mode -> failure state 
Cf. https://github.com/jetstack/cert-manager/pull/3444#pullrequestreview-629189131

Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
 2021-04-06 19:14:49 +02:00
Maël Valais 181d4ee281 DataForCertificate: typo certitificate -> certificate 
Signed-off-by: Maël Valais <mael@vls.dev>
 2021-04-06 19:06:21 +02:00
Maël Valais a7486d5025 DataForCertificate: "Failure" CR condition -> "Failed" 
Signed-off-by: Maël Valais <mael@vls.dev>
 2021-04-06 18:58:31 +02:00
Maël ValaisandJosh Soref 2361f355aa DataForCertificate: PR comment: certificate -> cert-manager certificate 
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
 2021-04-06 18:44:26 +02:00
Maël ValaisandJosh Soref de0de24aad DataForCertificate: PR comment: mode -> state 
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
 2021-04-06 18:42:17 +02:00
Maël ValaisandJosh Soref c875518da1 DataForCertificate: PR comment: mismatch -> does not match 
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
 2021-04-06 18:34:18 +02:00
Maël ValaisandJosh Soref 8b41ec1d54 DataForCertificate: PR comment: distinguish X.509 vs. Kubernetes cert 
The cert-manager team tends to use the word "certificate" for two very
different contexts:

1. sometimes, we use the word "certificate" to refer to a X.509
   certificate (a blob of ASN.1-encoded data and then PEM-formated);
2. and sometimes we refer to "certificate" as one item of the Kubernetes
   custom resource /apis/cert-manager.io/v1/certificates.

This commit makes sure the reader understands that we are talking about
the Kubernetes object here.

Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
 2021-04-06 18:25:48 +02:00