joshvanl
20c1de7626
Update all commands to no longer receive a factory, and instead use the
...
shared local factory package
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-08-24 16:30:44 +01:00
joshvanl
56b29e0f59
Change install command to use Helm to register flags. No longer need to
...
copy flag values
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-08-24 16:30:43 +01:00
joshvanl
f6b7bc973b
Adds /cmd/ctl/pkg/factory which registers Kube CLI flags, and provides
...
clients/config needed
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-08-24 16:29:01 +01:00
jetstack-bot and GitHub
c25b116fc5
Merge pull request #4406 from SgtCoDFish/removekrewauomation
...
Remove krew automation
2021-08-24 12:10:34 +01:00
Ashley Davis
b2f7aa57ea
remove krew automation
...
github actions is pretty flawed in several ways, and it's missing
features which would make it usable for us.
we want to trigger our krew automation when a new stable release of our
latest supported cert-manager release is published. github has all this
information, but it's not easy to _use_ that information when triggering
a github action.
we also only want to trigger the action on the main repo and not on
forks.
if we end up having to write custom code to do this, we might as well
add that code into cmrel and not have to deal with the flaws in gh
actions.
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io >
2021-08-24 11:24:52 +01:00
jetstack-bot and GitHub
e5cc0be04b
Merge pull request #4399 from irbekrm/fix_renewal_issue
...
Fix renewalTime skew issue
2021-08-23 16:36:50 +01:00
irbekrm
ec1bdc4983
Adds a test case for renewal time skew and a comment
...
Signed-off-by: irbekrm <irbekrm@gmail.com >
2021-08-23 15:00:57 +01:00
jetstack-bot and GitHub
38338bc7c3
Merge pull request #4402 from Juneezee/deprecate-ioutil
...
refactor: move from io/ioutil to io and os package
2021-08-23 13:50:51 +01:00
Eng Zer Jun
54e70d2cc4
refactor: move from io/ioutil to io and os package
...
The io/ioutil package has been deprecated in Go 1.16. This commit
replaces the existing io/ioutil functions with their new definitions in
io and os packages.
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com >
2021-08-23 19:50:42 +08:00
irbekrm
7a7d853d9f
Add a comment about staticcheck script
...
Also shift the correct number of params
and remove and unused def.
Signed-off-by: irbekrm <irbekrm@gmail.com >
2021-08-23 08:58:20 +01:00
irbekrm
25303b79c9
Use yq instead of jq
...
Because yq releases builds for darwin/arm
Signed-off-by: irbekrm <irbekrm@gmail.com >
2021-08-23 07:08:51 +01:00
irbekrm
ba3864e3c9
Removes the unused buildozer tool
...
Signed-off-by: irbekrm <irbekrm@gmail.com >
2021-08-22 08:58:35 +01:00
irbekrm
f7ee62e701
Pull dependencies for darwin/arm
...
Also bumps a few dependency versions
Signed-off-by: irbekrm <irbekrm@gmail.com >
2021-08-21 09:21:06 +01:00
irbekrm
50e90dfe6e
Fix renewalTime skew issue
...
Ensure the time returned by RenewalTime function is the same time as that which will be read from Certificate's status
Signed-off-by: irbekrm <irbekrm@gmail.com >
2021-08-20 17:57:35 +01:00
jetstack-bot and GitHub
38ab6f4bdd
Merge pull request #4365 from jonathansp/master
...
fix: flaky test when comparing unordered elements
2021-08-20 13:02:44 +01:00
jetstack-bot and GitHub
0ff741c9d2
Merge pull request #4392 from SgtCoDFish/fixversions
...
Fix manually specified Certificate and CertificateRequest versions
2021-08-20 12:16:45 +01:00
jetstack-bot and GitHub
72f5694659
Merge pull request #4393 from jakexks/solver_serviceType
...
Regression: restore the previous service type defaulting behaviour
2021-08-19 15:36:09 +01:00
Jake Sanders
5df1dd4932
Update Docs on solver type to reflect default service type
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me >
2021-08-19 14:55:50 +01:00
Jake Sanders
f1ac6efade
Add integration test for ensuring default solver service type is NodePort
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me >
2021-08-19 14:52:23 +01:00
Jake Sanders
326783ca32
Fix regression in solver service builder - default service type should be NodePort rather than empty
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me >
2021-08-19 14:51:21 +01:00
Ashley Davis
68f5ceb3b4
Fix manually specified Certificate and CertificateRequest versions
...
Basically all modern X.509 certs are version 3, but confusingly to
specify "version 3" in an encoded cert, the version number is actually
2.
For PKCS#10 CSRs, the only valid version is 1, which again
confusingly has the value "0" when encoded.
This was incorrect in many places, including one place in which the
version number on a CSR was used as a certificate's version number,
when the two are entirely unrelated.
Go ignores these values, so there's no functional changes here; still,
it's better to be accurate.
Go ignoring CSR version and specifying 0:
https://cs.opensource.google/go/go/+/refs/tags/go1.17:src/crypto/x509/x509.go;l=1958
Go ignoring Certificate version and specifying 2:
https://cs.opensource.google/go/go/+/refs/tags/go1.17:src/crypto/x509/x509.go;l=1534
PKCS#10 CSR specification in RFC 2986 section 4.1:
https://datatracker.ietf.org/doc/html/rfc2986#section-4
X.509 Cert specification in RFC 5280 section 4.1.2.1:
https://datatracker.ietf.org/doc/html/rfc5280#section-4.1.2.1
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io >
2021-08-19 14:48:12 +01:00
jetstack-bot and GitHub
c24c0889bf
Merge pull request #4390 from irbekrm/verify_crd_status
...
Verify crd status
2021-08-19 10:22:08 +01:00
Irbe Krumina and Ashley Davis
e43db8a426
Code review feedback.
...
Co-authored-by: Ashley Davis <SgtCoDFish@users.noreply.github.com >
Signed-off-by: irbekrm <irbekrm@gmail.com >
2021-08-19 09:43:45 +01:00
irbekrm
04b584e698
verify-crds script now verifies that the CRDs don't contain status field
...
This is necessary because some CD tools don't accept resource configs with predefined status fields, but controllergen currently adds this field when a CRD yaml is generated
Signed-off-by: irbekrm <irbekrm@gmail.com >
2021-08-19 06:19:37 +01:00
irbekrm
b8e2846901
Adds a Bazel rule to install yq
...
Signed-off-by: irbekrm <irbekrm@gmail.com >
2021-08-18 18:36:01 +01:00
jetstack-bot and GitHub
a608e850de
Merge pull request #4386 from jakexks/gnu-sed
...
Fix codegen script on Darwin
2021-08-18 18:06:29 +01:00
jetstack-bot and GitHub
c5a4cb9fbf
Merge pull request #4384 from jakexks/en_GB
...
finalisers -> finalizers
2021-08-18 17:23:35 +01:00
jetstack-bot and GitHub
bea6c20e26
Merge pull request #4369 from irbekrm/improve_owner_not_found_errors
...
Improve owner not found errors
2021-08-18 17:23:29 +01:00
jetstack-bot and GitHub
ba2e25674a
Merge pull request #4379 from irbekrm/remove_crd_status
...
Removes status fields from CRD definitions
2021-08-18 16:42:29 +01:00
Jake Sanders
682b3f108e
Fix sed command on Darwin
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me >
2021-08-18 16:09:14 +01:00
jetstack-bot and GitHub
18a15fe385
Merge pull request #4373 from jakexks/ingress_path_type
...
Fix regression in ACME HTTP-01 Ingress Solver introduced in v1.5.0
2021-08-18 15:55:28 +01:00
Jake Sanders
e0ecc9938a
finalisers -> finalizers
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me >
2021-08-18 15:33:27 +01:00
Jake Sanders
38ce03e3ec
Fix regression in Ingress PathType introduced in v1.5.0
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me >
2021-08-18 15:16:23 +01:00
jetstack-bot and GitHub
00679a557b
Merge pull request #4383 from irbekrm/vcloud_v2
...
Explicitly set Venafi Cloud e2e tests to use v2 endpoint
2021-08-18 15:15:29 +01:00
irbekrm
831b87898f
Explicitly set Venafi Cloud e2e tests to use v2 endpoint
...
Signed-off-by: irbekrm <irbekrm@gmail.com >
2021-08-18 12:52:05 +01:00
irbekrm
7d30a6452c
Removes status fields from CRD definitions
...
Signed-off-by: irbekrm <irbekrm@gmail.com >
2021-08-18 10:17:34 +01:00
irbekrm
904d4e3c15
Don't error if owner not found in cache
...
Signed-off-by: irbekrm <irbekrm@gmail.com >
2021-08-17 08:31:49 +01:00
jetstack-bot and GitHub
ff9403aaf2
Merge pull request #4366 from SgtCoDFish/krew_darwin_arm64
...
update trigger for gh action, add arm64 darwin for krew
2021-08-16 19:05:02 +02:00
Ashley Davis
b069056e0a
update trigger for gh action, add arm64 darwin for krew
...
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io >
2021-08-16 17:21:07 +01:00
Jonathan Prates
1ff50d3dd8
fix: flaky test when comparing unordered elements
...
Signed-off-by: jonathansp <jonathansimonprates@gmail.com >
2021-08-16 15:04:01 +01:00
Tomáš Freund
1a9de78bfd
add managed identity config validation success tests
...
Signed-off-by: Tomáš Freund <tomas.freund@datamole.cz >
2021-08-16 13:34:59 +02:00
jetstack-bot and GitHub
b5003b52d0
Merge pull request #4359 from johanfleury/feature/make-leader-election-defaults-consistent
...
Make leader election defaults consistent
2021-08-14 05:08:14 +02:00
jetstack-bot and GitHub
30c40f8f15
Merge pull request #4348 from inteon/upgrade_deps_v0.22.0
...
Upgrade deps (kube v0.22.0)
2021-08-14 01:07:12 +02:00
jetstack-bot and GitHub
e608995101
Merge pull request #4363 from inteon/fix_4350
...
rerun git tags command when //:version changes
2021-08-14 00:02:11 +02:00
Inteon
b13eb0483b
upgrade deps to latest version (kube v0.22.0)
...
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com >
2021-08-13 23:38:59 +02:00
Inteon
e439749e92
rerun git tags command when //:version changes
...
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com >
2021-08-13 22:59:38 +02:00
Johan Fleury
ef32714434
Make leader election defaults consistent
...
Signed-off-by: Johan Fleury <jfleury@arcaik.net >
2021-08-13 12:14:40 -04:00
Tomáš Freund
d4d49140a6
resolve null dereference issues by passing the whole struct
...
Signed-off-by: Tomáš Freund <tomas.freund@datamole.cz >
2021-08-13 17:16:12 +02:00
Tomáš Freund
283f606625
fix azure dns validation and add tests
...
Signed-off-by: Tomáš Freund <tomas.freund@datamole.cz >
2021-08-13 16:50:33 +02:00
Tomáš Freund
4ce6c33a1d
fix typo
...
Signed-off-by: Tomáš Freund <tomas.freund@datamole.cz >
2021-08-13 16:20:47 +02:00