joshvanl
c600ba07a0
Pipes in the feature gates from environment to e2e binary. Test for
...
shared feature gate existence within CertificateSigningRequest suite
test
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2022-01-04 13:17:06 +00:00
joshvanl
4d40bdcd96
Fix tests after metrics comment changes.
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-12-07 07:42:27 +00:00
joshvanl
27c43b317e
Adds deprecated message to clock_time_metrics
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-12-07 07:10:27 +00:00
joshvanl
b4f2d4982b
Ensure clockTimeSecondsGauge is registered. Updates metrics integration
...
tests to include gauge clock metric
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-12-02 12:11:20 +00:00
joshvanl
51e728688f
Adds clock_time_seconds_gauge metric which returns the current clock
...
time, based on unix time since time began
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-12-02 11:27:22 +00:00
joshvanl
6d83e3111d
Removes v1beta1 from webhook's admissionReviewVersions as we no longer
...
support Kubernetes v1.16
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-12-02 10:40:44 +00:00
joshvanl
d5503c2ed2
Change certificates controller to no longer error for a Certificate that
...
no longer exists
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-11-30 15:13:14 +00:00
joshvanl
b45482355c
Fix cobra test now cmctl is the default CLI name
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-10-14 16:36:50 +01:00
joshvanl
64feb85490
Adds bazel to build and release cmctl, along with kubectl-cert_manager
...
binary
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-10-14 15:49:46 +01:00
joshvanl
e9165e1e1c
Fix cobra tools test
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-10-14 15:30:54 +01:00
joshvanl
ce1424162e
Updates all sub commands to discover the CLI name using the build
...
package name
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-10-14 14:45:01 +01:00
joshvanl
5f5217b412
Updates command registration to use new commands package. Name CLI
...
command by the build name.
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-10-14 14:44:19 +01:00
joshvanl
2f99b3130c
Adds build/commands package to expose which commands should be
...
registered. Gates the completion command which is disabled by defualt.
Can be configured at build time.
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-10-14 14:43:05 +01:00
joshvanl
bbd39de0fc
Adds build package to allow discovering the correct name of the CLI
...
command. Can be configured at build time.
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-10-14 14:42:10 +01:00
joshvanl
bae35d8adb
Add ValidArgs functions to all commands to allow auto-completion of
...
runtime object names
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-10-14 13:20:31 +01:00
joshvanl
f21a947523
Adds comment as to why the GetAuthorization is called instead of
...
GetChallenge
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-09-16 14:44:38 +01:00
joshvanl
f83f02cc8b
Replace GetChallenge call in acmechallenge controller to
...
GetAuthorization
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-09-15 16:05:37 +01:00
joshvanl
b75a68088c
Vault internal client should check health conn err before checking
...
response status
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-09-15 15:57:05 +01:00
joshvanl
0c96c54416
Adds the ACME client middleware when create an ACME account
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-09-03 13:47:43 +01:00
joshvanl
8c95605d8e
Adds generate completion scripts for bash, zsh, fish, and powershell
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-09-02 12:00:09 +01:00
joshvanl
707c8dd40d
Add ValidArgs functions to all commands to allow auto-completion of
...
runtime object names
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-08-25 17:58:38 +01:00
joshvanl
33621ca333
Use helm settings to define CLI flags for install command
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-08-24 19:11:23 +01:00
joshvanl
4cdbb64003
Update ctl integration tests to use new local factory package
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-08-24 16:37:01 +01:00
joshvanl
80a7bc5412
Update root ctl command to no longer pass a factory to sub commands
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-08-24 16:30:44 +01:00
joshvanl
20c1de7626
Update all commands to no longer receive a factory, and instead use the
...
shared local factory package
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-08-24 16:30:44 +01:00
joshvanl
56b29e0f59
Change install command to use Helm to register flags. No longer need to
...
copy flag values
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-08-24 16:30:43 +01:00
joshvanl
f6b7bc973b
Adds /cmd/ctl/pkg/factory which registers Kube CLI flags, and provides
...
clients/config needed
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-08-24 16:29:01 +01:00
joshvanl
d3f3f458ed
Updates the kind cluster for v1.22 to v1.22.0-rc.0
...
https://console.cloud.google.com/gcr/images/jetstack-build-infra-images/EU/kind@sha256:fa600aa4b8234235e141fab085126e2a72c3d8f05eed44d38bf343091c51d192/details?tab=info
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-30 12:06:22 +01:00
joshvanl
1d926e8e50
Adds UserInfo fields to conversion webhook tests
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-29 17:35:13 +01:00
joshvanl
d261e2eadb
Defined AdmissionReviewVersions:[]string{"v1"} in API webhook
...
configuration integration tests
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-29 14:54:17 +01:00
joshvanl
a09c93f885
Set integration apiserver webhook configuration to use AdmissionReviewVersions=[]string{"v1"}
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-29 14:11:46 +01:00
joshvanl
29514ff09d
Adds v1beta1 as a supported admissionReviewVersion with a note as to
...
why it is listed even though we don't support it
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-29 11:10:25 +01:00
joshvanl
fbfe48cad8
Change webhook manifests for mutation and validation to only accept v1
...
in admissionReviewVersions
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-29 11:10:25 +01:00
joshvanl
bd95b3779c
Change integration test apiserver to only be configured with v1
...
admission configuration
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-29 11:10:25 +01:00
joshvanl
8470ba96f0
Change webhook admission/mutation to no longer understand and reject anything which is not
...
v1 (remove v1beta1)
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-29 11:10:24 +01:00
joshvanl
6c5a4897b6
Adds note as to why v1beta1 is still an accepted
...
`conversionReviewVersion`
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-28 15:49:50 +01:00
joshvanl
b3ece6708a
Adds v1beta1 as a conversionReviewVersion but don't actually support
...
it
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-28 15:36:58 +01:00
joshvanl
1f4343d98e
Move exported cmd util func to package where it is used. Removes util
...
package
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-28 14:25:17 +01:00
joshvanl
78e77f99db
Use correct import for apiextensions in same webhook
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-26 17:46:36 +01:00
joshvanl
5680bfd4b3
Change all CRDs to no longer accept v1beta1 conversionReviewVersions
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-26 17:05:58 +01:00
joshvanl
be2ad9ed15
Update sample ACME webhook to use apiextensions v1beta1 -> v1
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-26 17:04:35 +01:00
joshvanl
a3cb2b8a41
Update ACME e2e tests to use apiextensions v1beta1 -> v1
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-26 17:03:58 +01:00
joshvanl
12d4246c8a
Update ACME clients to use apiextensions v1beta1 -> v1
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-26 17:03:34 +01:00
joshvanl
a9aa3b3579
Update ACME webhook API to use apiextensions v1beta1 -> v1
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-26 17:03:14 +01:00
joshvanl
5762b5706e
Update Conversion webhook to no longer understand v1beta1, only v1
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-26 17:02:18 +01:00
joshvanl
f180f0a0e6
Change internal ACME API to use apiextensions v1beta1 -> v1
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-26 17:00:08 +01:00
joshvanl
d87ac770fe
Change ACME API to use apiextensions v1beta1 -> v1
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-26 16:59:42 +01:00
joshvanl
58519e442a
Change admissionregistration.k8s.io v1beta1 to v1 in integration tests
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-26 16:26:45 +01:00
joshvanl
696356b702
Update certificates.k8s.io-adoption design to include changes which have
...
been implemented
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-26 14:20:18 +01:00
joshvanl
68a065e34f
Updates from meeting
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-26 13:29:50 +01:00
joshvanl
eeef422165
Adds some minor spelling and grammar
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-26 13:29:50 +01:00
joshvanl
52a2ae599d
Updates the design proposal from team discussions
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-26 13:29:50 +01:00
joshvanl
686a33ca74
Add a section as to _why_ I am proposing this approach
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-26 13:29:49 +01:00
joshvanl
5f98ba69f4
Adds certificates.k8s.io Adoptions Design Document
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-26 13:29:49 +01:00
joshvanl
247807162f
Expect event fired when ACME CSR request is not yet approved
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-23 16:34:21 +01:00
joshvanl
a81ba4fcb3
Change test name to make it clear it is not a duplicate
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-23 16:10:35 +01:00
joshvanl
e18e29ea45
Adds unit tests for CertificateSigningRequest ACME handle owner
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-23 16:00:09 +01:00
joshvanl
9e322a4033
Removes old comment which is no longer relevant
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-23 16:00:09 +01:00
joshvanl
b84e3edcc9
Review comments
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-23 16:00:09 +01:00
joshvanl
bec5d5be32
Remove CA annotation from ACME CertificateSigningRequest controller
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-23 16:00:09 +01:00
joshvanl
2a1952c918
Adds ACME CSR to E2E conformance test suite
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-23 16:00:09 +01:00
joshvanl
1284f358d0
Adds missing required feature to CommonName CSR E2E test
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-23 16:00:09 +01:00
joshvanl
c9f5cbd0bc
Adds more modifier funcs to Order in unit gen
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-23 16:00:09 +01:00
joshvanl
b041a8fb3d
Wires up ACME CSR controller
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-23 16:00:09 +01:00
joshvanl
43f002b0f0
Adds CertificateSigningRequest ACME controller
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-23 16:00:09 +01:00
joshvanl
37dbf770da
Fire event when CertificateSigningRequest hasn't been signed yet
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-20 10:39:27 +01:00
joshvanl
a1a953f40f
More comments
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-19 19:29:40 +01:00
joshvanl
0fdd52e603
Adds comments to some func's and changes return err names to be more
...
clear
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-19 15:50:23 +01:00
joshvanl
0116bf18bd
Changed Venafi CSR request "the request will be retried" -> "waiting"
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-19 15:50:23 +01:00
joshvanl
37e117c452
Change CSRModifer in Kube CSR conformance tests to be a function in
...
definition so has access to runtime shared variables at runtime
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-19 15:50:23 +01:00
joshvanl
8413b302fd
Adds random domain suffix to Venafi e2e tests
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-19 15:50:23 +01:00
joshvanl
6e57e1093f
Adds comment about what the pickup ID is in the CSR controller
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-19 15:50:23 +01:00
joshvanl
e0fc320d41
Remove CA annotation being set on Venafi CertificateSigningRequest
...
controller
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-19 15:50:23 +01:00
joshvanl
644cda69d8
Disable Ed255119 e2e tests for Venafi CSRs
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-19 15:50:23 +01:00
joshvanl
a469e07f1a
Adds Venafi E2E CertificateSigningRequest conformance suite
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-19 15:50:23 +01:00
joshvanl
ff2dfd7b64
Moves venafi addon into the framework addons package
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-19 15:50:23 +01:00
joshvanl
65cec6c212
Wires up Venafi CertificateSigningRequest controller
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-19 15:50:23 +01:00
joshvanl
c4914f7103
Adds venafi CertificateSigningRequest controller
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-19 15:50:23 +01:00
joshvanl
dcc3ad44b4
Adds CertificateSigningRequest venafi annotations to experimental API
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-19 15:50:23 +01:00
joshvanl
943f9abdb1
Minor comment and error message changes
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-06-30 18:09:32 +01:00
joshvanl
67ba2b15da
Updates comment for internal vault client New func, that errors should
...
be considered for retrying
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-06-29 14:34:49 +01:00
joshvanl
b237b5c222
Changes comment for duration annotation parsing
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-06-29 14:34:30 +01:00
joshvanl
2c217f0377
Remove CA field from Vault CertificateSigningRequest controllers
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-06-29 10:50:33 +01:00
joshvanl
f054611b32
Change vault policy string to not require escaping
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-06-29 10:41:03 +01:00
joshvanl
680c4f4a41
Fix vault setup in e2e by reverting ttl duration
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-06-29 10:41:03 +01:00
joshvanl
d0e7ccd805
Update some CSR comments
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-06-29 10:41:03 +01:00
joshvanl
a6a394236b
Revert Vault e2e ttl setting, and make Ed keys an unsupported feature
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-06-29 10:41:03 +01:00
joshvanl
889e7b9c50
Revert e2e vault setup to use original max certificate TTL, and fix
...
custom app role auth path in CSR tests
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-06-29 10:41:03 +01:00
joshvanl
f82f36bfaa
Adds Vault Kubernetes Auth CSR E2E tests
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-06-29 10:41:03 +01:00
joshvanl
9b2466589c
Adds Vault AppRole with a custom path CSR E2E tests
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-06-29 10:41:03 +01:00
joshvanl
21a05ea9de
Adds Vault AppRole CSR e2e tests
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-06-29 10:41:03 +01:00
joshvanl
aac1f24450
Expands CSR validation to allow not checking CA as the Root
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-06-29 10:37:46 +01:00
joshvanl
2c193f9f60
Changes Vault e2e addon to enable Kubernetes Auth signing and make roles
...
ready for ClusterIssuer testing
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-06-29 09:11:43 +01:00
joshvanl
d9be35c299
Wires up Vault CSR controller
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-06-29 09:11:43 +01:00
joshvanl
f5b609e446
Adds Vault CertificateSigningRequest Issuer controller
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-06-29 09:11:43 +01:00
joshvanl
7e8bf731b2
Remove the experimental.cert-manager.io/ca annotation from the
...
CertificateSigningRequest
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-06-25 16:02:37 +01:00
joshvanl
b3804bb162
Cleans up CSR E2E validation functions, allow 30s duration fuzz, allow
...
common name copy to DNS names, spelling
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-06-18 12:20:43 +01:00
joshvanl
3eccfaaa94
Adds review comments for adding supported versions, writing to stdout,
...
removing error wraping
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-06-18 11:58:24 +01:00
joshvanl
b35a9170b7
Fix ecdsa public CSR key validation
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-06-16 10:43:49 +01:00
joshvanl
f92bdeaa80
Adds Ed25519 tests to CertificateSigningRequest conformance tests
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-06-15 18:34:08 +01:00